Skip to contentSkip to conversation

utility-tasks.bbclass: drop mrproper task

PATCH In review Chris Larson 3 participants 3 messages Sep 21, 2010 – Sep 23, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 utility-tasks.bbclass: drop mrproper task

From: Chris Larson <[email protected]>

This task is misleading and potentially quite harmful, as it wipes the entire DL_DIR, yet tasks are supposed to be recipe specific. We have the proper distclean task to wipe sources for a recipe + run do_clean, and the user can always wipe all of DL_DIR manually if necessary.

---
 classes/utility-tasks.bbclass |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)
classes/utility-tasks.bbclass +0 -12
index 29bc781..7495d96 100644
@@ -38,18 +38,6 @@ python do_rebuild() {
 	"""rebuild a package"""
 }
 
-addtask mrproper
-do_mrproper[dirs] = "${TOPDIR}"
-do_mrproper[nostamp] = "1"
-python do_mrproper() {
-	"""clear downloaded sources, build and temp directories"""
-	dir = bb.data.expand("${DL_DIR}", d)
-	if dir == '/': bb.build.FuncFailed("wrong DATADIR")
-	bb.debug(2, "removing " + dir)
-	os.system('rm -rf ' + dir)
-	bb.build.exec_func('do_clean', d)
-}
-
 addtask distclean
 do_distclean[dirs] = "${TOPDIR}"
 do_distclean[nostamp] = "1"
Signature · 1 line
1.7.2.3
Acked-by Holger Hans Peter Freyther on v1 1/1
#1 lore raw
Quoted 8 lines · Chris Larson

From: Chris Larson <[email protected]>

This task is misleading and potentially quite harmful, as it wipes the entire DL_DIR, yet tasks are supposed to be recipe specific. We have the proper distclean task to wipe sources for a recipe + run do_clean, and the user can always wipe all of DL_DIR manually if necessary.

Acked-by
#2 lore raw
Quoted 11 lines · Holger Freyther
Quoted 8 lines · Chris Larson

From: Chris Larson<[email protected]>

This task is misleading and potentially quite harmful, as it wipes the entire DL_DIR, yet tasks are supposed to be recipe specific. We have the proper distclean task to wipe sources for a recipe + run do_clean, and the user can always wipe all of DL_DIR manually if necessary.