Skip to contentSkip to conversation

scsi/scsi_debug: Add missing scsi.h defs and XDWRITEREAD_32 support

PATCH New Nicholas A. Bellinger 1 participant 1 message Sep 22, 2010 SCSI

lore
Share & tools
lore
#0 lore raw

cover scsi/scsi_debug: Add missing scsi.h defs and XDWRITEREAD_32 support

From: Nicholas Bellinger <[email protected]>

Hi Doug and James,

Attached are two patches for Linux/SCSI that I ended up needing to allow the simple XDWRITEREAD_32 passthrough into TCM/pSCSI -> struct request -> SCSI Midlayer in recent lio-core-2.6.git/lio-4.0 commits.

The first adds some missing SPC-4 CDB and MAINTENANCE_[IN,OUT] + VARIABLE_LENGTH_CMD service actions to include/scsi/scsi.h. These are used by TCM Core code and pieces of this patch have been posted here for the RFC before:

http://marc.info/?l=linux-scsi&m=128316041105964&w=2

The second adds XDWRITEREAD_32 emulation to scsi_debug, which is pretty quite simple because everything we need is already handled by XDWRITEREAD_10. 8-)

This has been tested using 'sgv4_xdwriteread -e' with TCM_Loop -> TCM/pSCSI -> scsi_debug 32-byte BIDI-COMMAND CDB passthrough on v2.6.36-rc4.

Thanks!

Nicholas Bellinger (2):
scsi: Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] and
VARIABLE_LENGTH_CMD service actions
scsi_debug: Add XDWRITEREAD_32 support

 drivers/scsi/scsi_debug.c |    3 +++
 include/scsi/scsi.h       |   28 ++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.3