Skip to contentSkip to conversation

mfd: Declare abx500_remove_ops()

PATCH In review Mark Brown 3 participants 3 messages Sep 22, 2010 – Sep 27, 2010 Multifunction devices (MFD)

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 mfd: Declare abx500_remove_ops()

Otherwise sparse warns about a public symbol with no declaration and the compiler can't spot if the callers and users have different signatures for the function.

---
 include/linux/mfd/abx500.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/mfd/abx500.h +1 -0
index be7373c..67bd6f7 100644
@@ -229,4 +229,5 @@ struct abx500_ops {
 };
 
 int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
+void abx500_remove_ops(struct device *dev);
 #endif
Signature · 1 line
1.7.1
#1 lore raw

Thanks Mark!
I'll update the abxxx-core drivers to call the remove_ops in their exit functions.

/Wallin

Quoted 19 lines · Mark Brown

Otherwise sparse warns about a public symbol with no declaration and the compiler can't spot if the callers and users have different signatures for the function.

---
 include/linux/mfd/abx500.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/mfd/abx500.h +1 -0
index be7373c..67bd6f7 100644
@@ -229,4 +229,5 @@ struct abx500_ops {
 };
 
 int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
+void abx500_remove_ops(struct device *dev);
 #endif
#2 lore raw
In reply to Mark Brown

Hi Mark,

Quoted 3 lines · Mark Brown

Otherwise sparse warns about a public symbol with no declaration and the compiler can't spot if the callers and users have different signatures for the function.

Patch applied, thanks for spotting this.

Cheers,
Samuel.

Quoted 18 lines
---
 include/linux/mfd/abx500.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/mfd/abx500.h +1 -0
index be7373c..67bd6f7 100644
@@ -229,4 +229,5 @@ struct abx500_ops {
 };
 
 int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
+void abx500_remove_ops(struct device *dev);
 #endif
Signature · 1 line
1.7.1
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/