Skip to contentSkip to conversation

oe/patch.py: Remove series file during Clean()

PATCH In review Khem Raj 3 participants 3 messages Sep 22, 2010

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 oe/patch.py: Remove series file during Clean()

Currently if there is a failed do_patch the series files get appended so if there were two patches

a.patch
b.patch
and b.patch failed during next run it would append a.patch again a.patch
b.patch
a.patch

and this would keep growing.

We can remove series file in Clean() because we populate it in Import() anyway

---
 lib/oe/patch.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
lib/oe/patch.py +1 -0
index d7f4ccb..05abccf 100644
@@ -192,6 +192,7 @@ class QuiltTree(PatchSet):
     def Clean(self):
         try:
             self._runcmd(["pop", "-a", "-f"])
+            oe.path.remove(os.path.join(self.dir, "patches","series"))
         except Exception:
             pass
         self.initialized = True
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Khem Raj

Currently if there is a failed do_patch the series files get appended so if there were two patches

a.patch
b.patch
and b.patch failed during next run it would append a.patch again a.patch
b.patch
a.patch

Quoted 7 lines

and this would keep growing.

We can remove series file in Clean() because we populate it in Import() anyway

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
Acked-by
#2 lore raw
Quoted 14 lines · Chris Larson
Quoted 12 lines · Khem Raj

Currently if there is a failed do_patch the series files get appended so if there were two patches

a.patch
b.patch
and b.patch failed during next run it would append a.patch again a.patch
b.patch
a.patch

and this would keep growing.

Quoted 8 lines
Quoted 5 lines

We can remove series file in Clean() because we populate it in Import() anyway