Skip to contentSkip to conversation

libsas: Remove host_lock unlock() + lock() from sas_queuecommand()

RFC In review Nicholas A. Bellinger 1 participant 1 message Sep 23, 2010

Subsystems (2)
SCSI SCSI libsas
lore
Share & tools
lore

Nicholas A. Bellinger

author
#0 lore raw

RFC v3 3/15 libsas: Remove host_lock unlock() + lock() from sas_queuecommand()

From: Nicholas Bellinger <[email protected]>

This patch removes the now legacy host_lock unlock() + lock() optimization from sas_scsi_host.c:sas_queuecommand()

Signed-off-by Nicholas A. Bellinger <[email protected]>
---
 drivers/scsi/libsas/sas_scsi_host.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/scsi/libsas/sas_scsi_host.c +0 -5
index f0cfba9..bc1c97c 100644
@@ -202,18 +202,14 @@ int sas_queue_up(struct sas_task *task)
  */
 int sas_queuecommand(struct scsi_cmnd *cmd,
 		     void (*scsi_done)(struct scsi_cmnd *))
-	__releases(host->host_lock)
 	__acquires(dev->sata_dev.ap->lock)
 	__releases(dev->sata_dev.ap->lock)
-	__acquires(host->host_lock)
 {
 	int res = 0;
 	struct domain_device *dev = cmd_to_domain_dev(cmd);
 	struct Scsi_Host *host = cmd->device->host;
 	struct sas_internal *i = to_sas_internal(host->transportt);
 
-	spin_unlock_irq(host->host_lock);
-
 	{
 		struct sas_ha_struct *sas_ha = dev->port->ha;
 		struct sas_task *task;

@@ -254,7 +250,6 @@ int sas_queuecommand(struct scsi_cmnd *cmd,
 		}
 	}
 out:
-	spin_lock_irq(host->host_lock);
 	return res;
 }
Signature · 1 line
1.7.3