Skip to contentSkip to conversation

signals: annotate lock context change on ptrace_stop()

PATCH RESEND New Namhyung Kim 1 participant 2 messages Sep 26, 2010 ptrace support

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/2 signals: annotate lock context change on ptrace_stop()

ptrace_stop() releases and regrabs current->sighand->siglock but was missing proper annotation. Add it.

---
 kernel/signal.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/signal.c +2 -0
index e4e8cfe..dce5c78 100644
@@ -1618,6 +1618,8 @@ static int sigkill_pending(struct task_struct *tsk)
  * is gone, we keep current->exit_code unless clear_code.
  */
 static void ptrace_stop(int exit_code, int clear_code, siginfo_t *info)
+	__releases(&current->sighand->siglock)
+	__acquires(&current->sighand->siglock)
 {
 	if (arch_ptrace_stop_needed(exit_code, info)) {
 		/*
Signature · 1 line
1.7.2.2
#1 lore raw

PATCH RESEND 2/2 ptrace: annotate lock context change on exit_ptrace()

exit_ptrace() releases and regrabs tasklist_lock but was missing proper annotation. Add it.

---
 kernel/ptrace.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/ptrace.c +2 -0
index f34d798..4afd9b8 100644
@@ -329,6 +329,8 @@ int ptrace_detach(struct task_struct *child, unsigned int data)
  * and reacquire the lock.
  */
 void exit_ptrace(struct task_struct *tracer)
+	__releases(&tasklist_lock)
+	__acquires(&tasklist_lock)
 {
 	struct task_struct *p, *n;
 	LIST_HEAD(ptrace_dead);
Signature · 1 line
1.7.2.2