ibm_newemac: use free_netdev(netdev) instead of kfree()
Subsystems (3)
PATCH 1/9 ibm_newemac: use free_netdev(netdev) instead of kfree()
Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
@@
struct net_device* dev;
@@
-kfree(dev)
+free_netdev(dev)
--- drivers/net/ibm_newemac/core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ibm_newemac/core.c +2 -2
@@ -2928,7 +2928,7 @@ static int __devinit emac_probe(struct platform_device *ofdev,if (dev->emac_irq !=NO_IRQ )irq_dispose_mapping (dev->emac_irq); err_free: -kfree (ndev); +free_netdev (ndev); err_gone:/* if we were on the bootlist, remove us as we won't show up and * wake up all waiters to notify them in case they were waiting
@@ -2971,7 +2971,7 @@ static int __devexit emac_remove(struct platform_device *ofdev)if (dev->emac_irq !=NO_IRQ )irq_dispose_mapping (dev->emac_irq); -kfree (dev->ndev); +free_netdev (dev->ndev);return 0 ; }
Signature · 1 line
1.7.0.4
From: Vasiliy Kulikov <[email protected]>
Date: Sun, 26 Sep 2010 13:58:00 +0400
Review
Quoted 12 lines
Freeing netdev without
free_netdev()leads to net, tx leaks. I might lead to dereferencing freed pointer.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)@@
struct net_device* dev;
@@(quoted diff) +1
-1-kfree(dev) +free_netdev(dev)
Applied.