rionet: use free_netdev(netdev) instead of kfree()
Subsystems (3)
PATCH 2/9 rionet: use free_netdev(netdev) instead of kfree()
Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
@@
struct net_device* dev;
@@
-kfree(dev)
+free_netdev(dev)
--- drivers/net/rionet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/rionet.c +1 -1
@@ -384,7 +384,7 @@ static void rionet_remove(struct rio_dev *rdev)free_pages ((unsigned long )rionet_active, rdev->net->hport->sys_size ?__ilog2 (sizeof (void *)) +4 :0 );unregister_netdev (ndev); -kfree (ndev); +free_netdev (ndev);list_for_each_entry_safe (peer, tmp, &rionet_peers, node) {list_del (&peer->node);
Signature · 1 line
1.7.0.4
From: Vasiliy Kulikov <[email protected]>
Date: Sun, 26 Sep 2010 13:58:03 +0400
Review
Quoted 12 lines
Freeing netdev without
free_netdev()leads to net, tx leaks. I might lead to dereferencing freed pointer.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)@@
struct net_device* dev;
@@(quoted diff) +1
-1-kfree(dev) +free_netdev(dev)
Applied.