Skip to contentSkip to conversation

mtd : add init_size hook for NAND driver

PATCH In review Huang Shijie 2 participants 4 messages Sep 24, 2010 – Sep 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd : add init_size hook for NAND driver

Not all the NAND devices have all the information in additional id bytes.

So add a hook in the nand_chip{} is a good method to calculate the right value of oobsize, erasesize and so on.

Without the hook,you will get the wrong value, and you have to hack in the ->scan_bbt() to change the wrong value which make the code mess.

---
 drivers/mtd/nand/nand_base.c |    6 ++++--
 include/linux/mtd/nand.h     |    5 +++++
 2 files changed, 9 insertions(+), 2 deletions(-)
drivers/mtd/nand/nand_base.c +4 -2
index d551ddd..0288f1f 100644
@@ -2848,8 +2848,10 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
 
 	chip->chipsize = (uint64_t)type->chipsize << 20;
 
-	/* Newer devices have all the information in additional id bytes */
-	if (!type->pagesize) {
+	if (!type->pagesize && chip->init_size) {
+		/* set the pagesize, oobsize, erasesize by the driver*/
+		busw = chip->init_size(mtd, chip);
+	} else if (!type->pagesize) {
 		int extid;
 		/* The 3rd id byte holds MLC / multichip data */
 		chip->cellinfo = id_data[2];
include/linux/mtd/nand.h +5 -0
index 102e12c..2296a7a 100644
@@ -332,6 +332,9 @@ struct nand_buffers {
  * @block_markbad:	[REPLACEABLE] mark the block bad
  * @cmd_ctrl:		[BOARDSPECIFIC] hardwarespecific funtion for controlling
  *			ALE/CLE/nCE. Also used to write command and address
+ * @init_size:		[BOARDSPECIFIC] hardwarespecific funtion for setting
+ *			mtd->oobsize, mtd->writesize and so on.
+ *			Return with the bus width.
  * @dev_ready:		[BOARDSPECIFIC] hardwarespecific function for accesing device ready/busy line
  *			If set to NULL no access to ready/busy is available and the ready/busy information
  *			is read from the chip status register
@@ -386,6 +389,8 @@ struct nand_chip {
 	int		(*block_markbad)(struct mtd_info *mtd, loff_t ofs);
 	void		(*cmd_ctrl)(struct mtd_info *mtd, int dat,
 				    unsigned int ctrl);
+	int		(*init_size)(struct mtd_info *mtd,
+					struct nand_chip *this);
 	int		(*dev_ready)(struct mtd_info *mtd);
 	void		(*cmdfunc)(struct mtd_info *mtd, unsigned command, int column, int page_addr);
 	int		(*waitfunc)(struct mtd_info *mtd, struct nand_chip *this);
Signature · 1 line
1.7.2.2
#1 lore raw
Quoted 10 lines · Huang Shijie

Not all the NAND devices have all the information in additional id bytes.

So add a hook in the nand_chip{} is a good method to calculate the right value of oobsize, erasesize and so on.

Without the hook,you will get the wrong value, and you have to hack in the ->scan_bbt() to change the wrong value which make the code mess.

Quoted 5 lines
---
 drivers/mtd/nand/nand_base.c |    6 ++++--
 include/linux/mtd/nand.h     |    5 +++++
 2 files changed, 9 insertions(+), 2 deletions(-)

Taken to l2-mtd-2.6.git, thanks.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
#2 lore raw

Hi Artem:
I think the new patch is better.

The new patch will reuse the id_data.
Even if the additional id byte does not have all the information in some case, but other infomation such as manufacture id and device id are also useful to the NAND driver.

Best regards
Huang Shijie

2010/9/26 Artem Bityutskiy <[email protected]>:

Quoted 17 lines · Huang Shijie
Quoted 10 lines

Not all the NAND devices have all the information in additional id bytes.

So add a hook in the nand_chip{} is a good method to calculate the right value of oobsize, erasesize and so on.

Without the hook,you will get the wrong value, and you have to hack in the ->scan_bbt() to change the wrong value which make the code mess.

Quoted 5 lines

---
 drivers/mtd/nand/nand_base.c |    6 ++++--
 include/linux/mtd/nand.h     |    5 +++++

 2 files changed, 9 insertions(+), 2 deletions(-)
Quoted 7 lines

Taken to l2-mtd-2.6.git, thanks.

--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

From b11a9b99f7775da32a3f4c71a281fac661af6ad4 Mon Sep 17 00:00:00 2001
From: Huang Shijie <[email protected]>
Date: Mon, 27 Sep 2010 10:43:53 +0800
Subject: [PATCH] mtd : add init_size hook for NAND driver

Not all the NAND devices have all the information in additional id bytes.

So add a hook in the nand_chip{} is a good method to calculate the right value of oobsize, erasesize and so on.

Without the hook,you will get the wrong value, and you have to hack in the ->scan_bbt() to change the wrong value which make the code mess.

---
 drivers/mtd/nand/nand_base.c |    6 ++++--
 include/linux/mtd/nand.h     |    6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)
drivers/mtd/nand/nand_base.c +4 -2
index d551ddd..bf31e2c 100644
@@ -2848,8 +2848,10 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
 
 	chip->chipsize = (uint64_t)type->chipsize << 20;
 
-	/* Newer devices have all the information in additional id bytes */
-	if (!type->pagesize) {
+	if (!type->pagesize && chip->init_size) {
+		/* set the pagesize, oobsize, erasesize by the driver*/
+		busw = chip->init_size(mtd, chip, id_data);
+	} else if (!type->pagesize) {
 		int extid;
 		/* The 3rd id byte holds MLC / multichip data */
 		chip->cellinfo = id_data[2];
include/linux/mtd/nand.h +6 -0
index 102e12c..1b39edd 100644
@@ -332,6 +332,10 @@ struct nand_buffers {
  * @block_markbad:	[REPLACEABLE] mark the block bad
  * @cmd_ctrl:		[BOARDSPECIFIC] hardwarespecific funtion for controlling
  *			ALE/CLE/nCE. Also used to write command and address
+ * @init_size:		[BOARDSPECIFIC] hardwarespecific funtion for setting
+ *			mtd->oobsize, mtd->writesize and so on.
+ *			@id_data contains the 8 bytes values of NAND_CMD_READID.
+ *			Return with the bus width.
  * @dev_ready:		[BOARDSPECIFIC] hardwarespecific function for accesing device ready/busy line
  *			If set to NULL no access to ready/busy is available and the ready/busy information
  *			is read from the chip status register
@@ -386,6 +390,8 @@ struct nand_chip {
 	int		(*block_markbad)(struct mtd_info *mtd, loff_t ofs);
 	void		(*cmd_ctrl)(struct mtd_info *mtd, int dat,
 				    unsigned int ctrl);
+	int		(*init_size)(struct mtd_info *mtd,
+					struct nand_chip *this, u8 *id_data);
 	int		(*dev_ready)(struct mtd_info *mtd);
 	void		(*cmdfunc)(struct mtd_info *mtd, unsigned command, int column, int page_addr);
 	int		(*waitfunc)(struct mtd_info *mtd, struct nand_chip *this);
Signature · 1 line
1.6.3.3
#3 lore raw
Quoted 7 lines · Huang Shijie

Hi Artem:
I think the new patch is better.

The new patch will reuse the id_data.
Even if the additional id byte does not have all the information in some case, but other infomation such as manufacture id and device id are also useful to the NAND driver.

OK, pushed this one to l2-mtd-2.6.git, thanks.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)