Skip to contentSkip to conversation

kernel/user.c: add lock release annotation on free_user()

PATCH New Namhyung Kim 1 participant 1 message Sep 27, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/user.c: add lock release annotation on free_user()

free_user() releases uidhash_lock but was missing annotation. Add it. This removes following sparse warnings:

include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit

---
 kernel/user.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/user.c +1 -0
index 7e72614..2c7d8d5 100644
@@ -91,6 +91,7 @@ static struct user_struct *uid_hash_find(uid_t uid, struct hlist_head *hashent)
  * upon function exit.
  */
 static void free_user(struct user_struct *up, unsigned long flags)
+	__releases(&uidhash_lock)
 {
 	uid_hash_remove(up);
 	spin_unlock_irqrestore(&uidhash_lock, flags);
Signature · 1 line
1.7.2.2