Skip to contentSkip to conversation

hwmon (coretemp): Fix build breakage if SMP is undefined

PATCH In review Guenter Roeck 2 participants 5 messages Sep 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 hwmon (coretemp): Fix build breakage if SMP is undefined

Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced a build breakage if CONFIG_SMP is undefined. This commit fixes the problem.

---
v2: Fix compile warning due to unused variable i if SMP is undefined
v3: include asm/smp.h instead of using ifdef CONFIG_SMP

 drivers/hwmon/coretemp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/hwmon/coretemp.c +1 -0
index baa842a..a23b17a 100644
@@ -36,6 +36,7 @@
 #include <linux/pci.h>
 #include <asm/msr.h>
 #include <asm/processor.h>
+#include <asm/smp.h>
 
 #define DRVNAME	"coretemp"
 
Signature · 1 line
1.7.0.87.g0901d
#1 lore raw
Quoted 3 lines · Guenter Roeck

Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced a build breakage if CONFIG_SMP is undefined. This commit fixes the problem.

This commit works around the problem in a hacky but not-so-ugly way.

( You might also want to include Linus's suggestion about how to fix it
for real in the future - so that we have at least some kind of record of it. )

Quoted 2 lines

FYI, while i dont care about my Reported-by's but you lost a Reported-by tag here - you should be as careful about them as about your own signoffs.

Quoted 2 lines

v2: Fix compile warning due to unused variable i if SMP is undefined
v3: include asm/smp.h instead of using ifdef CONFIG_SMP

I've started testing this fix - but i'd expect it to fix the problem - so consider it fixed unless i report back within a few hours that there's some breakage left.

Thanks,

Ingo

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw
Quoted 12 lines · Ingo Molnar
Quoted 4 lines · Ingo Molnar
Quoted 2 lines

v2: Fix compile warning due to unused variable i if SMP is undefined
v3: include asm/smp.h instead of using ifdef CONFIG_SMP

I've started testing this fix [...]

Works fine here.

Great - thanks for your time!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Ingo Molnar
Quoted 7 lines · Ingo Molnar
Quoted 3 lines · Guenter Roeck

Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced a build breakage if CONFIG_SMP is undefined. This commit fixes the problem.

Quoted 6 lines

This commit works around the problem in a hacky but not-so-ugly way.

( You might also want to include Linus's suggestion about how to fix it
for real in the future - so that we have at least some kind of record of it. )

Done.

Quoted 7 lines
Quoted 2 lines

FYI, while i dont care about my Reported-by's but you lost a Reported-by tag here - you should be as careful about them as about your own signoffs.

Added it back in.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors