Skip to contentSkip to conversation

Fix not detecting errors when transferring the last part of the buffer

PATCH In review Luiz Augusto von Dentz 2 participants 2 messages Sep 28, 2010 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 Fix not detecting errors when transferring the last part of the buffer

From: Luiz Augusto von Dentz <[email protected]>

The last part has to be flushed in order to sent the remaining buffer as a obex packet and detect possible errors.

---
 client/transfer.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
client/transfer.c +3 -1
index 58ac265..8ceb36f 100644
@@ -379,8 +379,10 @@ static void put_xfer_progress(GwObexXfer *xfer, gpointer user_data)
 
 		transfer->filled += len;
 
-		if (transfer->filled == 0)
+		if (transfer->filled == 0) {
+			gw_obex_xfer_flush(xfer, &err);
 			goto done;
+		}
 
 		if (gw_obex_xfer_write(xfer, transfer->buffer,
 					transfer->filled,
Signature · 1 line
1.7.1
#1 lore raw

Hi Luiz,

Quoted 7 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

The last part has to be flushed in order to sent the remaining buffer as a obex packet and detect possible errors.

---
 client/transfer.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Thanks. The patch has been pushed upstream.

Johan