Skip to contentSkip to conversation

mac80211: Allow scanning single channel if other VIF is associated.

PATCH In review [email protected] 2 participants 8 messages Sep 28, 2010 – Sep 29, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mac80211: Allow scanning single channel if other VIF is associated.

From: Ben Greear <[email protected]>

This patch aims to decrease channel switching when there is at least one interface associated. This should help multiple station interfaces co-exist on the same hardware, especially in WPA mode.

---

v2 -> v3: Just check can_scan_one flag and if set and there is
a vif associated, select the active channel as scan-channel and let core scanning logic function as designed.

This gets much of the really ugly logic changes out of the scanning core, and any optimizations to this should help general purpose scanning on a single channel as well.

:100644 100644 f0518b0... 7ecf8b0... M include/linux/nl80211.h
:100644 100644 a0613ff... f355b8c... M include/net/cfg80211.h
:100644 100644 8b733cf... 6323954... M net/mac80211/mlme.c
:100644 100644 0b0e83e... 318b2de... M net/mac80211/rx.c
:100644 100644 57b5e66... accd1c3... M net/mac80211/scan.c
:100644 100644 ae344d1... 1bfc1e0... M net/mac80211/work.c
:100644 100644 4ff827e... b45646e... M net/wireless/nl80211.c
:100644 100644 f161b98... 87b0cd7... M net/wireless/sme.c

 include/linux/nl80211.h |    2 +
 include/net/cfg80211.h  |    3 ++
 net/mac80211/mlme.c     |   14 ++++++-----
 net/mac80211/rx.c       |    2 +-
 net/mac80211/scan.c     |   57 +++++++++++++++++++++++++++++++++++++++++++---
 net/mac80211/work.c     |   17 +++++++++-----
 net/wireless/nl80211.c  |    6 +++++
 net/wireless/sme.c      |    5 ++++
 8 files changed, 89 insertions(+), 17 deletions(-)
include/linux/nl80211.h +2 -0
index f0518b0..7ecf8b0 100644
@@ -965,6 +965,8 @@ enum nl80211_attrs {
 	NL80211_ATTR_CONTROL_PORT_ETHERTYPE,
 	NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT,
 
+	NL80211_ATTR_SCAN_ONE_IF_ASSOC,
+
 	/* add attributes here, update the policy in nl80211.c */
 
 	__NL80211_ATTR_AFTER_LAST,
include/net/cfg80211.h +3 -0
index a0613ff..f355b8c 100644
@@ -667,6 +667,8 @@ struct cfg80211_ssid {
  * @wiphy: the wiphy this was for
  * @dev: the interface
  * @aborted: (internal) scan request was notified as aborted
+ * @can_scan_one:  If true, only scan active channel if at least one
+ *       vif is already associated.
  */
 struct cfg80211_scan_request {
 	struct cfg80211_ssid *ssids;
@@ -679,6 +681,7 @@ struct cfg80211_scan_request {
 	struct wiphy *wiphy;
 	struct net_device *dev;
 	bool aborted;
+	bool can_scan_one;
 
 	/* keep last */
 	struct ieee80211_channel *channels[0];
net/mac80211/mlme.c +8 -6
index 8b733cf..6323954 100644
@@ -1863,10 +1863,11 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
 
 		else if (ifmgd->probe_send_count < IEEE80211_MAX_PROBE_TRIES) {
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
-			printk(KERN_DEBUG "No probe response from AP %pM"
-				" after %dms, try %d\n", bssid,
+			printk(KERN_DEBUG "%s: No probe response from AP %pM"
+				" after %dms, try %d  flags: 0x%x\n",
+				sdata->dev->name, bssid,
 				(1000 * IEEE80211_PROBE_WAIT)/HZ,
-				ifmgd->probe_send_count);
+				ifmgd->probe_send_count, ifmgd->flags);
 #endif
 			ieee80211_mgd_probe_ap_send(sdata);
 		} else {
@@ -1876,9 +1877,10 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
 			 */
 			ifmgd->flags &= ~(IEEE80211_STA_CONNECTION_POLL |
 					  IEEE80211_STA_BEACON_POLL);
-			printk(KERN_DEBUG "No probe response from AP %pM"
-				" after %dms, disconnecting.\n",
-				bssid, (1000 * IEEE80211_PROBE_WAIT)/HZ);
+			printk(KERN_DEBUG "%s: No probe response from AP %pM"
+			       " after %dms, disconnecting, flags: 0x%x\n",
+			       sdata->dev->name, bssid,
+			       (1000 * IEEE80211_PROBE_WAIT)/HZ, ifmgd->flags);
 			ieee80211_set_disassoc(sdata, true);
 			mutex_unlock(&ifmgd->mtx);
 			mutex_lock(&local->mtx);
net/mac80211/rx.c +1 -1
index 0b0e83e..318b2de 100644
@@ -2407,7 +2407,7 @@ static void ieee80211_rx_handlers(struct ieee80211_rx_data *rx,
 	do {				\
 		res = rxh(rx);		\
 		if (res != RX_CONTINUE)	\
-			goto rxh_next;  \
+			goto rxh_next;	\
 	} while (0);
 
 	while ((skb = __skb_dequeue(frames))) {
net/mac80211/scan.c +53 -4

86 lines not on this page · raw message

net/mac80211/work.c +11 -6
index ae344d1..1bfc1e0 100644
@@ -910,12 +910,17 @@ static void ieee80211_work_work(struct work_struct *work)
 			 *	 happen to be on the same channel as
 			 *	 the requested channel
 			 */
-			ieee80211_offchannel_stop_beaconing(local);
-			ieee80211_offchannel_stop_station(local);
-
-			local->tmp_channel = wk->chan;
-			local->tmp_channel_type = wk->chan_type;
-			ieee80211_hw_config(local, 0);
+			if (!(wk->chan == local->scan_channel ||
+			      (wk->chan == local->oper_channel &&
+			       !local->scan_channel))) {
+				/* Only change channels if we need to */
+				ieee80211_offchannel_stop_beaconing(local);
+				ieee80211_offchannel_stop_station(local);
+
+				local->tmp_channel = wk->chan;
+				local->tmp_channel_type = wk->chan_type;
+				ieee80211_hw_config(local, 0);
+			}
 			started = true;
 			wk->timeout = jiffies;
 		}
net/wireless/nl80211.c +6 -0
index 4ff827e..b45646e 100644
@@ -138,6 +138,7 @@ static const struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] = {
 	[NL80211_ATTR_CONTROL_PORT] = { .type = NLA_FLAG },
 	[NL80211_ATTR_CONTROL_PORT_ETHERTYPE] = { .type = NLA_U16 },
 	[NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT] = { .type = NLA_FLAG },
+	[NL80211_ATTR_SCAN_ONE_IF_ASSOC] = { .type = NLA_FLAG },
 	[NL80211_ATTR_PRIVACY] = { .type = NLA_FLAG },
 	[NL80211_ATTR_CIPHER_SUITE_GROUP] = { .type = NLA_U32 },
 	[NL80211_ATTR_WPA_VERSIONS] = { .type = NLA_U32 },
@@ -3217,6 +3218,11 @@ static int nl80211_trigger_scan(struct sk_buff *skb, struct genl_info *info)
 		goto out;
 	}
 
+	if (info->attrs[NL80211_ATTR_SCAN_ONE_IF_ASSOC])
+		request->can_scan_one = true;
+	else
+		request->can_scan_one = false;
+
 	if (n_ssids)
 		request->ssids = (void *)&request->channels[n_channels];
 	request->n_ssids = n_ssids;
net/wireless/sme.c +5 -0
index f161b98..87b0cd7 100644
@@ -105,6 +105,11 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
 	if (!request)
 		return -ENOMEM;
 
+	/* If at least one VIF on this hardware is already associated, then
+	 * only scan on the active channel.
+	 */
+	request->can_scan_one = true;
+
 	if (wdev->conn->params.channel)
 		request->channels[0] = wdev->conn->params.channel;
 	else {
Signature · 1 line
1.7.2.2
maintainer
#1 lore raw
Quoted 20 lines · On Tue, 2010-09-28 at 14:17 -0700, [email protected] wrote:

From: Ben Greear <[email protected]>

This patch aims to decrease channel switching when there is at least one interface associated. This should help multiple station interfaces co-exist on the same hardware, especially in WPA mode.

---

v2 -> v3: Just check can_scan_one flag and if set and there is
a vif associated, select the active channel as scan-channel and let core scanning logic function as designed.

This gets much of the really ugly logic changes out of the scanning core, and any optimizations to this should help general purpose scanning on a single channel as well.

include/linux/nl80211.h enum nl80211_attrs { · line 969

Quoted 5 lines
include/linux/nl80211.h +2 -0
@@ -965,6 +965,8 @@ enum nl80211_attrs {
 	NL80211_ATTR_CONTROL_PORT_ETHERTYPE,
 	NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT,
 
+	NL80211_ATTR_SCAN_ONE_IF_ASSOC,
+

Still NACK, I don't see the need for new API for this odd case.

Please don't resubmit similar patches to this, I don't want to nack them all the time.

johannes

author
#2 lore raw
Quoted 9 lines · Johannes Berg

Review

Quoted 2 lines · On Tue, 2010-09-28 at 14:17 -0700, [email protected] wrote:
(quoted diff) +2 -0
+	NL80211_ATTR_SCAN_ONE_IF_ASSOC,
+

Still NACK, I don't see the need for new API for this odd case.

Please don't resubmit similar patches to this, I don't want to nack them all the time.

Ok.

Does this portion seem useful as a stand-alone patch? It does not depend on the other scan-one logic.

net/mac80211/work.c +11 -6
index ae344d1..1bfc1e0 100644
@@ -910,12 +910,17 @@ static void ieee80211_work_work(struct work_struct *work)
 			 *	 happen to be on the same channel as
 			 *	 the requested channel
 			 */
-			ieee80211_offchannel_stop_beaconing(local);
-			ieee80211_offchannel_stop_station(local);
-
-			local->tmp_channel = wk->chan;
-			local->tmp_channel_type = wk->chan_type;
-			ieee80211_hw_config(local, 0);
+			if (!(wk->chan == local->scan_channel ||
+			      (wk->chan == local->oper_channel &&
+			       !local->scan_channel))) {
+				/* Only change channels if we need to */
+				ieee80211_offchannel_stop_beaconing(local);
+				ieee80211_offchannel_stop_station(local);
+
+				local->tmp_channel = wk->chan;
+				local->tmp_channel_type = wk->chan_type;
+				ieee80211_hw_config(local, 0);
+			}
 			started = true;
 			wk->timeout = jiffies;
 		}

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
maintainer
#3 lore raw
Quoted 2 lines · Ben Greear

Does this portion seem useful as a stand-alone patch? It does not depend on the other scan-one logic.

Somewhat, but it seems a bit buggy?

Quoted 6 lines
net/mac80211/work.c +0 -0
index ae344d1..1bfc1e0 100644
@@ -910,12 +910,17 @@ static void ieee80211_work_work(struct work_struct *work)
  			 *	 happen to be on the same channel as

net/mac80211/work.c static void ieee80211_work_work(struct work_struct *work) · line 914

Quoted 10 lines
net/mac80211/work.c +2 -6
  			 *	 the requested channel
  			 */
-			ieee80211_offchannel_stop_beaconing(local);
-			ieee80211_offchannel_stop_station(local);
-
-			local->tmp_channel = wk->chan;
-			local->tmp_channel_type = wk->chan_type;
-			ieee80211_hw_config(local, 0);
+			if (!(wk->chan == local->scan_channel ||
+			      (wk->chan == local->oper_channel &&

I don't think work items will ever run while scanning? And also, this might need to check the channel type as well, which isn't quite necessary right now (since no works requires HT channels) but would seem cleaner.

net/mac80211/work.c static void ieee80211_work_work(struct work_struct *work) · line 925

Quoted 11 lines
net/mac80211/work.c +9 -0
+			       !local->scan_channel))) {
+				/* Only change channels if we need to */
+				ieee80211_offchannel_stop_beaconing(local);
+				ieee80211_offchannel_stop_station(local);
+
+				local->tmp_channel = wk->chan;
+				local->tmp_channel_type = wk->chan_type;
+				ieee80211_hw_config(local, 0);
+			}
  			started = true;
  			wk->timeout = jiffies;

Also, I believe it needs matching code to not do all the return stuff since we never left the channel, and I think it still needs to set tmp_channel so that nothing will switch away underneath or so... not quite sure.

johannes

author
#4 lore raw
Quoted 20 lines · Johannes Berg
Quoted 2 lines · Ben Greear

Does this portion seem useful as a stand-alone patch? It does not depend on the other scan-one logic.

Somewhat, but it seems a bit buggy?

Quoted 13 lines
net/mac80211/work.c +0 -5
index ae344d1..1bfc1e0 100644
@@ -910,12 +910,17 @@ static void ieee80211_work_work(struct work_struct *work)
   			 *	 happen to be on the same channel as
   			 *	 the requested channel
   			 */
-			ieee80211_offchannel_stop_beaconing(local);
-			ieee80211_offchannel_stop_station(local);
-
-			local->tmp_channel = wk->chan;
-			local->tmp_channel_type = wk->chan_type;
Quoted 8 lines

net/mac80211/work.c static void ieee80211_work_work(struct work_struct *work)

Quoted 3 lines
net/mac80211/work.c +2 -1
-			ieee80211_hw_config(local, 0);
+			if (!(wk->chan == local->scan_channel ||
+			      (wk->chan == local->oper_channel&&

I don't think work items will ever run while scanning? And also, this might need to check the channel type as well, which isn't quite necessary right now (since no works requires HT channels) but would seem cleaner.

Just in case work ever does happen when scanning, I think we should leave this check in.

I'll add a check for channel_type being the same as well.

Quoted 8 lines
Quoted 8 lines
net/mac80211/work.c +8 -0
+			       !local->scan_channel))) {
+				/* Only change channels if we need to */
+				ieee80211_offchannel_stop_beaconing(local);
+				ieee80211_offchannel_stop_station(local);
+
+				local->tmp_channel = wk->chan;
+				local->tmp_channel_type = wk->chan_type;
+				ieee80211_hw_config(local, 0);
Quoted 8 lines

net/mac80211/work.c static void ieee80211_work_work(struct work_struct *work) · line 925

Quoted 3 lines
net/mac80211/work.c +1 -0
+			}
   			started = true;
   			wk->timeout = jiffies;

Also, I believe it needs matching code to not do all the return stuff since we never left the channel, and I think it still needs to set tmp_channel so that nothing will switch away underneath or so... not quite sure.

Ok, that sounds good. I'll work on a revised patch when I get a chance.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
maintainer
#5 lore raw
Quoted 10 lines · Ben Greear
Quoted 7 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+			if (!(wk->chan == local->scan_channel ||
+			      (wk->chan == local->oper_channel&&

I don't think work items will ever run while scanning? And also, this might need to check the channel type as well, which isn't quite necessary right now (since no works requires HT channels) but would seem cleaner.

Just in case work ever does happen when scanning, I think we should leave this check in.

I think we'll have bigger problems if that happens, since scanning will switch away from the channel again quickly, likely before the work finishes. I'd rather add an assertion that it _doesn't_ happen, I think.

johannes

author
#6 lore raw
In reply to Johannes Berg
Quoted 8 lines · Johannes Berg
Quoted 8 lines
net/mac80211/work.c +8 -0
+			       !local->scan_channel))) {
+				/* Only change channels if we need to */
+				ieee80211_offchannel_stop_beaconing(local);
+				ieee80211_offchannel_stop_station(local);
+
+				local->tmp_channel = wk->chan;
+				local->tmp_channel_type = wk->chan_type;
+				ieee80211_hw_config(local, 0);
Quoted 8 lines

net/mac80211/work.c static void ieee80211_work_work(struct work_struct *work) · line 925

Quoted 3 lines
net/mac80211/work.c +1 -0
+			}
   			started = true;
   			wk->timeout = jiffies;

Also, I believe it needs matching code to not do all the return stuff since we never left the channel, and I think it still needs to set tmp_channel so that nothing will switch away underneath or so... not quite sure.

Doesn't the remain_off_channel logic later in that method take care of not calling the return to channel logic? (Assuming I set the tmp_channel and tmp_channel_type as you suggest)?

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
maintainer
#7 lore raw
Quoted 8 lines · Ben Greear
Quoted 4 lines

Also, I believe it needs matching code to not do all the return stuff since we never left the channel, and I think it still needs to set tmp_channel so that nothing will switch away underneath or so... not quite sure.

Doesn't the remain_off_channel logic later in that method take care of not calling the return to channel logic? (Assuming I set the tmp_channel and tmp_channel_type as you suggest)?

If you set it, I believe it'll actually do the return work, and if you leave it NULL it won't ... maybe just leaving it NULL is fine, as long as we hope it won't switch away underneath, it probably shouldn't.

johannes