Skip to contentSkip to conversation

cxgb4: remove a bogus PCI function number check

PATCH Applied Dimitris Michailidis 2 participants 2 messages Sep 30, 2010 – Oct 4, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb4: remove a bogus PCI function number check

Remove a bogus PCI function number check from the driver's .remove method that causes pci_release_regions not to be called for function 0 if additional functions are attached and one of them is used as primary.

---
 drivers/net/cxgb4/cxgb4_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/cxgb4/cxgb4_main.c +1 -1
index 4fb08e3..22169a7 100644
@@ -3863,7 +3863,7 @@ static void __devexit remove_one(struct pci_dev *pdev)
 		pci_disable_device(pdev);
 		pci_release_regions(pdev);
 		pci_set_drvdata(pdev, NULL);
-	} else if (PCI_FUNC(pdev->devfn) > 0)
+	} else
 		pci_release_regions(pdev);
 }
 
Signature · 1 line
1.5.4
maintainer Applied
#1 lore raw

From: Dimitris Michailidis <[email protected]>
Date: Thu, 30 Sep 2010 12:17:12 -0700

Quoted 5 lines

Remove a bogus PCI function number check from the driver's .remove method that causes pci_release_regions not to be called for function 0 if additional functions are attached and one of them is used as primary.

Applied, thanks.