Monitor command to translate guest physical address to host virtual address
PATCH 1/1 Monitor command to translate guest physical address to host virtual address
From: Max Asbock <[email protected]>
Add command p2v to translate guest physical address to host virtual address.
The p2v command provides one step in a chain of translations from guest virtual to guest physical to host virtual to host physical. Host physical is then used to inject a machine check error. As a consequence the HWPOISON code on the host and the MCE injection code in qemu-kvm are exercised.
--- monitor.c | 11 +++++++++++ qemu-monitor.hx | 13 +++++++++++++ 2 files changed, 24 insertions(+)
monitor.c +11 -0
@@ -2301,6 +2301,17 @@ static void do_inject_mce(Monitor *mon, }#endif +static void do_p2v (Monitor *mon,const QDict *qdict) +{ +target_phys_addr_t size =TARGET_PAGE_SIZE ; +target_phys_addr_t addr =qdict_get_int (qdict,"addr" ); +void *vaddr; + + vaddr =cpu_physical_memory_map (addr, &size,0 ); +monitor_printf (mon,"Guest physical address %p is mapped at " +"host virtual address %p\n" , (void *)addr, vaddr); +} +static int do_getfd (Monitor *mon,const QDict *qdict,QObject **ret_data) {const char *fdname =qdict_get_str (qdict,"fdname" );
qemu-monitor.hx +13 -0
@@ -459,6 +459,19 @@ Start gdbserver session (default @var{po ETEXI { + .name = "p2v", + .args_type = "fmt:/,addr:l", + .params = "/fmt addr", + .help = "translate guest physical 'addr' to host virtual address", + .mhandler.cmd = do_p2v, + }, +STEXI +@item p2v @var{addr} +@findex mce +Translate guest physical @var{addr} to host virtual address. +ETEXI + + { .name = "x", .args_type = "fmt:/,addr:l", .params = "/fmt addr",
Quoted 11 lines · Huang Ying
From: Max Asbock <[email protected]>
Add command p2v to translate guest physical address to host virtual address.
The p2v command provides one step in a chain of translations from guest virtual to guest physical to host virtual to host physical. Host physical is then used to inject a machine check error. As a consequence the HWPOISON code on the host and the MCE injection code in qemu-kvm are exercised.
Quoted 3 lines
Signed-off-by Max Asbock <[email protected]>Signed-off-by Jiajia Zheng <[email protected]>Signed-off-by Huang Ying <[email protected]>
Added missing cpu_physical_memory_unmap and applied, thanks.
Quoted 12 lines · Marcelo Tosatti
Quoted 11 lines · Huang Ying
From: Max Asbock<[email protected]>
Add command p2v to translate guest physical address to host virtual address.
The p2v command provides one step in a chain of translations from guest virtual to guest physical to host virtual to host physical. Host physical is then used to inject a machine check error. As a consequence the HWPOISON code on the host and the MCE injection code in qemu-kvm are exercised.
Quoted 6 lines
Quoted 3 lines
Signed-off-by Max Asbock<[email protected]>Signed-off-by Jiajia Zheng<[email protected]>Signed-off-by Huang Ying<[email protected]>Added missing
cpu_physical_memory_unmapand applied, thanks.
This should have been copied to qemu-devel so that the monitor people can review it.
Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
Quoted 14 lines · Avi Kivity
Quoted 13 lines · Marcelo Tosatti
Quoted 7 lines · Huang Ying
From: Max Asbock<[email protected]>
Add command p2v to translate guest physical address to host virtual address.
The p2v command provides one step in a chain of translations from guest virtual to guest physical to host virtual to host physical.
Host
Quoted 4 lines
physical is then used to inject a machine check error. As a consequence the HWPOISON code on the host and the MCE injection code in qemu-kvm are exercised.
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Signed-off-by Max Asbock<[email protected]>Signed-off-by Jiajia Zheng<[email protected]>Signed-off-by Huang Ying<[email protected]>Added missing
cpu_physical_memory_unmapand applied, thanks.This should have been copied to qemu-devel so that the monitor people can review it.
It also breaks the build:
Quoted 7 lines
I CC
x86_64-softmmu/monitor.o
cc1: warnings being treated as errors/var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c: In function 'do_p2v':/var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c:2312: error: cast to pointer from integer of different size make[1]: *** [monitor.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
I've reverted it for now. Please resubmit to qemu upstream ([email protected]). I also suggest coming up with a better name for the command, and QMP support.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 11 lines · Avi Kivity
Quoted 8 lines
I CC
x86_64-softmmu/monitor.o
cc1: warnings being treated as errors/var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c: In function 'do_p2v':/var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c:2312: error: cast to pointer from integer of different size make[1]: *** [monitor.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2I've reverted it for now. Please resubmit to qemu upstream ([email protected]). I also suggest coming up with a better name for the command, and QMP support.
Another thing to consider is making it work on ranges, not pages. This can be used with page migration for rebinding guest numa nodes to host numa nodes.
Signature · 1 line
error compiling committee.c: too many arguments to function