Skip to contentSkip to conversation

jffs2: use cond_resched() instead of yield()

PATCH Applied [email protected] 2 participants 3 messages Oct 1, 2010 – Oct 2, 2010

Subsystems (2)
Memory technology devices (MTD) Journalling flash file system V2 (JFFS2)
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 2/2 jffs2: use cond_resched() instead of yield()

From: Wolfram Sang <[email protected]>

yield() has different semantics meanwhile and even causes RT-kernels to BUG. Replace the only appearance left in jffs2.

Signed-off-by Wolfram Sang <[email protected]>
Cc Artem Bityutskiy <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Artem Bityutskiy <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 fs/jffs2/erase.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jffs2/erase.c renamed from fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield +1 -1
diff -puN fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield fs/jffs2/erase.c
@@ -151,7 +151,7 @@ int jffs2_erase_pending_blocks(struct jf
 		}
 
 		/* Be nice */
-		yield();
+		cond_resched();
 		mutex_lock(&c->erase_free_sem);
 		spin_lock(&c->erase_completion_lock);
 	}

_

#1 lore raw
Quoted 5 lines · On Fri, 2010-10-01 at 14:16 -0700, [email protected] wrote:

From: Wolfram Sang <[email protected]>

yield() has different semantics meanwhile and even causes RT-kernels to BUG. Replace the only appearance left in jffs2.

This patch is also in my l2-mtd-2.6.git tree.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
author
#2 lore raw
Quoted 8 lines · On Sat, 02 Oct 2010 17:07:55 +0300 Artem Bityutskiy <[email protected]> wrote:
Quoted 5 lines · On Fri, 2010-10-01 at 14:16 -0700, [email protected] wrote:

From: Wolfram Sang <[email protected]>

yield() has different semantics meanwhile and even causes RT-kernels to BUG. Replace the only appearance left in jffs2.

This patch is also in my l2-mtd-2.6.git tree.

And I'll keep sending it and you'll keep telling me it's in your tree until this situation gets fixed.