ASoC: WM8804: Initial driver
Subsystems (3)
PATCH 1/1 ASoC: WM8804: Initial driver
The WM8804 is a high performance consumer mode S/PDIF transceiver with support for 1 received channel and 1 transmitted channel.
--- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wm8804.c | 820 +++++++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/wm8804.h | 61 ++++ 4 files changed, 887 insertions(+), 0 deletions(-) create mode 100644 sound/soc/codecs/wm8804.c create mode 100644 sound/soc/codecs/wm8804.h
sound/soc/codecs/Kconfig +4 -0
@@ -56,6 +56,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_WM8750 if SND_SOC_I2C_AND_SPI select SND_SOC_WM8753 if SND_SOC_I2C_AND_SPI select SND_SOC_WM8776 if SND_SOC_I2C_AND_SPI + select SND_SOC_WM8804 if SND_SOC_I2C_AND_SPI select SND_SOC_WM8900 if I2C select SND_SOC_WM8903 if I2C select SND_SOC_WM8904 if I2C
@@ -237,6 +238,9 @@ config SND_SOC_WM8753 config SND_SOC_WM8776 tristate +config SND_SOC_WM8804 + tristate + config SND_SOC_WM8900 tristate
sound/soc/codecs/Makefile +2 -0
@@ -41,6 +41,7 @@ snd-soc-wm8741-objs := wm8741.o snd-soc-wm8750-objs := wm8750.o snd-soc-wm8753-objs := wm8753.o snd-soc-wm8776-objs := wm8776.o +snd-soc-wm8804-objs := wm8804.o snd-soc-wm8900-objs := wm8900.o snd-soc-wm8903-objs := wm8903.o snd-soc-wm8904-objs := wm8904.o
@@ -114,6 +115,7 @@ obj-$(CONFIG_SND_SOC_WM8741) += snd-soc-wm8741.o obj-$(CONFIG_SND_SOC_WM8750) += snd-soc-wm8750.o obj-$(CONFIG_SND_SOC_WM8753) += snd-soc-wm8753.o obj-$(CONFIG_SND_SOC_WM8776) += snd-soc-wm8776.o +obj-$(CONFIG_SND_SOC_WM8804) += snd-soc-wm8804.o obj-$(CONFIG_SND_SOC_WM8900) += snd-soc-wm8900.o obj-$(CONFIG_SND_SOC_WM8903) += snd-soc-wm8903.o obj-$(CONFIG_SND_SOC_WM8904) += snd-soc-wm8904.o
sound/soc/codecs/wm8804.c new file +820 -0
820 lines not on this page · raw message
sound/soc/codecs/wm8804.h new file +61 -0
61 lines not on this page · raw message
Signature · 1 line
1.7.3
Quoted 5 lines · Dimitris Papastamos
The WM8804 is a high performance consumer mode S/PDIF transceiver with support for 1 received channel and 1 transmitted channel.
Signed-off-by Dimitris Papastamos <[email protected]>
Quoted 9 lines
--- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wm8804.c | 820 +++++++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/wm8804.h | 61 ++++ 4 files changed, 887 insertions(+), 0 deletions(-) create mode 100644 sound/soc/codecs/wm8804.c create mode 100644 sound/soc/codecs/wm8804.h
but
sound/soc/codecs/wm8804.c line 672
Quoted 3 lines
sound/soc/codecs/wm8804.c new file +3
-0+ +static struct snd_soc_dai_driver wm8804_dai = { + .name ="wm8804-s/pdif" ,
There may be per DAI debugfs or sysfs info in the future so it's best to not use a "/" in a name. Can you do an incremental change.
Thanks
Liam
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Mark Brown
AppliedQuoted 5 lines · Dimitris Papastamos
The WM8804 is a high performance consumer mode S/PDIF transceiver with support for 1 received channel and 1 transmitted channel.
Signed-off-by Dimitris Papastamos <[email protected]>
Applied, thanks but...
sound/soc/codecs/wm8804.c line 395
Quoted 7 lines
sound/soc/codecs/wm8804.c new file +7
-0+static int wm8804_set_pll (struct snd_soc_dai *dai,int pll_id, +int source,unsigned int freq_in, +unsigned int freq_out) +{ +int ret; +struct snd_soc_codec *codec; +struct pll_div pll_div = {0 };
...please provide an incremental patch which fixes this to not override all the flow control testing as discussed for your other patch.
Quoted 7 lines · Dimitris Papastamos
The WM8804 is a high performance consumer mode S/PDIF transceiver with support for 1 received channel and 1 transmitted channel.
Signed-off-by Dimitris Papastamos <[email protected]>---
Hi,
how could I test your driver? I have patched the alsa 1.0.23 but had compilation errors. There is e.g. no 'snd_soc_codec_driver' in *.h files and 'snd_soc_codec' structure does not have the 'driver' member. I've also tried to use the newest tarball of alsa-driver (alsa-driver-1.0.23.75.g04a15.554.g80f5d) but had the same result.
best regards,
Grzegorz
Quoted 8 lines · Grzegorz Daniluk
Quoted 7 lines · Dimitris Papastamos
The WM8804 is a high performance consumer mode S/PDIF transceiver with support for 1 received channel and 1 transmitted channel.
Signed-off-by Dimitris Papastamos <[email protected]>---
Quoted 6 lines
Hi,
how could I test your driver? I have patched the alsa 1.0.23 but had compilation errors. There is e.g. no 'snd_soc_codec_driver' in *.h files and 'snd_soc_codec' structure does not have the 'driver' member. I've also tried to use the newest tarball of alsa-driver (alsa-driver-1.0.23.75.g04a15.554.g80f5d) but had the same result.
The WM8804 I've posted on this list has been developed against this tree
http://git.kernel.org/?p=linux/kernel/git/broonie/sound-2.6.git;a=tree;h=refs/heads/for-2.6.37;hb=for-2.6.37
I've also backported the WM8804 for older kernels. You can get that driver from here
http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi?p=linux-2.6-asoc.git;a=summary
Thanks,
Dimitrios