Skip to contentSkip to conversation

ARMV7: OMAP3: Fix bug in get_sdr_cs_offset()

U-Boot Steve Sakoman 2 participants 2 messages Oct 5, 2010 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

ARMV7: OMAP3: Fix bug in get_sdr_cs_offset()

This patch fixes a typo in the routine to calculate the cs offset based upon the contents of the SDRC cs_cfg register. This function mistakenly shifts the CS1STARTLOW field 17 bits right instead of 17 bits left.

This hasn't been an issue to date because all OMAP3 boards currently are configured to have zeros in this field.

---

arch/arm/cpu/armv7/omap3/sdrc.c +1 -1
index 2719bb5..6c419f5 100644
@@ -99,7 +99,7 @@ u32 get_sdr_cs_offset(u32 cs)
 		return 0;
 
 	offset = readl(&sdrc_base->cs_cfg);
-	offset = (offset & 15) << 27 | (offset & 0x30) >> 17;
+	offset = (offset & 15) << 27 | (offset & 0x30) << 17;
 
 	return offset;
 }
#1 lore raw
Quoted 1 line · Steve Sakoman

ARMV7: OMAP3: Fix bug in get_sdr_cs_offset()

Sorry! Sent this one out again by mistake. You can ignore.

Steve