SLUB: Fix memory hotplug with !NUMA
Subsystems (2)
PATCH 1/1 SLUB: Fix memory hotplug with !NUMA
This patch fixes the following build breakage when memory hotplug is enabled on UMA configurations:
/home/test/linux-2.6/mm/slub.c: In function 'kmem_cache_init':
/home/test/linux-2.6/mm/slub.c:3031:2: error: 'slab_memory_callback' undeclared (first use in this function) /home/test/linux-2.6/mm/slub.c:3031:2: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [mm/slub.o] Error 1
make[1]: *** [mm] Error 2
make: *** [sub-make] Error 2
--- mm/slub.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/slub.c +1 -1
@@ -2851,7 +2851,7 @@ int kmem_cache_shrink(struct kmem_cache *s) }EXPORT_SYMBOL (kmem_cache_shrink); -#if defined(CONFIG_NUMA ) && defined(CONFIG_MEMORY_HOTPLUG ) +#if defined(CONFIG_MEMORY_HOTPLUG )static int slab_mem_going_offline_callback (void *arg) {struct kmem_cache *s;
Signature · 1 line
1.6.3.3
Quoted 2 lines · Pekka Enberg
This patch fixes the following build breakage when memory hotplug is enabled on UMA configurations:
Hum? That works?
Quoted 6 lines
mm/slub.c +0
-0
mm/slub.c int kmem_cache_shrink(struct kmem_cache *s) · line 2857
Quoted 8 lines
mm/slub.c +1
-1@@ -2851,7 +2851,7 @@ int kmem_cache_shrink(struct kmem_cache *s) }EXPORT_SYMBOL (kmem_cache_shrink); -#if defined(CONFIG_NUMA ) && defined(CONFIG_MEMORY_HOTPLUG ) +#if defined(CONFIG_MEMORY_HOTPLUG )static int slab_mem_going_offline_callback (void *arg) {struct kmem_cache *s;
Re: [PATCH] SLUB: Fix memory hotplug with !NUMA [OT[
In reply to Pekka EnbergQuoted 1 line · Pekka Enberg <penberg <at> kernel.org> writes:
Reported-by Zimny Lech <napohybelskurwysynom2010 <at> gmail.com>
Sorry for those not familiar with Polish language :
- the email address username contains explicit content by Polish language standards (rough translation : kill the f**kers [or m-f])
- the name and surname is not likely to be real, it looks like nickname to me (background : Zimny means cold; yes it may be also used as surname; Lech may be a first name, but is also a name of a brand of beer made in Poland - together the phrase 'Zimny Lech' I have seen used in a TV advertisement for that brewery and its other (billboards etc) media. )
Just FYI.
Lukasz
Re: [PATCH] SLUB: Fix memory hotplug with !NUMA [OT[
(Please don't trim the CC lists.)
Quoted 7 lines · el es
Quoted 1 line · Pekka Enberg <penberg <at> kernel.org> writes:
Reported-by Zimny Lech <napohybelskurwysynom2010 <at> gmail.com>Sorry for those not familiar with Polish language :
- the email address username contains explicit content by Polish language standards (rough translation : kill the f**kers [or m-f])
Heh.
Quoted 7 lines
- the name and surname is not likely to be real, it looks like nickname to me (background : Zimny means cold; yes it may be also used as surname; Lech may be a first name, but is also a name of a brand of beer made in Poland - together the phrase 'Zimny Lech' I have seen used in a TV advertisement for that brewery and its other (billboards etc) media. )
Just FYI.
Well, as long as it's a valid e-mail address and it's not a sign-off, I don't really mind. If people don't want credit for their work (like reporting bugs or testing patches), it's their choice.
Pekka