IPC: Initialize structure memory to zero for compat functions
PATCH v2 1/1 IPC: Initialize structure memory to zero for compat functions
Please ignore the previous patch, no sense in splitting these up.
This takes care of leaking uninitialized kernel stack memory to userspace from non-zeroed fields in structs in compat ipc functions.
Signed-off-by Dan Rosenberg <[email protected]>
ipc/compat.c +2 -2
@@ -237,7 +237,7 @@ long compat_sys_semctl(int first, int seunion semun fourth;u32 pad;int err, err2; -struct semid64_ds s64; +struct semid64_ds s64 = {};struct semid64_ds __user *up64;int version =compat_ipc_parse_version (&third);
@@ -417,7 +417,7 @@ static inline int put_compat_msqid_ds(stlong compat_sys_msgctl (int first,int second,void __user *uptr) {int err, err2; -struct msqid64_ds m64; +struct msqid64_ds m64 = {};int version =compat_ipc_parse_version (&second);void __user *p;
ipc/compat_mq.c +2 -2
@@ -52,7 +52,7 @@ asmlinkage long compat_sys_mq_open(const {void __user *p =NULL ;if (u_attr && oflag &O_CREAT ) { -struct mq_attr attr; +struct mq_attr attr = {}; p =compat_alloc_user_space (sizeof (attr));if (get_compat_mq_attr (&attr, u_attr) ||copy_to_user (p, &attr,sizeof (attr)))
@@ -123,7 +123,7 @@ asmlinkage long compat_sys_mq_getsetattrconst struct compat_mq_attr __user *u_mqstat, struct compat_mq_attr __user *u_omqstat) { - struct mq_attr mqstat; + struct mq_attr mqstat = {};struct mq_attr __user *p =compat_alloc_user_space (2 *sizeof (*p));long ret;