Skip to contentSkip to conversation

Staging: speakup: Makefile: Makefile clean up

PATCH New Tracey Dent 1 participant 3 messages Oct 8, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Staging: speakup: Makefile: Makefile clean up

Replaced <modules>-objs with <modules>-y in Makefile.

---
 drivers/staging/speakup/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/speakup/Makefile +1 -1
index 9923463..c5e43a5 100644
@@ -15,7 +15,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += speakup_txprt.o
 obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
 
 obj-$(CONFIG_SPEAKUP) += speakup.o
-speakup-objs := \
+speakup-y := \
 	buffers.o \
 	devsynth.o \
 	i18n.o \
Signature · 1 line
1.7.3.1.104.gc752e
#1 lore raw

PATCH 2/3 Staging: speakup: devsynth: file_operations should be const

Fixed file_operation struct, so that it is const.

---
 drivers/staging/speakup/devsynth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/speakup/devsynth.c +1 -1
index a465653..8b74622 100644
@@ -56,7 +56,7 @@ static int speakup_file_release(struct inode *ip, struct file *fp)
 	return 0;
 }
 
-static struct file_operations synth_fops = {
+static const struct file_operations synth_fops = {
 	.read = speakup_file_read,
 	.write = speakup_file_write,
 	.open = speakup_file_open,
Signature · 1 line
1.7.3.1.104.gc752e
#2 lore raw

PATCH 3/3 Staging: speakup: keyhelp: Coding style fix

In reply to Tracey Dent

Put { on previous line, on line 34. Checkpatch.pl caught this.

---
 drivers/staging/speakup/keyhelp.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/speakup/keyhelp.c +5 -5
index 81c627c..a74500a 100644
@@ -30,11 +30,11 @@ static const int num_key_names = MSG_KEYNAMES_END - MSG_KEYNAMES_START + 1;
 static u_short key_offsets[MAXFUNCS], key_data[MAXKEYS];
 static u_short masks[] = { 32, 16, 8, 4, 2, 1 };
 
-static short letter_offsets[26] =
-{ -1, -1, -1, -1, -1, -1, -1, -1,
-  -1, -1, -1, -1, -1, -1, -1, -1,
-  -1, -1, -1, -1, -1, -1, -1, -1,
-  -1, -1 };
+static short letter_offsets[26] = { 
+	-1, -1, -1, -1, -1, -1, -1, -1,
+	-1, -1, -1, -1, -1, -1, -1, -1,
+	-1, -1, -1, -1, -1, -1, -1, -1,
+	-1, -1 };
 
 static u_char funcvals[] = {
 	ATTRIB_BLEEP_DEC, ATTRIB_BLEEP_INC, BLEEPS_DEC, BLEEPS_INC,
Signature · 1 line
1.7.3.1.104.gc752e