serial: omap-serial: fix signess error
PATCH 1/1 serial: omap-serial: fix signess error
"ret" is unsigned, so check for (ret < 0) made no sense. Made it signed.
---
I cannot compile this driver, so it is not tested.
drivers/serial/omap-serial.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/omap-serial.c +1 -1
@@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no) {struct uart_omap_port *up = ui[uart_no];unsigned int curr_dma_pos, curr_transmitted_size; -unsigned int ret =0 ; +int ret =0 ; curr_dma_pos =omap_get_dma_dst_pos (up->uart_dma.rx_dma_channel); if ((curr_dma_pos = up->uart_dma.prev_rx_dma_pos) ||
Signature · 1 line
1.7.0.4
Quoted 9 lines · Vasiliy Kulikov
"ret" is unsigned, so check for (ret < 0) made no sense. Made it signed.
Signed-off-by Vasiliy Kulikov <[email protected]>---
I cannot compile this driver, so it is not tested.drivers/serial/omap-serial.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
This seems to be in the omap tree, and not in my tree, so you will need to push this through the omap maintainers.
thanks,
greg k-h
[adding linux-omap list]
Quoted 6 lines · Vasiliy Kulikov
"ret" is unsigned, so check for (ret < 0) made no sense. Made it signed.
Signed-off-by Vasiliy Kulikov <[email protected]>---
I cannot compile this driver, so it is not tested.
Since the original driver is being queued via the omap tree, we can queue this one as well.
Tony, can you add this one to the 2.6.37 queue?
Thanks,
Kevin
Quoted 16 lines
drivers/serial/omap-serial.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/serial/omap-serial.c +1
-1@@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no) {struct uart_omap_port *up = ui[uart_no];unsigned int curr_dma_pos, curr_transmitted_size; -unsigned int ret =0 ; +int ret =0 ; curr_dma_pos =omap_get_dma_dst_pos (up->uart_dma.rx_dma_channel); if ((curr_dma_pos = up->uart_dma.prev_rx_dma_pos) ||
Quoted 11 lines · Kevin Hilman
[adding linux-omap list]
Quoted 6 lines · Vasiliy Kulikov
"ret" is unsigned, so check for (ret < 0) made no sense. Made it signed.
Signed-off-by Vasiliy Kulikov <[email protected]>---
I cannot compile this driver, so it is not tested.
Quoted 6 lines
Acked-by Kevin Hilman <[email protected]>Since the original driver is being queued via the omap tree, we can queue this one as well.
Tony, can you add this one to the 2.6.37 queue?
Thanks, adding into omap-for-linus.
Regards,
Tony