staging: octeon: Add Lanai board USB clock type
PATCH 1/1 staging: octeon: Add Lanai board USB clock type
Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/octeon/cvmx-helper-board.c +1 -0
@@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void) {switch (cvmx_sysinfo_get ()->board_type) {case CVMX_BOARD_TYPE_BBGW_REF : +case CVMX_BOARD_TYPE_LANAI2_G :return USB_CLOCK_TYPE_CRYSTAL_12 ; }return USB_CLOCK_TYPE_REF_48 ;
Signature · 1 line
1.7.1
David Daney
NAKQuoted 7 lines · Bernhard Walle
Add the LANAI2 board to
__cvmx_helper_board_usb_get_clock_type(). It also uses theUSB_CLOCK_TYPE_CRYSTAL_12clock.Signed-off-by Bernhard Walle<[email protected]>--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
NAK.
We don't currently support USB, so churning up this file doesn't help anything.
If you are using an out-of-tree driver, you can keep this kind of tweak out-of-tree as well.
David Daney
Quoted 13 lines
drivers/staging/octeon/cvmx-helper-board.c +1
-0@@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void) {switch (cvmx_sysinfo_get ()->board_type) {case CVMX_BOARD_TYPE_BBGW_REF : +case CVMX_BOARD_TYPE_LANAI2_G :return USB_CLOCK_TYPE_CRYSTAL_12 ; }return USB_CLOCK_TYPE_REF_48 ;
Am 11.10.2010 18:53, schrieb David Daney:
Quoted 9 lines · Bernhard Walle
Quoted 7 lines
Add the LANAI2 board to
__cvmx_helper_board_usb_get_clock_type(). It also uses theUSB_CLOCK_TYPE_CRYSTAL_12clock.Signed-off-by Bernhard Walle<[email protected]>--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 4 lines
NAK.
We don't currently support USB, so churning up this file doesn't help anything.
Well, agreed, but why not removing that code entirely then?
Regards,
Bernhard
Quoted 10 lines · Bernhard Walle
Am 11.10.2010 18:53, schrieb David Daney:
Quoted 9 lines · Bernhard Walle
Quoted 7 lines
Add the LANAI2 board to
__cvmx_helper_board_usb_get_clock_type(). It also uses theUSB_CLOCK_TYPE_CRYSTAL_12clock.Signed-off-by Bernhard Walle<[email protected]>--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 7 lines
Quoted 4 lines
NAK.
We don't currently support USB, so churning up this file doesn't help anything.
Well, agreed, but why not removing that code entirely then?
That is the eventual plan.
David Daney
Quoted 13 lines · David Daney
Quoted 12 lines · Bernhard Walle
Am 11.10.2010 18:53, schrieb David Daney:
Quoted 11 lines · Bernhard Walle
Quoted 7 lines
Add the LANAI2 board to
__cvmx_helper_board_usb_get_clock_type(). It also uses theUSB_CLOCK_TYPE_CRYSTAL_12clock.Signed-off-by Bernhard Walle<[email protected]>--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)NAK.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
We don't currently support USB, so churning up this file doesn't help anything.
Well, agreed, but why not removing that code entirely then?
That is the eventual plan.
Why not do that now?
Or add USB support to the driver, but don't leave it in the in-kernel driver and expect users to know that this is something they shouldn't be doing.
Also, why aren't you going to support the USB devices? What's wrong with that?
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 16 lines · David Daney
Quoted 15 lines · Bernhard Walle
Am 11.10.2010 18:53, schrieb David Daney:
Quoted 13 lines · Bernhard Walle
Quoted 7 lines
Add the LANAI2 board to
__cvmx_helper_board_usb_get_clock_type(). It also uses theUSB_CLOCK_TYPE_CRYSTAL_12clock.Signed-off-by Bernhard Walle<[email protected]>--- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)NAK.
We don't currently support USB, so churning up this file doesn't help anything.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Well, agreed, but why not removing that code entirely then?
That is the eventual plan.
Why not do that now?
If others want do submit patches that do that, I would not object. It is not currently my highest priority, so it may be a little while before I would get to it.
Quoted 5 lines
Or add USB support to the driver, but don't leave it in the in-kernel driver and expect users to know that this is something they shouldn't be doing.
Also, why aren't you going to support the USB devices?
I'm not sure where you got that idea. What I said was "We don't currently support USB...", this doesn't mean that we wouldn't like to eventually have support for it merged.
Quoted 1 line
What's wrong with that?
Nothing. You may recall that people are working on getting the driver merged:
http://marc.info/?l=linux-usb&m=128648942928513
The path of least resistance is to let that patch get merged first, and then submit the necessary glue to hook it up to OCTEON parts that support it.
David Daney
Am 12.10.2010 18:56, schrieb David Daney:
Quoted 11 lines · Greg KH
Quoted 6 lines · David Daney
Quoted 2 lines
That is the eventual plan.
Why not do that now?
If others want do submit patches that do that, I would not object. It is not currently my highest priority, so it may be a little while before I would get to it.
I sent a patch now that does this.
Regards,
Bernhard
Quoted 6 lines · Bernhard Walle
Am 12.10.2010 18:56, schrieb David Daney:
Quoted 5 lines · Greg KH
Quoted 4 lines · David Daney
Quoted 2 lines
That is the eventual plan.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Why not do that now?
If others want do submit patches that do that, I would not object. It is not currently my highest priority, so it may be a little while before I would get to it.
I sent a patch now that does this.
Great, I'll queue it up, thanks.
greg k-h