Skip to contentSkip to conversation

drm/i915: restore FDI link rate on sandybridge

PATCH In review Zhenyu Wang 3 participants 5 messages Oct 13, 2010 – Oct 14, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: restore FDI link rate on sandybridge

FDI_PLL_BIOS_0 register is for Ironlake only, don't apply to Sandybridge.

---
 drivers/gpu/drm/i915/intel_display.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +4 -1
index 8e98d70..b711e98 100644
@@ -3709,7 +3709,10 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 			 * Hence the bw of each lane in terms of the mode signal
 			 * is:
 			 */
-			link_bw = intel_fdi_link_freq(dev) * MHz(100)/KHz(1)/10;
+			if (IS_GEN5(dev))
+				link_bw = intel_fdi_link_freq(dev) * MHz(100)/KHz(1)/10;
+			else
+				link_bw = 270000;
 		}
 
 		/* determine panel color depth */
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 2/2 drm/i915: Fix GPIO pin to register mapping

In i2c GPIO fallback, index 6 is reserved for nothing.

---
 drivers/gpu/drm/i915/intel_i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_i2c.c +1 -0
index 2449a74..2be4f72 100644
@@ -155,6 +155,7 @@ intel_gpio_create(struct drm_i915_private *dev_priv, u32 pin)
 		GPIOC,
 		GPIOD,
 		GPIOE,
+		0,
 		GPIOF,
 	};
 	struct intel_gpio *gpio;
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Zhenyu Wang
Quoted 13 lines · On Wed, 13 Oct 2010 16:40:11 +0800 Zhenyu Wang <[email protected]> wrote:

FDI_PLL_BIOS_0 register is for Ironlake only, don't apply to Sandybridge.

---
 drivers/gpu/drm/i915/intel_display.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 8e98d70..b711e98 100644
@@ -3709,7 +3709,10 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 			 * Hence the bw of each lane in terms of the mode signal

drivers/gpu/drm/i915/intel_display.c static int intel_crtc_mode_set(struct drm_crtc *crtc, · line 3718

Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +4 -1
 			 * is:
 			 */
-			link_bw = intel_fdi_link_freq(dev) * MHz(100)/KHz(1)/10;
+			if (IS_GEN5(dev))
+				link_bw = intel_fdi_link_freq(dev) * MHz(100)/KHz(1)/10;
+			else
+				link_bw = 270000;
 		}
 
 		/* determine panel color depth */

So this gets the display working again with current bits?

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#3 lore raw
Quoted 4 lines · Jesse Barnes
Quoted 1 line · On Wed, 13 Oct 2010 16:40:11 +0800 Zhenyu Wang <[email protected]> wrote:

FDI_PLL_BIOS_0 register is for Ironlake only, don't apply to Sandybridge.

The VPN ate the response that I've applied both of these, with a tweak to this patch to move the if into the inline function.

Quoted 1 line

So this gets the display working again with current bits?

Good question.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#4 lore raw
In reply to Jesse Barnes
Quoted 3 lines · Jesse Barnes

So this gets the display working again with current bits?

No, these two are the fixes coming out during my bisect, as it looks we have multiple regression commits...

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx