Skip to contentSkip to conversation

Acme Systems FOX Board G20 board files

PATCH In review Sergio Tanzilli 3 participants 4 messages Oct 14, 2010 – Nov 24, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Acme Systems FOX Board G20 board files

---
 arch/arm/mach-at91/Kconfig        |    7 +
 arch/arm/mach-at91/Makefile       |    2 +
 arch/arm/mach-at91/board-foxg20.c |  279 +++++++++++++++++++++++++++++++++++++
 3 files changed, 288 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-at91/board-foxg20.c
arch/arm/mach-at91/Kconfig +7 -0
index 939bccd..35def97 100644
@@ -364,6 +364,13 @@ config MACH_STAMP9G20
 	  evaluation board.
 	  <http://www.taskit.de/en/>
 
+config MACH_FOXG20
+	bool "Acme Systems srl FOX Board G20"
+	depends on ARCH_AT91SAM9G20
+	help
+	  Select this if you are using Acme Systems
+	  FOX Board G20 <http://www.acmesystems.it>
+
 endif
 
 if (ARCH_AT91SAM9260 || ARCH_AT91SAM9G20)
arch/arm/mach-at91/Makefile +2 -0
index ca2ac00..686bc6d 100644
@@ -65,6 +65,8 @@ obj-$(CONFIG_MACH_AT91SAM9G20EK_2MMC) += board-sam9g20ek-2slot-mmc.o
 obj-$(CONFIG_MACH_CPU9G20)	+= board-cpu9krea.o
 obj-$(CONFIG_MACH_STAMP9G20)	+= board-stamp9g20.o
 obj-$(CONFIG_MACH_PORTUXG20)	+= board-stamp9g20.o
+obj-$(CONFIG_MACH_FOXG20)	+= board-foxg20.o
+
 
 # AT91SAM9260/AT91SAM9G20 board-specific support
 obj-$(CONFIG_MACH_SNAPPER_9260)	+= board-snapper9260.o
arch/arm/mach-at91/board-foxg20.c new file +279 -0

279 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 35 lines
arch/arm/mach-at91/board-foxg20.c new file +34 -0
@@ -0,0 +1,279 @@
+/*
+ *  Copyright (C) 2005 SAN People
+ *  Copyright (C) 2008 Atmel
+ *  Copyright (C) 2010 Lee McLoughlin - lee at lmmrtech.com
+ *  Copyright (C) 2010 Sergio Tanzilli - tanzilli at acmesystems.it
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#include <linux/types.h>
+#include <linux/init.h>
+#include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/at73c213.h>
+#include <linux/gpio_keys.h>
+#include <linux/input.h>
+#include <linux/clk.h>
+#include <linux/w1-gpio.h>
+
+#include <mach/hardware.h>

arch/arm/mach-at91/board-foxg20.c line 44

Quoted 10 lines
arch/arm/mach-at91/board-foxg20.c new file +10 -0
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+#include <asm/irq.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/mach/irq.h>
+
+#include <mach/board.h>
+#include <mach/gpio.h>

please replace by linux/gpio.h

Quoted 7 lines
arch/arm/mach-at91/board-foxg20.c new file +7 -0
+#include <mach/at91sam9_smc.h>
+
+#include "sam9_smc.h"
+#include "generic.h"
+
+/*
+ * The FOX Board G20 hardware comes as the "Netus G20" board with

arch/arm/mach-at91/board-foxg20.c line 115

Quoted 10 lines
arch/arm/mach-at91/board-foxg20.c new file +10 -0
+ * just the cpu, ram, dataflash and two header connectors.
+ * This is plugged into the FOX Board which provides the ethernet,
+ * usb, rtc, leds, switch, ...
+ *
+ * For more info visit: http://www.acmesystems.it/foxg20
+ */
+
+
+	.is_rmii	= 1,
+};

please not 4 blank line

Quoted 17 lines
arch/arm/mach-at91/board-foxg20.c new file +17 -0
+
+
+
+
+/*
+ * MCI (SD/MMC)
+ * det_pin, wp_pin and vcc_pin are not connected
+ */
+static struct at91_mmc_data __initdata foxg20_mmc_data = {
+	.slot_b		= 1,
+	.wire4		= 1,
+};
+
+
+/*
+ * LEDs
+ */

arch/arm/mach-at91/board-foxg20.c line 174

Quoted 10 lines
arch/arm/mach-at91/board-foxg20.c new file +10 -0
+static struct gpio_led foxg20_leds[] = {
+	{	/* user led, red */
+		.name			= "user_led",
+		.gpio			= AT91_PIN_PC7,
+		.active_low		= 0,
+		.default_trigger	= "heartbeat",
+	},
+};
+
+

please also fix some white spaces

use checkpatch.pl

Best Regards,
J.

#2 lore raw

Hi Sergio,

Le 15/10/2010 14:32, Jean-Christophe PLAGNIOL-VILLARD :

Quoted 6 lines

arch/arm/mach-at91/board-foxg20.c line 5

Quoted 6 lines
arch/arm/mach-at91/board-foxg20.c new file +5 -0
@@ -0,0 +1,279 @@
+/*
+ *  Copyright (C) 2005 SAN People
+ *  Copyright (C) 2008 Atmel
+ *  Copyright (C) 2010 Lee McLoughlin - lee at lmmrtech.com
+ *  Copyright (C) 2010 Sergio Tanzilli - tanzilli at acmesystems.it

[..]

I am about to push your patch upstream with modifications highlighted by Jean-Christophe. But I need your:

Signed-off-by xxxxxx <xxx@xxx>

line.

Please simply send me this line in response to your original patch so that I can add it while sending your patch upstream.

Thanks, best regards,

Signature · 1 line
Nicolas Ferre
#3 lore raw

PATCH 1/1 Acme Systems FOX Board G20 board files

In reply to Sergio Tanzilli

One more thing, Sergio,

Quoted 5 lines · Sergio Tanzilli <tanzilli <at> acmesystems.it> writes:
---
 arch/arm/mach-at91/Kconfig        |    7 +
 arch/arm/mach-at91/Makefile       |    2 +
 arch/arm/mach-at91/board-foxg20.c |  279 +++++++++++++++++++++++++++++++++++++

[..]

Quoted 1 line

+MACHINE_START(FOXG20, "Acme Systems srl FOX Board G20")

It seems your machine is not registered with FOXG20 name in Russell's machine
registry: it is "ACMENETUSFOXG20".

So, tell me which name to use and should I modify your patch to cope with what is already in mach-types...

Best regards,

Signature · 1 line
Nicolas Ferre