Skip to contentSkip to conversation

3c52x: remove IRQF_SAMPLE_RANDOM from legacy MCA drivers.

PATCH Applied Paul Gortmaker 2 participants 2 messages Oct 15, 2010 – Oct 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3c52x: remove IRQF_SAMPLE_RANDOM from legacy MCA drivers.

If you are genuinely using one of these legacy MCA drivers then you are tragically on hardware where you really don't have the extra CPU cycles to be wasting on this.

In addition, it makes two less cases for people to inadvertently blindly copy flags from without explicitly thinking whether it makes sense -- see the addition to feature-removal.txt as per commit 9d9b8fb0e5ebf4b0398e579f6061d4451fea3242.

---
 drivers/net/3c523.c |    2 +-
 drivers/net/3c527.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/3c523.c +1 -1
index 1719079..3aa9baa 100644
@@ -287,7 +287,7 @@ static int elmc_open(struct net_device *dev)
 
 	elmc_id_attn586();	/* disable interrupts */
 
-	ret = request_irq(dev->irq, elmc_interrupt, IRQF_SHARED | IRQF_SAMPLE_RANDOM,
+	ret = request_irq(dev->irq, elmc_interrupt, IRQF_SHARED,
 			  dev->name, dev);
 	if (ret) {
 		pr_err("%s: couldn't get irq %d\n", dev->name, dev->irq);
drivers/net/3c527.c +1 -1
index 5c07b14..cf4cfd3 100644
@@ -443,7 +443,7 @@ static int __init mc32_probe1(struct net_device *dev, int slot)
 	 *	Grab the IRQ
 	 */
 
-	err = request_irq(dev->irq, mc32_interrupt, IRQF_SHARED | IRQF_SAMPLE_RANDOM, DRV_NAME, dev);
+	err = request_irq(dev->irq, mc32_interrupt, IRQF_SHARED, DRV_NAME, dev);
 	if (err) {
 		release_region(dev->base_addr, MC32_IO_EXTENT);
 		pr_err("%s: unable to get IRQ %d.\n", DRV_NAME, dev->irq);
Signature · 1 line
1.7.2.1
maintainer Applied
#1 lore raw

From: Paul Gortmaker <[email protected]>
Date: Thu, 14 Oct 2010 20:21:51 -0400

Quoted 10 lines

If you are genuinely using one of these legacy MCA drivers then you are tragically on hardware where you really don't have the extra CPU cycles to be wasting on this.

In addition, it makes two less cases for people to inadvertently blindly copy flags from without explicitly thinking whether it makes sense -- see the addition to feature-removal.txt as per commit 9d9b8fb0e5ebf4b0398e579f6061d4451fea3242.

Applied, thank you.