list-modems patch

Quoted 116 lines

Quoted 104 lines

Quoted 97 lines

Quoted 90 lines

Quoted 44 lines

Quoted 29 lines

Sometimes i see

[root(a)alexander-desktop ofono-0.31]# /usr/lib/ofono/test/list-modems [ /huawei5 ]
Features = sim
Powered = 1
Interfaces = org.ofono.Phonebook org.ofono.AudioSettings
org.ofono.VoiceCallManager org.ofono.SimManager
Online = 0
Model = E1550
Manufacturer = huawei
Serial = 353142033084081
Revision = 11.608.12.00.143
[ org.ofono.Phonebook ]
[ org.ofono.AudioSettings ]
Traceback (most recent call last):
File "/usr/lib/ofono/test/list-modems", line 61, in <module>

    print "        %s = %s" % (key, val).encode('ascii')

Patch

test/list-modems +0 -0

index 557efd5..df1dca8 100755

test/list-modems for path, properties in modems: · line 66

Quoted 10 lines

test/list-modems +5 -1

@@ -58,6 +58,10 @@ for path, properties in modems:
                                        ")" for text, icon in
 properties[key] ])
                        else:
                             	val = str(properties[key])
-                       print "        %s = %s" % (key, val)
+                       try:
+                               print  "       %s = %s" % (key, val)
+                       except:
+                               continue
+

can you at least print the key value. Just not printing that property at all is bad since it is there. Just marking the value as not printable seems to be the better approach.

Quoted 6 lines

Regards

Marcel

Last fully-working script

[ /huawei0 ]

del overquote

ServiceNumbers = [Моб. Помощник] = '111' [MTС] =
'+78003330890' [Служба спасения] = '112'
CardIdentifier = 89701012417666587513 LockedPins =
PinRequired = none
SubscriberIdentity = 250011766658751 Present = 1

[Моб. Помощник] - in russian means "Mobile Partner" [Служба спасения] - rescue rangers :3

test/list-modems +2 -2

index 557efd5..59765f9 100755
@@ -58,6 +58,10 @@ for path, properties in modems:
                                        ")" for text, icon in
 properties[key] ])
                        else:
                                val = str(properties[key])
-                       print "        %s = %s" % (key, val)
-
+                       try:
+                               print "        %s = %s" %

(key.encode('utf8'), val.encode('utf8'))

test/list-modems +2 -0

+                       except:
+                               print "Cannot encode some charcters

please change locale"

test/list-modems

Quoted 3 lines

test/list-modems +2 -0

+                       else:
+                                continue
        print

patch does not apply. Please always check with git am that your patch would apply cleanly. And that your mailer doesn't screw it up.

Quoted 6 lines

Regards

Marcel

Quoted 5 lines

Evolution reformate message anyway
Please click on link.
Was checked and applied for me with success

http://pastie.org/pastes/1220422/text

I see a whitespace damage in the patch and it is still not possible to apply this. Please send a proper patch to the mailing list. You do need to get your email client fixed anyway.

Regards

Quoted 4 lines

Marcel

Patch verified with applying 2 times.
File in attach.