Skip to contentSkip to conversation

[Added craneboard support 0/1]

PATCH In review [email protected] 3 participants 5 messages Oct 15, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover [Added craneboard support 0/1]

From: Srinath <[email protected]>

This series adds support for the AM3517/05 based craneboard. We are a team of engineers working at Mistral Solutions and will be sending patches to support this board. Request you to review and accept these patches.

Added board file for AM3517/05 craneboard

Srinath (1):
Added-craneboard-basic-support

 arch/arm/configs/omap2plus_defconfig    |    1 +
 arch/arm/mach-omap2/Kconfig             |    6 +++
 arch/arm/mach-omap2/Makefile            |    2 +
 arch/arm/mach-omap2/board-am3517crane.c |   68 +++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-am3517crane.c
author
#1 lore raw

PATCH 1/1 Added-craneboard-basic-support

From: Srinath <[email protected]>

Signed-off-by Srinath <[email protected]>
---
 arch/arm/configs/omap2plus_defconfig    |    1 +
 arch/arm/mach-omap2/Kconfig             |    6 +++
 arch/arm/mach-omap2/Makefile            |    2 +
 arch/arm/mach-omap2/board-am3517crane.c |   68 +++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-am3517crane.c
arch/arm/configs/omap2plus_defconfig +1 -0
index ccedde1..8c93f86 100644
@@ -40,6 +40,7 @@ CONFIG_MACH_OMAP_LDP=y
 CONFIG_MACH_OVERO=y
 CONFIG_MACH_OMAP3EVM=y
 CONFIG_MACH_OMAP3517EVM=y
+CONFIG_MACH_CRANEBOARD=y
 CONFIG_MACH_OMAP3_PANDORA=y
 CONFIG_MACH_OMAP3_TOUCHBOOK=y
 CONFIG_MACH_OMAP_3430SDP=y
arch/arm/mach-omap2/Kconfig +6 -0
index ab784bf..f4cf968 100644
@@ -174,6 +174,12 @@ config MACH_OMAP3517EVM
 	default y
 	select OMAP_PACKAGE_CBB
 
+config MACH_CRANEBOARD
+	bool "AM3517/05 CRANE board"
+	depends on ARCH_OMAP3
+	default y
+	select OMAP_PACKAGE_CBB
+
 config MACH_OMAP3_PANDORA
 	bool "OMAP3 Pandora"
 	depends on ARCH_OMAP3
arch/arm/mach-omap2/Makefile +2 -0
index 7352412..f885037 100644
@@ -170,6 +170,8 @@ obj-$(CONFIG_MACH_OMAP4_PANDA)		+= board-omap4panda.o \
 
 obj-$(CONFIG_MACH_OMAP3517EVM)		+= board-am3517evm.o
 
+obj-$(CONFIG_MACH_CRANEBOARD)		+= board-am3517crane.o
+
 obj-$(CONFIG_MACH_SBC3530)		+= board-omap3stalker.o \
 					   hsmmc.o
 # Platform specific device init code
arch/arm/mach-omap2/board-am3517crane.c new file +68 -0

68 lines not on this page · raw message

Signature · 1 line
1.7.1.226.g770c5
#2 lore raw

Re: [Added craneboard support 1/1] Added-craneboard-basic-support

[email protected] had written, on 10/15/2010 05:27 AM, the following:
$subject - suggest changes as previously posted.

Quoted 3 lines

From: Srinath <[email protected]>

Add information in commit message

Quoted 14 lines
Signed-off-by Srinath <[email protected]>
---
 arch/arm/configs/omap2plus_defconfig    |    1 +
 arch/arm/mach-omap2/Kconfig             |    6 +++
 arch/arm/mach-omap2/Makefile            |    2 +
 arch/arm/mach-omap2/board-am3517crane.c |   68 +++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-am3517crane.c
arch/arm/configs/omap2plus_defconfig +0 -0
index ccedde1..8c93f86 100644

arch/arm/configs/omap2plus_defconfig CONFIG_MACH_OMAP_LDP=y · line 46

Quoted 7 lines
arch/arm/configs/omap2plus_defconfig +1 -0
@@ -40,6 +40,7 @@ CONFIG_MACH_OMAP_LDP=y
 CONFIG_MACH_OVERO=y
 CONFIG_MACH_OMAP3EVM=y
 CONFIG_MACH_OMAP3517EVM=y
+CONFIG_MACH_CRANEBOARD=y
 CONFIG_MACH_OMAP3_PANDORA=y
 CONFIG_MACH_OMAP3_TOUCHBOOK=y
 CONFIG_MACH_OMAP_3430SDP=y

Tony can comment if he'd like this in the patch or not - given Linus's ARM defconfig anger.. :)

arch/arm/mach-omap2/Kconfig config MACH_OMAP3517EVM · line 180

Quoted 12 lines
arch/arm/mach-omap2/Kconfig +4 -0
index ab784bf..f4cf968 100644
@@ -174,6 +174,12 @@ config MACH_OMAP3517EVM
 	default y
 	select OMAP_PACKAGE_CBB
 
+config MACH_CRANEBOARD
+	bool "AM3517/05 CRANE board"
+	depends on ARCH_OMAP3
+	default y

I am guessing default y is a copy of the rest of the Kconfig..

Quoted 45 lines
arch/arm/mach-omap2/Kconfig +2 -0
+	select OMAP_PACKAGE_CBB
+
 config MACH_OMAP3_PANDORA
 	bool "OMAP3 Pandora"
 	depends on ARCH_OMAP3
arch/arm/mach-omap2/Makefile +2 -0
index 7352412..f885037 100644
@@ -170,6 +170,8 @@ obj-$(CONFIG_MACH_OMAP4_PANDA)		+= board-omap4panda.o \
 
 obj-$(CONFIG_MACH_OMAP3517EVM)		+= board-am3517evm.o
 
+obj-$(CONFIG_MACH_CRANEBOARD)		+= board-am3517crane.o
+
 obj-$(CONFIG_MACH_SBC3530)		+= board-omap3stalker.o \
 					   hsmmc.o
 # Platform specific device init code
arch/arm/mach-omap2/board-am3517crane.c new file +21 -0
new file mode 100644
index 0000000..c9390ce
@@ -0,0 +1,68 @@
+/*
+ * linux/arch/arm/mach-omap2/board-am3517crane.c
+ *
+ * Copyright (C) 2010 Mistral Solutions Pvt Ltd. <www.mistralsolutions.com>
+ * Author: R.Srinath <[email protected]>
+ *
+ * Based on mach-omap2/board-am3517evm.c
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as  published by the
+ * Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any kind,
+ * whether express or implied; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>

arch/arm/mach-omap2/board-am3517crane.c line 31

Quoted 10 lines
arch/arm/mach-omap2/board-am3517crane.c new file +10 -0
+#include <linux/gpio.h>
+
+#include <mach/hardware.h>
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+
+#include <plat/board.h>
+#include <plat/common.h>
+#include <plat/usb.h>

Do you need all these headers? I don't see the usage of usb or anything below - please have just the necessary ones.

arch/arm/mach-omap2/board-am3517crane.c line 35

Quoted 4 lines
arch/arm/mach-omap2/board-am3517crane.c new file +4 -0
+
+/*
+ * Board initialization
+ */

minor comment:
/* Board initialization */

Quoted 11 lines
arch/arm/mach-omap2/board-am3517crane.c new file +11 -0
+static struct omap_board_config_kernel am3517_crane_config[] __initdata = {
+};
+
+static struct platform_device *am3517_crane_devices[] __initdata = {
+};
+
+static void __init am3517_crane_init_irq(void)
+{
+	omap_board_config = am3517_crane_config;
+	omap_board_config_size = ARRAY_SIZE(am3517_crane_config);
+

arch/arm/mach-omap2/board-am3517crane.c line 56

Quoted 10 lines
arch/arm/mach-omap2/board-am3517crane.c new file +10 -0
+	omap2_init_common_hw(NULL, NULL);
+	omap_init_irq();
+	omap_gpio_init();
+}
+
+static void __init am3517_crane_init(void)
+{
+	platform_add_devices(am3517_crane_devices,
+			ARRAY_SIZE(am3517_crane_devices));
+	omap_serial_init();

no basic muxing etc?

Quoted 12 lines
arch/arm/mach-omap2/board-am3517crane.c new file +12 -0
+}
+
+MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
+	.phys_io	= 0x48000000,
+	.io_pg_offst	= ((0xd8000000) >> 18) & 0xfffc,
+	.boot_params	= 0x80000100,
+	.map_io		= omap3_map_io,
+	.reserve        = omap_reserve,
+	.init_irq	= am3517_crane_init_irq,
+	.init_machine	= am3517_crane_init,
+	.timer		= &omap_timer,
+MACHINE_END
Signature · 2 lines
Regards,
Nishanth Menon
maintainer
#3 lore raw

Re: [Added craneboard support 1/1] Added-craneboard-basic-support

In reply to [email protected]
Quoted 11 lines · * [email protected] <[email protected]> [101015 03:30]:

From: Srinath <[email protected]>

Signed-off-by Srinath <[email protected]>
---
 arch/arm/configs/omap2plus_defconfig    |    1 +
 arch/arm/mach-omap2/Kconfig             |    6 +++
 arch/arm/mach-omap2/Makefile            |    2 +
 arch/arm/mach-omap2/board-am3517crane.c |   68 +++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-am3517crane.c

Looks like you're missing the entry in uncompress.h for the uart?

To low-level debug, enable CONFIG_DEBUG_LL and CONFIG_EARLY_PRINTK, then have earlyprintk in your kernel cmdline.

Regards,

Tony

#4 lore raw
In reply to [email protected]

[email protected] had written, on 10/15/2010 05:27 AM, the following:

Quoted 10 lines

From: Srinath <[email protected]>

This series adds support for the AM3517/05 based craneboard. We are a team of
engineers working at Mistral Solutions and will be sending patches to support this board. Request you to review and accept these patches.

Added board file for AM3517/05 craneboard

Srinath (1):
Added-craneboard-basic-support

Quoted 6 lines
 arch/arm/configs/omap2plus_defconfig    |    1 +
 arch/arm/mach-omap2/Kconfig             |    6 +++
 arch/arm/mach-omap2/Makefile            |    2 +
 arch/arm/mach-omap2/board-am3517crane.c |   68 +++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-am3517crane.c

Few suggestions:

Please read:
http://omapedia.org/wiki/Releasing_to_Linux_kernel_using_patches_and_emails
http://elinux.org/Git_usage
on how to generate patches and post them
for example this covering letter is completely unnecessary, the patch1 $subject should have been:
OMAP: AM3517/05: board: Add craneboard support

All this info that you put in covering letter should have been part of the patch - remember to add a link to craneboard - most of us might not be aware of this board at all. this is the information that will be stored in git commit log for ever+ it has to also flow down from linux-omap down to linux-arm, lkml etc.. imagine yourself being a developer for ppc/intel processor and looking at this patch - the commit message and $subject should explain to them as well..

more as part of patch 1 review comments.

Signature · 2 lines
Regards,
Nishanth Menon