Bisected MSP34xx PVR-250/PVR-350 no audio in 2.6.36

DISCUSSION Andy Walls 2 participants 2 messages Oct 17, 2010 Media (V4L/DVB)

Share & tools

Andy Walls

author

2010-10-17 03:23 UTC #0 lore raw

Hans,

Shane Shrybman reported that in the 2.6.36 kernel, after the first capture on his PVR-250, TV audio from the RF input no longer works.

I verified that RF TV audio never works with a PVR-350.

I bisected the problem to this change to the msp3400 driver:

http://git.linuxtv.org/media_tree.git?a=commit;h=ebc3bba5833e7021336f09767347a52448a60bc5

$ git bisect bad
ebc3bba5833e7021336f09767347a52448a60bc5 is the first bad commit
commit ebc3bba5833e7021336f09767347a52448a60bc5
Author: Hans Verkuil <[email protected]>
Date:   Mon May 24 10:01:58 2010 -0300

V4L/DVB: msp3400: convert to the new control framework

Signed-off-by Hans Verkuil <[email protected]>

Signed-off-by Mauro Carvalho Chehab <[email protected]>

:040000 040000 fabcfdd08fe2835d9a146666c891b274b6546428 2199dcba591213638336d254b3a57d38bd068de4 M drivers

I don't have time to fix it this weekend, but there it is before I forget.

Regards,
Andy

Hans Verkuil

2010-10-17 09:10 UTC #1 lore raw

Quoted 20 lines · On Sunday, October 17, 2010 05:23:01 Andy Walls wrote:

Hans,
Shane Shrybman reported that in the 2.6.36 kernel, after the first capture on his PVR-250, TV audio from the RF input no longer works.
I verified that RF TV audio never works with a PVR-350.
I bisected the problem to this change to the msp3400 driver:
http://git.linuxtv.org/media_tree.git?a=commit;h=ebc3bba5833e7021336f09767347a52448a60bc5
$ git bisect bad
ebc3bba5833e7021336f09767347a52448a60bc5 is the first bad commit
commit ebc3bba5833e7021336f09767347a52448a60bc5
Author: Hans Verkuil <[email protected]>
Date:   Mon May 24 10:01:58 2010 -0300
V4L/DVB: msp3400: convert to the new control framework

Quoted 8 lines

Signed-off-by Hans Verkuil <[email protected]>
Signed-off-by Mauro Carvalho Chehab <[email protected]>
:040000 040000 fabcfdd08fe2835d9a146666c891b274b6546428 2199dcba591213638336d254b3a57d38bd068de4 M drivers
I don't have time to fix it this weekend, but there it is before I forget.

Since it is my code that broke it I took a quick look and I found the problem.

I'm trying to find the shortest fix possible since this is a regression for 2.6.36.

Regards,

Hans

Signature · 1 line

Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco