libdvdread: add recipe for version 4.1.3-10 from debian
PATCH 1/2 libdvdread: add recipe for version 4.1.3-10 from debian
--- recipes/libdvdread/libdvdread_4.1.3-10.bb | 3 +++ recipes/libdvdread/libdvdread_git.inc | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdread/libdvdread_4.1.3-10.bb create mode 100644 recipes/libdvdread/libdvdread_git.inc
recipes/libdvdread/libdvdread_4.1.3-10.bb new file +3 -0
@@ -0,0 +1,3 @@ +require libdvdread_git.inc + +SRCREV = "e465b500c12be5b4c0b6918a9b98038611f66c57"
recipes/libdvdread/libdvdread_git.inc new file +15 -0
@@ -0,0 +1,15 @@ +DESCRIPTION = "DVD access multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +S = "${WORKDIR}/git" + +inherit autotools binconfig lib_package pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +addtask unpackpost after do_unpack before do_patch
Signature · 1 line
1.7.1
PATCH 2/2 libdvdnav: add recipe for version 4.1.3-7 from debian
--- ...-dvdnavmini.pc-link-against-libdvdnavmini.patch | 25 ++++++++++++++++++++ recipes/libdvdnav/libdvdnav_4.1.3-7.bb | 5 ++++ recipes/libdvdnav/libdvdnav_git.inc | 24 +++++++++++++++++++ 3 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch create mode 100644 recipes/libdvdnav/libdvdnav_4.1.3-7.bb create mode 100644 recipes/libdvdnav/libdvdnav_git.inc
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +25 -0
@@ -0,0 +1,25 @@ +upstream: Daniel Baumann <[email protected]> +status: pending + +From 2329cd28d7508f9809f849fa547362aa7df160ba Mon Sep 17 00:00:00 2001 +From: Andreas Oberritter <[email protected]> +Date: Fri, 8 Oct 2010 00:50:54 +0000 +Subject: [PATCH] dvdnavmini.pc: link against libdvdnavmini + +--- + misc/dvdnavmini.pc.in | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/misc/dvdnavmini.pc.in b/misc/dvdnavmini.pc.in +index 52945b3..773be2f 100644 +--- a/misc/dvdnavmini.pc.in ++++ b/misc/dvdnavmini.pc.in +@@ -8,4 +8,4 @@ Description: DVD Navigation mini library + Version: @VERSION@ + + Cflags: -I${includedir} @DVDREAD_CFLAGS@ @THREAD_CFLAGS@ +-Libs: -L${libdir} -ldvdnav @THREAD_LIBS@ ++Libs: -L${libdir} -ldvdnavmini @THREAD_LIBS@ +-- +1.7.1 +
recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +5 -0
@@ -0,0 +1,5 @@ +require libdvdnav_git.inc + +SRC_URI += "file://0001-dvdnavmini.pc-link-against-libdvdnavmini.patch" + +SRCREV = "850e513d4fea29b40879378b13003cd677e5214b"
recipes/libdvdnav/libdvdnav_git.inc new file +24 -0
@@ -0,0 +1,24 @@ +DESCRIPTION = "DVD navigation multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL" +DEPENDS = "libdvdread" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +S = "${WORKDIR}/git" + +inherit autotools binconfig lib_package pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +FILES_${PN} = "${libdir}/${PN}${SOLIB}" + +addtask unpackpost after do_unpack before do_patch + +python populate_packages_prepend () { + description = bb.data.expand('${DESCRIPTION}', d) + libdir = bb.data.expand('${libdir}', d) + do_split_packages(d, libdir, '^lib(.*)\.so\..*', 'lib%s', description + ' (%s)', extra_depends='', allow_links=True) +}
Signature · 1 line
1.7.1
PATCH v2 1/1 libdvdnav: add recipe for version 4.1.3-7 from debian
* v2: inherit lib_package before binconfig
--- ...-dvdnavmini.pc-link-against-libdvdnavmini.patch | 25 ++++++++++++++++++++ recipes/libdvdnav/libdvdnav_4.1.3-7.bb | 5 ++++ recipes/libdvdnav/libdvdnav_git.inc | 24 +++++++++++++++++++ 3 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch create mode 100644 recipes/libdvdnav/libdvdnav_4.1.3-7.bb create mode 100644 recipes/libdvdnav/libdvdnav_git.inc
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +25 -0
@@ -0,0 +1,25 @@ +upstream: Daniel Baumann <[email protected]> +status: pending + +From 2329cd28d7508f9809f849fa547362aa7df160ba Mon Sep 17 00:00:00 2001 +From: Andreas Oberritter <[email protected]> +Date: Fri, 8 Oct 2010 00:50:54 +0000 +Subject: [PATCH] dvdnavmini.pc: link against libdvdnavmini + +--- + misc/dvdnavmini.pc.in | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/misc/dvdnavmini.pc.in b/misc/dvdnavmini.pc.in +index 52945b3..773be2f 100644 +--- a/misc/dvdnavmini.pc.in ++++ b/misc/dvdnavmini.pc.in +@@ -8,4 +8,4 @@ Description: DVD Navigation mini library + Version: @VERSION@ + + Cflags: -I${includedir} @DVDREAD_CFLAGS@ @THREAD_CFLAGS@ +-Libs: -L${libdir} -ldvdnav @THREAD_LIBS@ ++Libs: -L${libdir} -ldvdnavmini @THREAD_LIBS@ +-- +1.7.1 +
recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +5 -0
@@ -0,0 +1,5 @@ +require libdvdnav_git.inc + +SRC_URI += "file://0001-dvdnavmini.pc-link-against-libdvdnavmini.patch" + +SRCREV = "850e513d4fea29b40879378b13003cd677e5214b"
recipes/libdvdnav/libdvdnav_git.inc new file +24 -0
@@ -0,0 +1,24 @@ +DESCRIPTION = "DVD navigation multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL" +DEPENDS = "libdvdread" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +S = "${WORKDIR}/git" + +inherit autotools lib_package binconfig pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +FILES_${PN} = "${libdir}/${PN}${SOLIB}" + +addtask unpackpost after do_unpack before do_patch + +python populate_packages_prepend () { + description = bb.data.expand('${DESCRIPTION}', d) + libdir = bb.data.expand('${libdir}', d) + do_split_packages(d, libdir, '^lib(.*)\.so\..*', 'lib%s', description + ' (%s)', extra_depends='', allow_links=True) +}
Signature · 1 line
1.7.1
Re: [PATCH v2] libdvdnav: add recipe for version 4.1.3-7 from debian
2010/10/17 Andreas Oberritter <[email protected]>:
Quoted 30 lines
* v2: inherit
lib_packagebefore binconfigSigned-off-by Andreas Oberritter <[email protected]>---
...-dvdnavmini.pc-link-against-libdvdnavmini.patch | 25 ++++++++++++++++++++ recipes/libdvdnav/libdvdnav_4.1.3-7.bb | 5 ++++ recipes/libdvdnav/libdvdnav_git.inc | 24 +++++++++++++++++++3 files changed, 54 insertions(+), 0 deletions(-)create mode 100644
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patchcreate mode 100644 recipes/libdvdnav/libdvdnav_4.1.3-7.bb
create mode 100644 recipes/libdvdnav/libdvdnav_git.increcipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +12
-0@@ -0,0 +1,25 @@ +upstream: Daniel Baumann <[email protected]> +status: pending + +From 2329cd28d7508f9809f849fa547362aa7df160ba Mon Sep 17 00:00:00 2001 +From: Andreas Oberritter <[email protected]> +Date: Fri, 8 Oct 2010 00:50:54 +0000 +Subject: [PATCH] dvdnavmini.pc: link against libdvdnavmini + +--- + misc/dvdnavmini.pc.in | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) +
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch line 22
Quoted 10 lines
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +10
-0+diff --git a/misc/dvdnavmini.pc.in b/misc/dvdnavmini.pc.in +index 52945b3..773be2f 100644 +--- a/misc/dvdnavmini.pc.in ++++ b/misc/dvdnavmini.pc.in +@@ -8,4 +8,4 @@ Description: DVD Navigation mini library + Version: @VERSION@ + + Cflags: -I${includedir} @DVDREAD_CFLAGS@ @THREAD_CFLAGS@ +-Libs: -L${libdir} -ldvdnav @THREAD_LIBS@ ++Libs: -L${libdir} -ldvdnavmini @THREAD_LIBS@
Is this not better done with CFLAGS and LDFLAGS ? (personally I prefer using CFLAGS above a patch, as it is less likely to break if you move to a newer version).
recipes/libdvdnav/libdvdnav_4.1.3-7.bb line 1
Quoted 10 lines
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +3
-0+-- +1.7.1 +recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +1
-0@@ -0,0 +1,5 @@ +require libdvdnav_git.inc
I feel that in general an inc file should not have any version info in the name. It is supposed to to be for multiple versions, exception could be if an inc file is to share info between e.g. native cross target sdk versions (like e.g. for gcc).
Since there is only one recipe using it, I'd suggest inlining the inc file. Otherwise if you feel keeping the inc is useful, rename the file to libdvdnav.inc
recipes/libdvdnav/libdvdnav_git.inc line 3
Quoted 13 lines
recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +4
-0+ +SRC_URI += "file://0001-dvdnavmini.pc-link-against-libdvdnavmini.patch" + +SRCREV = "850e513d4fea29b40879378b13003cd677e5214b"recipes/libdvdnav/libdvdnav_git.inc new file +3
-0@@ -0,0 +1,24 @@ +DESCRIPTION = "DVD navigation multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL"
v2+ ?
Quoted 22 lines
recipes/libdvdnav/libdvdnav_git.inc new file +21
-1+DEPENDS = "libdvdread" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +S = "${WORKDIR}/git" + +inherit autotools lib_package binconfig pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +FILES_${PN} = "${libdir}/${PN}${SOLIB}" + +addtask unpackpost after do_unpack before do_patch + +python populate_packages_prepend () { + description = bb.data.expand('${DESCRIPTION}', d) + libdir = bb.data.expand('${libdir}', d) + do_split_packages(d, libdir, '^lib(.*)\.so\..*', 'lib%s', description + ' (%s)', extra_depends='', allow_links=True) +} --
Quoted 2 lines
1.7.1
Best regards, Frans
Re: [PATCH v2] libdvdnav: add recipe for version 4.1.3-7 from debian
Quoted 37 lines · Frans Meulenbroeks
2010/10/17 Andreas Oberritter <[email protected]>:
Quoted 36 lines
* v2: inherit
lib_packagebefore binconfigSigned-off-by Andreas Oberritter <[email protected]>--- ...-dvdnavmini.pc-link-against-libdvdnavmini.patch | 25 ++++++++++++++++++++ recipes/libdvdnav/libdvdnav_4.1.3-7.bb | 5 ++++ recipes/libdvdnav/libdvdnav_git.inc | 24 +++++++++++++++++++ 3 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch create mode 100644 recipes/libdvdnav/libdvdnav_4.1.3-7.bb create mode 100644 recipes/libdvdnav/libdvdnav_git.increcipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +18
-0@@ -0,0 +1,25 @@ +upstream: Daniel Baumann <[email protected]> +status: pending + +From 2329cd28d7508f9809f849fa547362aa7df160ba Mon Sep 17 00:00:00 2001 +From: Andreas Oberritter <[email protected]> +Date: Fri, 8 Oct 2010 00:50:54 +0000 +Subject: [PATCH] dvdnavmini.pc: link against libdvdnavmini + +--- + misc/dvdnavmini.pc.in | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/misc/dvdnavmini.pc.in b/misc/dvdnavmini.pc.in +index 52945b3..773be2f 100644 +--- a/misc/dvdnavmini.pc.in ++++ b/misc/dvdnavmini.pc.in +@@ -8,4 +8,4 @@ Description: DVD Navigation mini library + Version: @VERSION@
Quoted 8 lines
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch line 22
Quoted 4 lines
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +4
-0+ + Cflags: -I${includedir} @DVDREAD_CFLAGS@ @THREAD_CFLAGS@ +-Libs: -L${libdir} -ldvdnav @THREAD_LIBS@ ++Libs: -L${libdir} -ldvdnavmini @THREAD_LIBS@Is this not better done with CFLAGS and LDFLAGS ? (personally I prefer using CFLAGS above a patch, as it is less likely to break if you move to a newer version).
I don't understand what you mean here. libdvdnavmini is part of this package and this is the template for the .pc file, which gets installed by the -dev package. It's a bug in upstream code and the patch has been submitted to the maintainer.
Quoted 16 lines
recipes/libdvdnav/libdvdnav_4.1.3-7.bb line 1
Quoted 10 lines
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +3
-0+-- +1.7.1 +recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +1
-0@@ -0,0 +1,5 @@ +require libdvdnav_git.incI feel that in general an inc file should not have any version info in the name. It is supposed to to be for multiple versions, exception could be if an inc file is to share info between e.g. native cross target sdk versions (like e.g. for gcc).
Quoted 3 lines
Since there is only one recipe using it, I'd suggest inlining the inc file. Otherwise if you feel keeping the inc is useful, rename the file to libdvdnav.inc
OK.
Quoted 7 lines
Quoted 7 lines
recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +4
-0+ +SRC_URI += "file://0001-dvdnavmini.pc-link-against-libdvdnavmini.patch" + +SRCREV = "850e513d4fea29b40879378b13003cd677e5214b"recipes/libdvdnav/libdvdnav_git.inc new file +0
-0
Quoted 8 lines
recipes/libdvdnav/libdvdnav_git.inc line 3
Quoted 6 lines
recipes/libdvdnav/libdvdnav_git.inc new file +3
-0@@ -0,0 +1,24 @@ +DESCRIPTION = "DVD navigation multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL"v2+ ?
Yes.
I'll send updated patches for both libdvdread and libdvdnav shortly
Thanks,
Andreas
PATCH v3 1/1 libdvdnav: add recipe for version 4.1.3-7 from debian
* v2: inherit lib_package before binconfig
* v3: License set to GPLv2+
* v3: Inlined libdvdnav_git.inc
--- ...-dvdnavmini.pc-link-against-libdvdnavmini.patch | 25 +++++++++++++++++++ recipes/libdvdnav/libdvdnav_4.1.3-7.bb | 26 ++++++++++++++++++++ 2 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch create mode 100644 recipes/libdvdnav/libdvdnav_4.1.3-7.bb
recipes/libdvdnav/files/0001-dvdnavmini.pc-link-against-libdvdnavmini.patch new file +25 -0
@@ -0,0 +1,25 @@ +upstream: Daniel Baumann <[email protected]> +status: pending + +From 2329cd28d7508f9809f849fa547362aa7df160ba Mon Sep 17 00:00:00 2001 +From: Andreas Oberritter <[email protected]> +Date: Fri, 8 Oct 2010 00:50:54 +0000 +Subject: [PATCH] dvdnavmini.pc: link against libdvdnavmini + +--- + misc/dvdnavmini.pc.in | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/misc/dvdnavmini.pc.in b/misc/dvdnavmini.pc.in +index 52945b3..773be2f 100644 +--- a/misc/dvdnavmini.pc.in ++++ b/misc/dvdnavmini.pc.in +@@ -8,4 +8,4 @@ Description: DVD Navigation mini library + Version: @VERSION@ + + Cflags: -I${includedir} @DVDREAD_CFLAGS@ @THREAD_CFLAGS@ +-Libs: -L${libdir} -ldvdnav @THREAD_LIBS@ ++Libs: -L${libdir} -ldvdnavmini @THREAD_LIBS@ +-- +1.7.1 +
recipes/libdvdnav/libdvdnav_4.1.3-7.bb new file +26 -0
@@ -0,0 +1,26 @@ +DESCRIPTION = "DVD navigation multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPLv2+" +DEPENDS = "libdvdread" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian \ + file://0001-dvdnavmini.pc-link-against-libdvdnavmini.patch" + +SRCREV = "850e513d4fea29b40879378b13003cd677e5214b" +S = "${WORKDIR}/git" + +inherit autotools lib_package binconfig pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +FILES_${PN} = "${libdir}/${PN}${SOLIB}" + +addtask unpackpost after do_unpack before do_patch + +python populate_packages_prepend () { + description = bb.data.expand('${DESCRIPTION}', d) + libdir = bb.data.expand('${libdir}', d) + do_split_packages(d, libdir, '^lib(.*)\.so\..*', 'lib%s', description + ' (%s)', extra_depends='', allow_links=True) +}
Signature · 1 line
1.7.1
Re: [PATCH v3] libdvdnav: add recipe for version 4.1.3-7 from debian
pushed several of your patches.
Please make sure your patches do not have whitespace errors
got a few of these:/home/frans/oe/openembedded/.git/rebase-apply/patch:54: trailing whitespace.
/home/frans/oe/openembedded/.git/rebase-apply/patch:59: space before tab in indent.
cd $(srcdir) && \
Frans
PATCH v2 1/1 libdvdread: add recipe for version 4.1.3-10 from debian
In reply to Andreas Oberritter* v2: inherit lib_package before binconfig
--- recipes/libdvdread/libdvdread_4.1.3-10.bb | 3 +++ recipes/libdvdread/libdvdread_git.inc | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdread/libdvdread_4.1.3-10.bb create mode 100644 recipes/libdvdread/libdvdread_git.inc
recipes/libdvdread/libdvdread_4.1.3-10.bb new file +3 -0
@@ -0,0 +1,3 @@ +require libdvdread_git.inc + +SRCREV = "e465b500c12be5b4c0b6918a9b98038611f66c57"
recipes/libdvdread/libdvdread_git.inc new file +15 -0
@@ -0,0 +1,15 @@ +DESCRIPTION = "DVD access multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPL" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +S = "${WORKDIR}/git" + +inherit autotools lib_package binconfig pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +addtask unpackpost after do_unpack before do_patch
Signature · 1 line
1.7.1
PATCH v3 1/1 libdvdread: add recipe for version 4.1.3-10 from debian
* v2: inherit lib_package before binconfig
* v3: License set to GPLv2+
* v3: Inlined libdvdread_git.inc
--- recipes/libdvdread/libdvdread_4.1.3-10.bb | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 recipes/libdvdread/libdvdread_4.1.3-10.bb
recipes/libdvdread/libdvdread_4.1.3-10.bb new file +16 -0
@@ -0,0 +1,16 @@ +DESCRIPTION = "DVD access multimeda library" +SECTION = "libs/multimedia" +LICENSE = "GPLv2+" + +SRC_URI = "git://git.debian-maintainers.org/git/daniel/${PN}.git;protocol=git;branch=debian" + +SRCREV = "e465b500c12be5b4c0b6918a9b98038611f66c57" +S = "${WORKDIR}/git" + +inherit autotools lib_package binconfig pkgconfig + +do_unpackpost() { + QUILT_PATCHES=debian/patches quilt push -a +} + +addtask unpackpost after do_unpack before do_patch
Signature · 1 line
1.7.1