powerpc: sysdev: fix signedness bug
Subsystems (2)
PATCH 1/1 powerpc: sysdev: fix signedness bug
sram_params.sram_size and sram_params.sram_offset were unsigned. If get_cache_sram_size() or get_cache_sram_offset() returns error code then it is not seen to the caller. Made sram_size and sram_offset signed.
Signed-off-by Vasiliy Kulikov <[email protected]>
--- arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c +2 -2
@@ -94,14 +94,14 @@ static int __devinit mpc85xx_l2ctlr_of_probe(struct platform_device *dev, l2cache_size = *prop; sram_params.sram_size =get_cache_sram_size (); -if (sram_params.sram_size <=0 ) { +if ((int )sram_params.sram_size <=0 ) {dev_err (&dev->dev,"Entire L2 as cache, Aborting Cache-SRAM stuff\n" );return -EINVAL ; } sram_params.sram_offset =get_cache_sram_offset (); -if (sram_params.sram_offset <=0 ) { +if ((int64_t )sram_params.sram_offset <=0 ) {dev_err (&dev->dev,"Entire L2 as cache, provide a valid sram offset\n" );return -EINVAL ;
Signature · 1 line
1.7.0.4
Kumar Gala
AppliedQuoted 8 lines · Vasiliy Kulikov
sram_params.sram_size and sram_params.sram_offset were unsigned. If
get_cache_sram_size()orget_cache_sram_offset()returns error code then it is not seen to the caller. Madesram_sizeandsram_offsetsigned.Signed-off-by Vasiliy Kulikov <[email protected]>---
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c| 4 ++--1 files changed, 2 insertions(+), 2 deletions(-)
applied
- k