: msi: Mask out multi-function flag from PCI_HEADER_TYPE in read_pci_mem_bar()
PATCH 1/1 : msi: Mask out multi-function flag from PCI_HEADER_TYPE in read_pci_mem_bar()
This leads to an erroneous WARN_ON and possibly other side effects. It seems to me that even multi-function devices ought to enjoy the privilege of MSI-X capabilities.
Signed-off-by Gianni Tedesco <[email protected]>
xen/arch/x86/msi.c +1 -1
@@ -527,7 +527,7 @@ static u64 read_pci_mem_bar(u8 bus, u8 su8 limit;u32 addr; -switch (pci_conf_read8 (bus, slot, func,PCI_HEADER_TYPE ) ) +switch (pci_conf_read8 (bus, slot, func,PCI_HEADER_TYPE ) &0x7f ) {case PCI_HEADER_TYPE_NORMAL : limit =6 ;
Noticed I should have replied to this one.
Quoted 6 lines
Quoted 1 line
Quoted 1 line · Gianni Tedesco
This leads to an erroneous
WARN_ONand possibly other side effects. It seems to me that even multi-function devices ought to enjoy the privilege of MSI-X capabilities.Signed-off-by Gianni Tedesco <[email protected]>
Acked-by Jan Beulich <[email protected]>
Quoted 12 lines
diff -r
fc2242ac90e1xen/arch/x86/msi.cxen/arch/x86/msi.c +1
-1@@ -527,7 +527,7 @@ static u64 read_pci_mem_bar(u8 bus, u8 su8 limit;u32 addr; -switch (pci_conf_read8 (bus, slot, func,PCI_HEADER_TYPE ) ) +switch (pci_conf_read8 (bus, slot, func,PCI_HEADER_TYPE ) &0x7f ) {case PCI_HEADER_TYPE_NORMAL : limit =6 ;