Skip to contentSkip to conversation

mx35pdk: add debug board support

PATCH New jgq516 at gmail.com 2 participants 4 messages Oct 21, 2010 – Oct 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mx35pdk: add debug board support

From: Xiao Jiang <[email protected]>

Enable debug board support for mx35pdk.

---
Change since v2:
- s/board/debugboard per Bacuch's comment.

Change since v1:
- Add MXC_DEBUG_BOARD in Kconfig per Fabio's comment.
- Redefinition EXPIO_PARENT_INT per Fabio's comment.

 arch/arm/mach-mx3/Kconfig         |    1 +
 arch/arm/mach-mx3/mach-mx35_3ds.c |    8 ++++++++
 2 files changed, 9 insertions(+), 0 deletions(-)
arch/arm/mach-mx3/Kconfig +1 -0
index 85beece..cdf6ac5 100644
@@ -139,6 +139,7 @@ config MACH_ARMADILLO5X0
 config MACH_MX35_3DS
 	bool "Support MX35PDK platform"
 	select ARCH_MX35
+	select MXC_DEBUG_BOARD
 	select IMX_HAVE_PLATFORM_IMX_UART
 	default n
 	help
arch/arm/mach-mx3/mach-mx35_3ds.c +8 -0
index 1c30d72..eafe168 100644
@@ -35,10 +35,14 @@
 #include <mach/hardware.h>
 #include <mach/common.h>
 #include <mach/iomux-mx35.h>
+#include <mach/irqs.h>
+#include <mach/3ds_debugboard.h>
 
 #include "devices-imx35.h"
 #include "devices.h"
 
+#define EXPIO_PARENT_INT       (MXC_INTERNAL_IRQS + GPIO_PORTA + 1)
+
 static const struct imxuart_platform_data uart_pdata __initconst = {
 	.flags = IMXUART_HAVE_RTSCTS,
 };
@@ -95,6 +99,10 @@ static void __init mxc_board_init(void)
 	imx35_add_imx_uart0(&uart_pdata);
 
 	mxc_register_device(&mxc_otg_udc_device, &usb_pdata);
+
+	if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))
+		pr_warn("Init of the debugboard failed, all "
+			"devices on the debugboard are unusable.\n");
 }
 
 static void __init mx35pdk_timer_init(void)
Signature · 1 line
1.6.3.3
author
#1 lore raw

PATCH v3 1/1 mx35pdk: add debug board support

Hi Sascha,

Could you apply the patch in your tree, I have regenrated the patch based on for-rmk-next branch of your tree, pls check the attached patch.

Thanks,
Xiao Jiang

2010/10/21 <[email protected]>

Quoted 62 lines

From: Xiao Jiang <[email protected]>

Enable debug board support for mx35pdk.

---
Change since v2:
- s/board/debugboard per Bacuch's comment.

Change since v1:
- Add MXC_DEBUG_BOARD in Kconfig per Fabio's comment.
- Redefinition EXPIO_PARENT_INT per Fabio's comment.

 arch/arm/mach-mx3/Kconfig         |    1 +
 arch/arm/mach-mx3/mach-mx35_3ds.c |    8 ++++++++
 2 files changed, 9 insertions(+), 0 deletions(-)
arch/arm/mach-mx3/Kconfig +1 -0
index 85beece..cdf6ac5 100644
@@ -139,6 +139,7 @@ config MACH_ARMADILLO5X0
 config MACH_MX35_3DS
       bool "Support MX35PDK platform"
       select ARCH_MX35
+       select MXC_DEBUG_BOARD
       select IMX_HAVE_PLATFORM_IMX_UART
       default n
       help
arch/arm/mach-mx3/mach-mx35_3ds.c +8 -1
index 1c30d72..eafe168 100644
@@ -35,10 +35,14 @@
 #include <mach/hardware.h>
 #include <mach/common.h>
 #include <mach/iomux-mx35.h>
+#include <mach/irqs.h>
+#include <mach/3ds_debugboard.h>
 
 #include "devices-imx35.h"
 #include "devices.h"
 
+#define EXPIO_PARENT_INT       (MXC_INTERNAL_IRQS + GPIO_PORTA + 1)
+
 static const struct imxuart_platform_data uart_pdata __initconst = {
       .flags = IMXUART_HAVE_RTSCTS,
 };
@@ -95,6 +99,10 @@ static void __init mxc_board_init(void)
       imx35_add_imx_uart0(&uart_pdata);
 
       mxc_register_device(&mxc_otg_udc_device, &usb_pdata);
+
+       if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))
+               pr_warn("Init of the debugboard failed, all "
+                       "devices on the debugboard are unusable.\n");
 }
 
 static void __init mx35pdk_timer_init(void)
--
Quoted 3 lines

1.6.3.3

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101022/863e0fe4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mx35pdk-add-debug-board-support-based-rmk-next.patch
Type: application/octet-stream
Size: 1814 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101022/863e0fe4/attachment.obj>

#2 lore raw

PATCH v3 1/1 mx35pdk: add debug board support

Xiao,

Quoted 4 lines · xiao jiang

Hi Sascha,

Could you apply the patch in your tree, I have regenrated the patch based on for-rmk-next branch of your tree, pls check the attached patch.

This patch is in imx-for-2.6.37 git tree now.

Regards,

Fabio Estevam

author
#3 lore raw

PATCH v3 1/1 mx35pdk: add debug board support

Good to know! :0

Thanks,
Xiao Jiang

2010/10/22, Fabio Estevam <[email protected]>:

Quoted 15 lines

Xiao,

Quoted 5 lines · xiao jiang

Hi Sascha,

Could you apply the patch in your tree, I have regenrated the patch based on
for-rmk-next branch of your tree, pls check the attached patch.

This patch is in imx-for-2.6.37 git tree now.

Regards,

Fabio Estevam