Skip to contentSkip to conversation

mm: Fix comment at truncate_setsize()

PATCH In review Jan Kara 3 participants 4 messages Oct 21, 2010

Subsystems (3)
lore
Share & tools
lore

Jan Kara

author maintainer
#0 lore raw

PATCH 1/1 mm: Fix comment at truncate_setsize()

The main fix in this patch is that truncate_setsize() should be called *before* not after filesystem truncated blocks.

CC Christoph Hellwig <[email protected]>
---
 mm/truncate.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)
mm/truncate.c +5 -6
index ba887bf..e13e535 100644
@@ -545,13 +545,12 @@ EXPORT_SYMBOL(truncate_pagecache);
  * @inode: inode
  * @newsize: new file size
  *
- * truncate_setsize updastes i_size update and performs pagecache
- * truncation (if necessary) for a file size updates. It will be
- * typically be called from the filesystem's setattr function when
- * ATTR_SIZE is passed in.
+ * truncate_setsize updates i_size and performs pagecache truncation (if
+ * necessary) to @newsize. It will be typically be called from the filesystem's
+ * setattr function when ATTR_SIZE is passed in.
  *
- * Must be called with inode_mutex held and after all filesystem
- * specific block truncation has been performed.
+ * Must be called with inode_mutex held and before all filesystem specific
+ * block truncation has been performed.
  */
 void truncate_setsize(struct inode *inode, loff_t newsize)
 {
Signature · 1 line
1.6.4.2
maintainer
#2 lore raw
In reply to Jan Kara
Quoted 2 lines · Jan Kara

The main fix in this patch is that truncate_setsize() should be called *before* not after filesystem truncated blocks.

ITYM "contrary to what comment says, ..."; as it is, commit message alone reads as if commit fixed the problem with actual code.

author maintainer
#3 lore raw
Quoted 6 lines · Al Viro
Quoted 2 lines · Jan Kara

The main fix in this patch is that truncate_setsize() should be called *before* not after filesystem truncated blocks.

ITYM "contrary to what comment says, ..."; as it is, commit message alone reads as if commit fixed the problem with actual code.

OK. Attached is a version with updated changelog. Is it better?

Honza

Quoted 1 line

From f237e25cae0b628fc81e4fa69b3b2a2ab2d0b086 Mon Sep 17 00:00:00 2001

From: Jan Kara <[email protected]>
Date: Thu, 21 Oct 2010 11:29:09 +0200
Subject: [PATCH] mm: Fix comment at truncate_setsize()

The main fix in this patch is that, contrary to what the comment says, truncate_setsize() should be called *before* filesystem truncated blocks.

CC Christoph Hellwig <[email protected]>
---
 mm/truncate.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)
mm/truncate.c +5 -6
index ba887bf..e13e535 100644
@@ -545,13 +545,12 @@ EXPORT_SYMBOL(truncate_pagecache);
  * @inode: inode
  * @newsize: new file size
  *
- * truncate_setsize updastes i_size update and performs pagecache
- * truncation (if necessary) for a file size updates. It will be
- * typically be called from the filesystem's setattr function when
- * ATTR_SIZE is passed in.
+ * truncate_setsize updates i_size and performs pagecache truncation (if
+ * necessary) to @newsize. It will be typically be called from the filesystem's
+ * setattr function when ATTR_SIZE is passed in.
  *
- * Must be called with inode_mutex held and after all filesystem
- * specific block truncation has been performed.
+ * Must be called with inode_mutex held and before all filesystem specific
+ * block truncation has been performed.
  */
 void truncate_setsize(struct inode *inode, loff_t newsize)
 {
Signature · 1 line
1.6.4.2