Skip to contentSkip to conversation

Typo in ehci-fsl ?

U-Boot New André Schwarz 3 participants 3 messages Oct 21, 2010

lore
Share & tools
lore
#0 lore raw

Damien,

I get a build error on MVBLM7 board on current top of tree.

In file include/usb/ehci-fsl.h line 164 checks for CONFIG_MPC83XX introduced by

commit 29c6fbe0471afd7ffa41fcb2103eec5b53294897

Author: Damien Dusha <[email protected]>
Date:   Thu Oct 14 15:27:06 2010 +0200

MPC5121: Add USB EHCI support

Coding style cleanup; slight file restructuring.

Shouldn't this be CONFIG_MPC83xx or do I need to update my board config ? Have I missed something ?

Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#1 lore raw

PATCH 1/1 Fix building for 83xx boards with USB support

Commit 29c6fbe0471afd7ffa41fcb2103eec5b53294897 broke building for 83xx boards with USB support:

ehci-fsl.c: In function 'ehci_hcd_init':
ehci-fsl.c:43: error: 'CONFIG_SYS_FSL_USB_ADDR' undeclared (first use in this function) ehci-fsl.c:43: error: (Each undeclared identifier is reported only once ehci-fsl.c:43: error: for each function it appears in.)
make[1]: *** [ehci-fsl.o] Error 1

---
 include/usb/ehci-fsl.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/usb/ehci-fsl.h +1 -1
index 08691a0..67600ed 100644
@@ -161,7 +161,7 @@
 #define MPC83XX_SCCR_USB_DRCM_01	0x00100000
 #define MPC83XX_SCCR_USB_DRCM_10	0x00200000
 
-#if defined(CONFIG_MPC83XX)
+#if defined(CONFIG_MPC83xx)
 #define CONFIG_SYS_FSL_USB_ADDR CONFIG_SYS_MPC83xx_USB_ADDR
 #elif defined(CONFIG_MPC85xx)
 #define CONFIG_SYS_FSL_USB_ADDR CONFIG_SYS_MPC85xx_USB_ADDR
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 1/1 Fix building for 83xx boards with USB support

Dear Anatolij Gustschin,

Quoted 9 lines · In message <[email protected]> you wrote:

Commit 29c6fbe0471afd7ffa41fcb2103eec5b53294897 broke building for 83xx boards with USB support:

ehci-fsl.c: In function 'ehci_hcd_init':
ehci-fsl.c:43: error: 'CONFIG_SYS_FSL_USB_ADDR' undeclared (first use in this function) ehci-fsl.c:43: error: (Each undeclared identifier is reported only once ehci-fsl.c:43: error: for each function it appears in.)
make[1]: *** [ehci-fsl.o] Error 1

Quoted 4 lines
---
 include/usb/ehci-fsl.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from the Boss... "I didn't say it was your fault.  I said I was
going to blame it on you."