Skip to contentSkip to conversation

corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

PATCH New Kumar Gala 2 participants 5 messages Oct 22, 2010

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.

---
 include/configs/corenet_ds.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/corenet_ds.h +1 -1
index 85147d0..2733fb2 100644
@@ -213,7 +213,7 @@
 #endif
 #define CONFIG_SYS_INIT_RAM_END		0x00004000	/* End of used area in RAM */
 
-#define CONFIG_SYS_GBL_DATA_SIZE	128	/* num bytes initial data */
+#define CONFIG_SYS_GBL_DATA_SIZE	256	/* num bytes initial data */
 #define CONFIG_SYS_GBL_DATA_OFFSET	(CONFIG_SYS_INIT_RAM_END - CONFIG_SYS_GBL_DATA_SIZE)
 #define CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_GBL_DATA_OFFSET
 
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

Dear Kumar Gala,

Quoted 4 lines · In message <[email protected]> you…

The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.

One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Documentation is the castor oil of programming.
Managers know it must be good because the programmers hate it so much.
author
#2 lore raw

PATCH 1/1 corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

Quoted 10 lines · Wolfgang Denk

Dear Kumar Gala,

Quoted 4 lines · In message <[email protected]> you…

The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.

One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?

I was wondering the same thing, let me try it and see what happens.

- k

author
#3 lore raw

PATCH 1/1 corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

Quoted 9 lines · Kumar Gala
Quoted 6 lines · Wolfgang Denk

Dear Kumar Gala,

Quoted 3 lines · In message <[email protected]> you…

The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

One thing I always wondered is why we don't simply use sizeof(gd_t) instead. What do you think?

I was wondering the same thing, let me try it and see what happens.

Requires asm-offset support like in kernel for us to this properly. Will leave it as is for now and fix for post v2010.12

- k

author Applied
#4 lore raw

PATCH 1/1 corenet_ds: Update CONFIG_SYS_GBL_DATA_SIZE to deal with growth in gd_t

In reply to Kumar Gala
Quoted 7 lines · Kumar Gala

The recent change the env code added an additional 32 bytes into gd_t and that causes to grow pass the previous CONFIG_SYS_GBL_DATA_SIZE size.

---
include/configs/corenet_ds.h | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

applied to 85xx

- k