kconfig: don't select 64 bit option on sparc32 all{yes,mod}config
PATCH 1/1 kconfig: don't select 64 bit option on sparc32 all{yes,mod}config
The SPARC architecture provides 64BIT config option to select build type and it is set to 1 on ARCH=sparc64 as a default value. But in case of 32-bit, it is also set to 1 by the allyesconfig logic, end result would be the same as of sparc64. So I think it would be better if plain ARCH=sparc all{yes,mod}config do not set it then we can test 32-bit build by default.
--- scripts/kconfig/confdata.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
scripts/kconfig/confdata.c +4 -0
@@ -1018,6 +1018,10 @@ void conf_set_all_new_symbols(enum conf_def_mode mode)break ; } +/* Do not set 64 bit option when sparc32 allyesconfig */ +if (sym->name &&strcmp (sym->name,"64BIT" ) ==0 && +strcmp (getenv ("ARCH" ),"sparc" ) ==0 ) + sym->def[S_DEF_USER ].tri = no; }sym_clear_all_valid ();
Signature · 1 line
1.7.0.4
Quoted 10 lines · Namhyung Kim
The SPARC architecture provides 64BIT config option to select build type and it is set to 1 on ARCH=sparc64 as a default value. But in case of 32-bit, it is also set to 1 by the allyesconfig logic, end result would be the same as of sparc64. So I think it would be better if plain ARCH=sparc all{yes,mod}config do not set it then we can test 32-bit build by default.
Signed-off-by Namhyung Kim <[email protected]>--- scripts/kconfig/confdata.c | 4 ++++
Can't this be fixed in the sparc Makefile/Kconfig instead? E.g. have ARCH=sparc -> ask
ARCH=sparc64 -> CONFIG_64BIT=y
ARCH=sparc32 -> # CONFIG_64BIT is not set
like the x86/i386/x86_64 ARCH option for x86.
Michal
2010-10-25 (월), 00:10 +0200, Michal Marek:
Quoted 12 lines · Namhyung Kim
Quoted 10 lines
The SPARC architecture provides 64BIT config option to select build type and it is set to 1 on ARCH=sparc64 as a default value. But in case of 32-bit, it is also set to 1 by the allyesconfig logic, end result would be the same as of sparc64. So I think it would be better if plain ARCH=sparc all{yes,mod}config do not set it then we can test 32-bit build by default.
Signed-off-by Namhyung Kim <[email protected]>--- scripts/kconfig/confdata.c | 4 ++++
Quoted 7 lines
Can't this be fixed in the sparc Makefile/Kconfig instead? E.g. have ARCH=sparc -> ask
ARCH=sparc64 ->CONFIG_64BIT=y
ARCH=sparc32 -> #CONFIG_64BITis not set
like the x86/i386/x86_64 ARCH option for x86.Michal
Looks better. :-) I didn't noticed that CONFIG_64BIT setup on sparc was just same as x86's. Adding sparc32 target will simply resolve the issue. The patch follows, Thanks.
kbuild: add ARCH=sparc32 target
Add 'sparc32' ARCH target to test all{yes,mod}config for 32-bit build.
Makefile +3 -0
@@ -204,6 +204,9 @@ ifeq ($(ARCH),x86_64) endif # Additional ARCH settings for sparc +ifeq ($(ARCH),sparc32) + SRCARCH := sparc +endif ifeq ($(ARCH),sparc64) SRCARCH := sparc endif
Signature · 2 lines
Regards, Namhyung Kim