LME2510(C) DM04/QQBOX USB DVB-S BOXES
Subsystems (2)
PATCH 1/1 LME2510(C) DM04/QQBOX USB DVB-S BOXES
Updated driver for DM04/QQBOX USB DVB-S BOXES to version 1.60
These include
-later kill of usb_buffer to avoid kernel crash on hot unplugging. -DiSEqC functions.
-LNB Power switch
-Faster channel change.
-support for LG tuner on LME2510C.
-firmware switching for LG tuner.
Documentation/dvb/lmedm04.txt +6 -3
@@ -45,10 +45,13 @@ and run Other LG firmware can be extracted manually from US280D.sys only found in windows/system32/driver. -However, this firmware does not run very well under Windows -or with the Linux driver. -dd if=US280D.sys ibs=1 skip=36856 count=3976 of=dvb-usb-lme2510-lg.fw +dd if=US280D.sys ibs=1 skip=42616 count=3668 of=dvb-usb-lme2510-lg.fw + +for DM04 LME2510C (LG Tuner) +--------------------------- + +dd if=US280D.sys ibs=1 skip=35200 count=3850 of=dvb-usb-lme2510c-lg.fw ---------------------------------------------------------------------
drivers/media/dvb/dvb-usb/Kconfig +0 -1
@@ -356,6 +356,5 @@ config DVB_USB_LME2510 select DVB_TDA826X if !DVB_FE_CUSTOMISE select DVB_STV0288 if !DVB_FE_CUSTOMISE select DVB_IX2505V if !DVB_FE_CUSTOMISE - depends on IR_CORE help Say Y here to support the LME DM04/QQBOX DVB-S USB2.0 .
drivers/media/dvb/dvb-usb/lmedm04.c +222 -70
520 lines not on this page · raw message
drivers/media/dvb/dvb-usb/lmedm04.h +15 -29
115 lines not on this page · raw message
Em 16-10-2010 16:44, tvbox escreveu:
Review
Quoted 9 lines
Updated driver for DM04/QQBOX USB DVB-S BOXES to version 1.60
These include
(quoted diff) +0
-6-later kill of usb_buffer to avoid kernel crash on hot unplugging. -DiSEqC functions. -LNB Power switch -Faster channel change. -support for LG tuner on LME2510C. -firmware switching for LG tuner.
Please, don't do updates like that, adding several different things into just one patch. Instead, send one patch per change.
This time, I'll accept it as-is, but please break it into small patches next time.
Thanks,
Mauro.
Quoted 14 lines · Mauro Carvalho Chehab
Em 16-10-2010 16:44, tvbox escreveu:
Review
Quoted 9 lines
Updated driver for DM04/QQBOX USB DVB-S BOXES to version 1.60
These include
(quoted diff) +0
-6-later kill of usb_buffer to avoid kernel crash on hot unplugging. -DiSEqC functions. -LNB Power switch -Faster channel change. -support for LG tuner on LME2510C. -firmware switching for LG tuner.Please, don't do updates like that, adding several different things into just one patch. Instead, send one patch per change.
The patches as released is a working driver.
This device is particularly temperamental and covers several adaptations. The driver returned to beta testing through several of those changes.
I didn't want release patches that would have produced an unworkable driver for the user.
Regards
Malcolm
Em 23-10-2010 07:15, tvbox escreveu:
Quoted 15 lines · Mauro Carvalho Chehab
Quoted 14 lines
Em 16-10-2010 16:44, tvbox escreveu:
Review
Quoted 9 lines
Updated driver for DM04/QQBOX USB DVB-S BOXES to version 1.60
These include
(quoted diff) +0
-6-later kill of usb_buffer to avoid kernel crash on hot unplugging. -DiSEqC functions. -LNB Power switch -Faster channel change. -support for LG tuner on LME2510C. -firmware switching for LG tuner.Please, don't do updates like that, adding several different things into just one patch. Instead, send one patch per change.
Quoted 8 lines
The patches as released is a working driver.
This device is particularly temperamental and covers several adaptations. The driver returned to beta testing through several of those changes.
I didn't want release patches that would have produced an unworkable driver for the user.
Ok, but, instead of sending one patch grouping several changes, please send me a series of patches. In this case, you should be sending, instead, 6 patches (e. g. one for each functional change), e. g. :
[PATCH 1/6] later kill of usb_buffer to avoid kernel crash on hot unplugging [PATCH 2/6] DiSEqC functions
[PATCH 3/6] LNB Power switch
[PATCH 4/6] Faster channel change
[PATCH 5/6] support for LG tuner on LME2510C
[PATCH 6/6] firmware switching for LG tuner
properly describing at the body why each patch is needed.
Cheers,
Mauro.