Skip to contentSkip to conversation

loop warnings in current git HEAD

PATCH In review Christoph Hellwig 3 participants 6 messages Oct 23, 2010 – Oct 25, 2010 Block layer

lore
Share & tools
lore
#0 lore raw

The loop driver in current git HEAD is rather unhappy when running xfstests. I gets lots of warnings like the one below. The most likely culprit seems to be:

loop: add some basic read-only sysfs attributes

(commit ee86273062cbb310665fe49e1f1937d2cf85b0b9)

[ 1055.017350] WARNING: at /home/hch/work/linux-2.6/fs/sysfs/dir.c:451 sysfs_add_one+0xa4/0x110()
[ 1055.019843] Hardware name: Bochs
[ 1055.021004] sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'
[ 1055.023362] Modules linked in:
[ 1055.024274] Pid: 7028, comm: mount Tainted: G        W   2.6.36+ #6
[ 1055.025622] Call Trace:
[ 1055.026312]  [<c0169ead>] warn_slowpath_common+0x6d/0xa0
[ 1055.027464]  [<c026f534>] ? sysfs_add_one+0xa4/0x110
[ 1055.028651]  [<c026f534>] ? sysfs_add_one+0xa4/0x110
[ 1055.030329]  [<c0169f5e>] warn_slowpath_fmt+0x2e/0x30
[ 1055.031877]  [<c026f534>] sysfs_add_one+0xa4/0x110
[ 1055.033052]  [<c09e7645>] ? mutex_lock_nested+0x35/0x40
[ 1055.034273]  [<c026f5fc>] create_dir+0x5c/0xa0
[ 1055.035318]  [<c026f712>] sysfs_create_subdir+0x22/0x30
[ 1055.036570]  [<c0270aec>] internal_create_group+0x4c/0x170
[ 1055.037778]  [<c0270c3c>] sysfs_create_group+0xc/0x10
[ 1055.038902]  [<c079de83>] lo_ioctl+0x623/0x8c0
[ 1055.042214]  [<c019a3fa>] ? print_lock_contention_bug+0x1a/0xe0
[ 1055.043471]  [<c079d860>] ? lo_ioctl+0x0/0x8c0
[ 1055.044557]  [<c07065ac>] __blkdev_driver_ioctl+0x2c/0x40
[ 1055.048076]  [<c0706a9b>] blkdev_ioctl+0x21b/0x730
[ 1055.049155]  [<c019bf3b>] ? trace_hardirqs_on+0xb/0x10
[ 1055.050277]  [<c023ce0b>] block_ioctl+0x3b/0x50
[ 1055.051302]  [<c023cdd0>] ? block_ioctl+0x0/0x50
[ 1055.059103]  [<c02216ed>] do_vfs_ioctl+0x7d/0x5e0
[ 1055.060225]  [<c021d510>] ? path_put+0x20/0x30
[ 1055.061263]  [<c0217881>] ? sys_readlinkat+0x71/0x90
[ 1055.062360]  [<c0221c89>] sys_ioctl+0x39/0x60
[ 1055.063358]  [<c09e907d>] syscall_call+0x7/0xb
[ 1055.064470] ---[ end trace 1de52d78815cd17d ]---
#1 lore raw
Quoted 7 lines · Christoph Hellwig

The loop driver in current git HEAD is rather unhappy when running xfstests. I gets lots of warnings like the one below. The most likely culprit seems to be:

loop: add some basic read-only sysfs attributes

(commit ee86273062cbb310665fe49e1f1937d2cf85b0b9)

yes, seems I forgot bdev can be NULL in destructor (autoclear mode). can you try if patch below helps?

Milan

loop: Properly clear sysfs in autoclear mode

drivers/block/loop.c +1 -1
index 6c48b35..c21d4f3 100644
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
+	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
-		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}
#2 lore raw
Quoted 2 lines · Milan Broz

yes, seems I forgot bdev can be NULL in destructor (autoclear mode). can you try if patch below helps?

Yes, this patch seems to fix the issue for me.

#3 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines · Milan Broz

yes, seems I forgot bdev can be NULL in destructor (autoclear mode). can you try if patch below helps?

Yes, this patch seems to fix the issue for me.

Great.

Jens, please can you queue it to block git then?

Btw there seems to be other loop problem I just found (not related to my patch) when loop compiled as module oopses on unload, I'll try to bisect it.

Milan

#4 lore raw

PATCH 1/1 loop: Properly clear sysfs in autoclear mode

In reply to Christoph Hellwig

In autoclear mode bdev is NULL but the sysfs entry should be destroyed otherwise this warning appears:

WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95()

sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'

Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9

---
 drivers/block/loop.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/loop.c +1 -1
index 6c48b35..c21d4f3 100644
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
+	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
-		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}
Signature · 1 line
1.7.2.3
#5 lore raw

Re: [PATCH] loop: Properly clear sysfs in autoclear mode

Quoted 18 lines · Milan Broz

In autoclear mode bdev is NULL but the sysfs entry should be destroyed otherwise this warning appears:

WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95()

sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'

Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9

---
 drivers/block/loop.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/loop.c +0 -0
index 6c48b35..c21d4f3 100644

drivers/block/loop.c static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev) · line 1057

Quoted 10 lines
drivers/block/loop.c +1 -1
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
        if (bdev)
                invalidate_bdev(bdev);
        set_capacity(lo->lo_disk, 0);
+       loop_sysfs_exit(lo);
        if (bdev) {
                bd_set_size(bdev, 0);
-               loop_sysfs_exit(lo);
                /* let user-space know about this change */
                kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
        }

Tested and worked.

Thanks,
Jeff