Skip to contentSkip to conversation

wireless/wl1271: remove redundant if-statement

PATCH In review Nicolas Kaiser 3 participants 5 messages Oct 24, 2010 – Oct 26, 2010 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireless/wl1271: remove redundant if-statement

Apparently the return value of wl1271_ps_elp_sleep never gets checked anyway.

---
 drivers/net/wireless/wl12xx/wl1271_event.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1271_event.c +0 -2
index 7b3f503..38ccef7 100644
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
 
 		/* go to extremely low power mode */
 		wl1271_ps_elp_sleep(wl);
-		if (ret < 0)
-			break;
 		break;
 	case EVENT_EXIT_POWER_SAVE_FAIL:
 		wl1271_debug(DEBUG_PSM, "PSM exit failed");
Signature · 1 line
1.7.2.2
#1 lore raw
Quoted 2 lines · Nicolas Kaiser

Apparently the return value of wl1271_ps_elp_sleep never gets checked anyway.

The patch is fine, but this comment is a little misleading as wl1271_ps_elp_sleep() is void and cannot return a value.

Larry

#2 lore raw
Quoted 6 lines · ext Larry Finger
Quoted 2 lines · Nicolas Kaiser

Apparently the return value of wl1271_ps_elp_sleep never gets checked anyway.

The patch is fine, but this comment is a little misleading as wl1271_ps_elp_sleep() is void and cannot return a value.

Yes, this patch is good, but please rewrite the description, as Larry suggested.

Signature · 2 lines
Cheers,
Luca.
#3 lore raw

PATCH 1/1 wireless/wl1271: remove redundant if-statement v2

wl1271_ps_elp_sleep() is void and cannot return a value.

---
Sorry for the poor wording of the initial description.

 drivers/net/wireless/wl12xx/wl1271_event.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1271_event.c +0 -2
index 7b3f503..38ccef7 100644
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
 
 		/* go to extremely low power mode */
 		wl1271_ps_elp_sleep(wl);
-		if (ret < 0)
-			break;
 		break;
 	case EVENT_EXIT_POWER_SAVE_FAIL:
 		wl1271_debug(DEBUG_PSM, "PSM exit failed");
Signature · 1 line
1.7.2.2
Reviewed-by on v1 1/1 Applied
#4 lore raw

Re: [PATCH] wireless/wl1271: remove redundant if-statement v2

Quoted 14 lines · ext Nicolas Kaiser

wl1271_ps_elp_sleep() is void and cannot return a value.

---
Sorry for the poor wording of the initial description.

 drivers/net/wireless/wl12xx/wl1271_event.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1271_event.c +0 -0
index 7b3f503..38ccef7 100644

drivers/net/wireless/wl12xx/wl1271_event.c static int wl1271_event_ps_report(struct wl1271 *wl, · line 139

Quoted 8 lines
drivers/net/wireless/wl12xx/wl1271_event.c +0 -2
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
 
 		/* go to extremely low power mode */
 		wl1271_ps_elp_sleep(wl);
-		if (ret < 0)
-			break;
 		break;
 	case EVENT_EXIT_POWER_SAVE_FAIL:
 		wl1271_debug(DEBUG_PSM, "PSM exit failed");

Thanks! Applied to the wl12xx tree.

Signature · 2 lines
Cheers,
Luca.