ARMV7: Fix build for non-OMAP3 boards
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Commit c3d3a54 uses CONFIG_ARMV7 to determine whether to call the v7_flush_cache_all function. This breaks the build for all non-OMAP3 boards (like Panda and OMAP4430SDP) since there is only a v7_flush_cache_all implementation for OMAP3.
This patch uses CONFIG_OMAP3XXX instead of CONFIG_ARMV7 so that only boards with a v7_flush_cache_all will make the call.
Tested on Beagle, Overo, Panda, and OMAP4430SDP
---
arch/arm/lib/cache.c +1 -1
@@ -38,7 +38,7 @@ void flush_cache (unsigned long dummy1, unsigned long dummy2)/* disable write buffer as well (page 2-22) */ asm("mcr p15, 0, %0, c7, c10, 4" : :"r" (0 ));#endif -#ifdef CONFIG_ARMV7 +#ifdef CONFIG_OMAP34XX void v7_flush_cache_all (void );v7_flush_cache_all ();
Premi
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Quoted 13 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Steve Sakoman
Sent: Saturday, October 23, 2010 2:20 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsCommit c3d3a54 uses
CONFIG_ARMV7to determine whether to call thev7_flush_cache_allfunction. This breaks the build for all non-OMAP3 boards (like Panda and OMAP4430SDP) since there is only av7_flush_cache_all
implementation for OMAP3.
Quoted 3 lines
This patch uses
CONFIG_OMAP3XXXinstead ofCONFIG_ARMV7so that only boards
with av7_flush_cache_allwill make the call.
[sp] Is this call board specific?
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Quoted 13 lines · Sanjeev
Quoted 13 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Steve Sakoman
Sent: Saturday, October 23, 2010 2:20 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsCommit c3d3a54 uses
CONFIG_ARMV7to determine whether to call thev7_flush_cache_allfunction. This breaks the build for all non-OMAP3 boards (like Panda and OMAP4430SDP) since there is only av7_flush_cache_all
implementation for OMAP3.
Quoted 5 lines
Quoted 3 lines
This patch uses
CONFIG_OMAP3XXXinstead ofCONFIG_ARMV7so that only boards
with av7_flush_cache_allwill make the call.[sp] Is this call board specific?
No, it is not.
Steve
Premi
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Quoted 22 lines
-----Original Message-----
From: Steve Sakoman [mailto:steve at sakoman.com]
Sent: Monday, October 25, 2010 6:52 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsQuoted 9 lines · Sanjeev
Quoted 9 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Steve Sakoman
Sent: Saturday, October 23, 2010 2:20 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsCommit c3d3a54 uses
CONFIG_ARMV7to determine whether to call thev7_flush_cache_allfunction. This breaks the build forall non-OMAP3
Quoted 4 lines
Quoted 4 lines
boards (like Panda and OMAP4430SDP) since there is only a
v7_flush_cache_all
implementation for OMAP3.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
This patch uses
CONFIG_OMAP3XXXinstead ofCONFIG_ARMV7so that only boards
with av7_flush_cache_allwill make the call.[sp] Is this call board specific?
No, it is not.
[sp] I asked because I can see omap3/cache.S but not under omap-common/
(as I was expecting) - neither in omap4/
Doesn't this patch works-around the problem by using CONFIG_OMAP34XX? Wouldn't change in cache.S (or Makefile) be better solution/ or workaround. At least workaround will be visible to more eyes.
~sanjeev
Quoted 6 lines
Steve
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Quoted 26 lines · Sanjeev
Quoted 26 lines
-----Original Message-----
From: Steve Sakoman [mailto:steve at sakoman.com]
Sent: Monday, October 25, 2010 6:52 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsQuoted 9 lines · Sanjeev
Quoted 9 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Steve Sakoman
Sent: Saturday, October 23, 2010 2:20 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsCommit c3d3a54 uses
CONFIG_ARMV7to determine whether to call thev7_flush_cache_allfunction. This breaks the build forall non-OMAP3
Quoted 8 lines
Quoted 7 lines
boards (like Panda and OMAP4430SDP) since there is only a
v7_flush_cache_all
implementation for OMAP3.This patch uses
CONFIG_OMAP3XXXinstead ofCONFIG_ARMV7so that only boards
with av7_flush_cache_allwill make the call.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
[sp] Is this call board specific?
No, it is not.
[sp] I asked because I can see
omap3/cache.Sbut not under omap-common/
(as I was expecting) - neither in omap4/Doesn't this patch works-around the problem by using
CONFIG_OMAP34XX?
Yes, this is a hopefully temporary fix to allow non-OMAP3 ARMV7 boards to build.
Quoted 2 lines
Wouldn't change in
cache.S(orMakefile) be better solution/ or workaround. At least workaround will be visible to more eyes.
Ideally we would have a generic ARMV7 implementation that would work for even non-OMAP ARMV7 processors. Someone who is familiar with the differences in ARMV7 cache implementations from the various silicon vendors would need to do this. This beyond my knowledge.
A "second best" solution would be to have a cache.S that worked for both OMAP3 and OMAP4 in omap-common/
If this isn't possible, then we should add an OMAP4 specific cache.S in omap4/
But until we settle on the proper long term strategy this patch should be applied so that non-OMAP3 ARMV7 boards will build.
Steve
Premi
PATCH 1/1 ARMV7: Fix build for non-OMAP3 boards
Quoted 65 lines
-----Original Message-----
From: Steve Sakoman [mailto:steve at sakoman.com]
Sent: Monday, October 25, 2010 8:38 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boardsQuoted 6 lines · Sanjeev
Quoted 6 lines
-----Original Message-----
From: Steve Sakoman [mailto:steve at sakoman.com]
Sent: Monday, October 25, 2010 6:52 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH] ARMV7: Fix build fornon-OMAP3 boards
Quoted 5 lines
Quoted 5 lines · Sanjeev
Quoted 3 lines
Quoted 3 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf OfSteve Sakoman
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Sent: Saturday, October 23, 2010 2:20 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Fix build fornon-OMAP3 boards
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Commit c3d3a54 uses
CONFIG_ARMV7to determine whetherto call the
Quoted 10 lines
Quoted 10 lines
Quoted 1 line
Quoted 1 line
v7_flush_cache_allfunction. This breaks the build forall non-OMAP3
Quoted 8 lines
Quoted 7 lines
boards (like Panda and OMAP4430SDP) since there is only a
v7_flush_cache_all
implementation for OMAP3.This patch uses
CONFIG_OMAP3XXXinstead ofCONFIG_ARMV7so that only boards
with av7_flush_cache_allwill make the call.Quoted 5 lines
Quoted 3 lines
Quoted 1 line
[sp] Is this call board specific?
No, it is not.
[sp] I asked because I can see
omap3/cache.Sbut not underomap-common/
Quoted 3 lines
(as I was expecting) - neither in omap4/
Doesn't this patch works-around the problem by using
CONFIG_OMAP34XX?Yes, this is a hopefully temporary fix to allow non-OMAP3 ARMV7 boards to build.
Quoted 2 lines
Wouldn't change in
cache.S(orMakefile) be better solution/ or workaround. At least workaround will be visible to more eyes.Ideally we would have a generic ARMV7 implementation that would work for
even non-OMAP ARMV7 processors. Someone who is familiar with the differences in ARMV7 cache implementations from the various silicon vendors would need to do this. This beyond my knowledge.A "second best" solution would be to have a
cache.Sthat worked for both
OMAP3 and OMAP4 in omap-common/
Quoted 7 lines
If this isn't possible, then we should add an OMAP4 specific
cache.Sin
omap4/But until we settle on the proper long term strategy this patch should be applied so that non-OMAP3 ARMV7 boards will build.
Can we indicate either in the title/ description that patch is temporary?
Quoted 4 lines
Steve