Skip to contentSkip to conversation

b43: remove extraneous code in free_ringmemory

PATCH New John W. Linville 2 participants 2 messages Oct 25, 2010 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: remove extraneous code in free_ringmemory

This code seems to have been cut-n-pasted from alloc_ringmemory? Anyway, it is useless.

---
 drivers/net/wireless/b43/dma.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/net/wireless/b43/dma.c +0 -5
index 10d0aaf..3d5566e 100644
@@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
 
 static void free_ringmemory(struct b43_dmaring *ring)
 {
-	gfp_t flags = GFP_KERNEL;
-
-	if (ring->type == B43_DMA_64BIT)
-		flags |= GFP_DMA;
-
 	dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
 			  ring->descbase, ring->dmabase);
 }
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 b43: remove extraneous code in free_ringmemory

Quoted 1 line · John W. Linville

This code seems to have been cut-n-pasted from alloc_ringmemory?

No. It's leftover from the old SSB DMA mem allocator, which needed the GFP flags.

Quoted 1 line

Anyway, it is useless.

ACK.

Quoted 21 lines
---
 drivers/net/wireless/b43/dma.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/net/wireless/b43/dma.c +0 -5
index 10d0aaf..3d5566e 100644
@@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
 
 static void free_ringmemory(struct b43_dmaring *ring)
 {
-	gfp_t flags = GFP_KERNEL;
-
-	if (ring->type == B43_DMA_64BIT)
-		flags |= GFP_DMA;
-
 	dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
 			  ring->descbase, ring->dmabase);
 }
Signature · 1 line
Greetings Michael.