Skip to contentSkip to conversation

misc: apds9802als: fix signedness bug

PATCH New Vasiliy Kulikov 1 participant 1 message Oct 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: apds9802als: fix signedness bug

i2c_smbus_read_byte_data() may return negative error code. This is not seen to als_sensing_range_store() as the result is stored in unsigned int. Made it signed.

---
Compile tested.

 drivers/misc/apds9802als.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/misc/apds9802als.c +1 -1
index f9b91ba..0ed0935 100644
@@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct als_data *data = i2c_get_clientdata(client);
-	unsigned int ret_val;
+	int ret_val;
 	unsigned long val;
 
 	if (strict_strtoul(buf, 10, &val))
Signature · 1 line
1.7.0.4