Skip to contentSkip to conversation

bluetooth: hidp: fix information leak to userland

PATCH Applied Vasiliy Kulikov 3 participants 3 messages Oct 30, 2010 – Nov 3, 2010

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bluetooth: hidp: fix information leak to userland

Structure hidp_conninfo is copied to userland with version, product, vendor and name fields unitialized if both session->input and session->hid are NULL. It leads to leaking of contents of kernel stack memory.

---
Compile tested.

 net/bluetooth/hidp/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/bluetooth/hidp/core.c +1 -1
index c0ee8b3..29544c2 100644
@@ -107,6 +107,7 @@ static void __hidp_unlink_session(struct hidp_session *session)
 
 static void __hidp_copy_session(struct hidp_session *session, struct hidp_conninfo *ci)
 {
+	memset(ci, 0, sizeof(*ci));
 	bacpy(&ci->bdaddr, &session->bdaddr);
 
 	ci->flags = session->flags;
@@ -115,7 +116,6 @@ static void __hidp_copy_session(struct hidp_session *session, struct hidp_connin
 	ci->vendor  = 0x0000;
 	ci->product = 0x0000;
 	ci->version = 0x0000;
-	memset(ci->name, 0, 128);
 
 	if (session->input) {
 		ci->vendor  = session->input->id.vendor;
Signature · 1 line
1.7.0.4
#2 lore raw
Quoted 9 lines · Marcel Holtmann

Hi Vasiliy,

Quoted 5 lines

Structure hidp_conninfo is copied to userland with version, product, vendor and name fields unitialized if both session->input and session->hid are NULL. It leads to leaking of contents of kernel stack memory.

Applied, thanks.

Signature · 2 lines
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi