ath9k-htc: fix probe failure
PATCH 1/1 ath9k-htc: fix probe failure
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2 [ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2: ath9k_htc: Unable to allocate URBs [ 8.037506] ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driver ath9k_hif_usb
--- drivers/net/wireless/ath/ath9k/hif_usb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/hif_usb.c +2 -2
@@ -541,7 +541,7 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb) }usb_fill_int_urb (urb, hif_dev->udev, -usb_rcvbulkpipe (hif_dev->udev, +usb_rcvintpipe (hif_dev->udev,USB_REG_IN_PIPE ), nskb->data,MAX_REG_IN_BUF_SIZE , ath9k_hif_usb_reg_in_cb, nskb,1 );
@@ -721,7 +721,7 @@ static int ath9k_hif_usb_alloc_reg_in_urb(struct hif_device_usb *hif_dev) goto err;usb_fill_int_urb (hif_dev->reg_in_urb, hif_dev->udev, -usb_rcvbulkpipe (hif_dev->udev, +usb_rcvintpipe (hif_dev->udev,USB_REG_IN_PIPE ), skb->data,MAX_REG_IN_BUF_SIZE , ath9k_hif_usb_reg_in_cb, skb,1 );
Signature · 1 line
1.7.3
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2 [ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2: ath9k_htc: Unable to allocate URBs [ 8.037506] ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driver ath9k_hif_usb
NACK. To optimize CPU consumption and scan duration, HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
- Rajkumar
2010/11/2 Rajkumar Manoharan <[email protected]>:
Quoted 12 lines
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2
[ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2:ath9k_htc: Unable to allocate URBs [ 8.037506]ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driverath9k_hif_usb
Quoted 6 lines
NACK. To optimize CPU consumption and scan duration, HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
My card is UB91, so you means I should update to this one(ar9271.fw) blew:
This one still can't prevent the probe failure...
Any suggestions?
thanks,
Signature · 1 line
Lei Ming
Quoted 20 lines
2010/11/2 Rajkumar Manoharan <[email protected]>:
Quoted 12 lines
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2 [ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2: ath9k_htc: Unable to allocate URBs [ 8.037506] ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driver ath9k_hif_usbQuoted 6 lines
NACK. To optimize CPU consumption and scan duration, HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
Quoted 7 lines
My card is UB91, so you means I should update to this one(ar9271.fw) blew:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux->firmware.git;a=blob;f=ar9271.fw;h=0ec953b404c1912dc64fa3b0171cffae82b0f375;hb=8f919160792e4702c6b7a67a243cea4f757407e4
This one still can't prevent the probe failure...
Any suggestions?
Could you please try it without CONFIG_USB_DEBUG option.
Thanks,
Rajkumar
2010/11/4 Rajkumar Manoharan <[email protected]>:
Quoted 22 lines
Quoted 22 lines
2010/11/2 Rajkumar Manoharan <[email protected]>:
Quoted 12 lines
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2
[ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2:ath9k_htc: Unable to allocate URBs [ 8.037506]ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driverath9k_hif_usbQuoted 6 lines
NACK. To optimize CPU consumption and scan duration, HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
My card is UB91, so you means I should update to this one(ar9271.fw) blew:
Quoted 7 lines
Quoted 5 lines
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux->firmware.git;a=blob;f=ar9271.fw;h=0ec953b404c1912dc64fa3b0171cffae82b0f375;hb=8f919160792e4702c6b7a67a243cea4f757407e4
This one still can't prevent the probe failure...
Any suggestions?
Could you please try it without
CONFIG_USB_DEBUGoption.
I don't think disabling CONFIG_USB_DEBUG can prevent the .probe failure, which only don't print some messages.
So this patch does make sense, doesn't it?
thanks,
Signature · 1 line
Lei Ming
Quoted 27 lines
2010/11/4 Rajkumar Manoharan <[email protected]>:
Quoted 26 lines
Quoted 25 lines
2010/11/2 Rajkumar Manoharan <[email protected]>:
Quoted 12 lines
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ 8.018768] PM: Removing info for No Bus:1-2.2 [ 8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ 8.031707] usb 1-2.2: ath9k_htc: Unable to allocate URBs [ 8.037506] ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ 8.044250] usbcore: registered new interface driver ath9k_hif_usbQuoted 6 lines
NACK. To optimize CPU consumption and scan duration, HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
My card is UB91, so you means I should update to this one(ar9271.fw) blew:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux->>firmware.git;a=blob;f=ar9271.fw;h=0ec953b404c1912dc64fa3b0171cffae82b0f375;hb=8f919160792e4702c6b7a67a243cea4f757407e4
This one still can't prevent the probe failure...
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Any suggestions?
Could you please try it without
CONFIG_USB_DEBUGoption.I don't think disabling
CONFIG_USB_DEBUGcan prevent the .probe failure, which only don't print some messages.So this patch does make sense, doesn't it?
The recent commit "check the endpoint type against the pipe type" in usb under DEBUG is causing probe failure, It's conditional on CONFIG_USB_DEBUG, so it won't affect normal users. But this probe failure under DEBUG needs to be addressed without causing any IOT issue.
Thanks,
Rajkumar
PATCH 1/1 ath9k-htc: fix probe failure
In reply to Ming LeiQuoted 25 lines · Ming Lei
2010/11/4 Rajkumar Manoharan <[email protected]>:
Quoted 24 lines
Quoted 24 lines
2010/11/2 Rajkumar Manoharan <[email protected]>:
Quoted 12 lines
From: Ming Lei <[email protected]>
Obviously, we should set the transfer type consitent with endpoint descriptor type to urb, this patch fixes the probe failure below:
[ ? ?8.018768] PM: Removing info for No Bus:1-2.2
[ ? ?8.019470] usb 1-2.2: BOGUS urb xfer, pipe 3 != type 1 [ ? ?8.031707] usb 1-2.2:ath9k_htc: Unable to allocate URBs [ ? ?8.037506]ath9k_hif_usb: probe of 1-2.2:1.0 failed with error -22 [ ? ?8.044250] usbcore: registered new interface driverath9k_hif_usbQuoted 6 lines
NACK. To optimize CPU consumption and scan duration, ?HTC device firmwares were patched to change descriptor types of EP3 and EP4 from Interrupt to Bulk. After firmware download in initialization, endpoint descriptors got changed. Please use the latest firmwares from linux-firmware git tree.
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=summary
My card is UB91, so you means I should update to this one(ar9271.fw) blew:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux->firmware.git;a=blob;f=ar9271.fw;h=0ec953b404c1912dc64fa3b0171cffae82b0f375;hb=8f919160792e4702c6b7a67a243cea4f757407e4
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
This one still can't prevent the probe failure...
Any suggestions?
Could you please try it without
CONFIG_USB_DEBUGoption.I don't think disabling
CONFIG_USB_DEBUGcan prevent the .probe failure, which only don't print some messages.
UB91 is working for me without this problem with the wireless-testing tree (2.6.36-wl+),so as Raj had told this might be the reason. And CONFIG_USB_DEBUG is by default disabled in .config file of my wireless-testing.
thanks,
shafi
Quoted 13 lines
So this patch does make sense, doesn't it?
thanks,
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html