Skip to contentSkip to conversation

solos: Add 'Firmware' attribute for Traverse overall firmware version

PATCH Applied David Woodhouse 3 participants 4 messages Nov 1, 2010 – Nov 8, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 solos: Add 'Firmware' attribute for Traverse overall firmware version

The existing 'FirmwareVersion' attribute only covers the DSP firmware as provided by Conexant; not the overall version of the device firmware. We do want to be able to see the full version number too.

---
 drivers/atm/solos-attrlist.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/atm/solos-attrlist.c +1 -0
index 1a9332e..9a676ee 100644
@@ -1,6 +1,7 @@
 SOLOS_ATTR_RO(DriverVersion)
 SOLOS_ATTR_RO(APIVersion)
 SOLOS_ATTR_RO(FirmwareVersion)
+SOLOS_ATTR_RO(Version)
 // SOLOS_ATTR_RO(DspVersion)
 // SOLOS_ATTR_RO(CommonHandshake)
 SOLOS_ATTR_RO(Connected)
Signature · 6 lines
1.7.3.1


-- 
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation
#1 lore raw
Quoted 14 lines · On Mon, 01 Nov 2010 16:34:29 -0400 David Woodhouse <[email protected]> wrote:

The existing 'FirmwareVersion' attribute only covers the DSP firmware as provided by Conexant; not the overall version of the device firmware. We do want to be able to see the full version number too.

---
 drivers/atm/solos-attrlist.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/atm/solos-attrlist.c +0 -0
index 1a9332e..9a676ee 100644

drivers/atm/solos-attrlist.c line 7

Quoted 7 lines
drivers/atm/solos-attrlist.c +1 -0
@@ -1,6 +1,7 @@
 SOLOS_ATTR_RO(DriverVersion)
 SOLOS_ATTR_RO(APIVersion)
 SOLOS_ATTR_RO(FirmwareVersion)
+SOLOS_ATTR_RO(Version)
 // SOLOS_ATTR_RO(DspVersion)
 // SOLOS_ATTR_RO(CommonHandshake)
 SOLOS_ATTR_RO(Connected)

There is a firware version in ethtool, does this driver supply it?

#2 lore raw
Quoted 1 line · Stephen Hemminger

There is a firware version in ethtool, does this driver supply it?

This is an ATM driver, so no.

Signature · 1 line
dwmw2