Skip to contentSkip to conversation

bluetooth: bnep: fix information leak to userland

PATCH Applied Vasiliy Kulikov 3 participants 3 messages Oct 30, 2010 – Nov 3, 2010

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bluetooth: bnep: fix information leak to userland

Structure bnep_conninfo is copied to userland with the field "device" that has the last elements unitialized. It leads to leaking of contents of kernel stack memory.

---
Compile tested.

 net/bluetooth/bnep/core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/bluetooth/bnep/core.c +1 -0
index f10b41f..5868597 100644
@@ -648,6 +648,7 @@ int bnep_del_connection(struct bnep_conndel_req *req)
 
 static void __bnep_copy_ci(struct bnep_conninfo *ci, struct bnep_session *s)
 {
+	memset(ci, 0, sizeof(*ci));
 	memcpy(ci->dst, s->eh.h_source, ETH_ALEN);
 	strcpy(ci->device, s->dev->name);
 	ci->flags = s->flags;
Signature · 1 line
1.7.0.4