Skip to contentSkip to conversation

OMAP: DSS2: introduce dummy panel driver

PATCH New Bryan Wu 3 participants 9 messages Nov 2, 2010

Subsystems (4)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

cover OMAP: DSS2: introduce dummy panel driver

There are 4 duplicated panel driver sin DSS2 display driver. They are similar and dummy panel driver can support all them with specific panel configuration. And new panel driver can be easily supported by adding panel configurations into dummy panel driver.

This patchset introduces dummy panel driver, remove 3 panel drivers and enable dummy panel driver in board files. And it is based on 2.6.37-rc1.

Building with omap2plus_defconfig is successful.

Keep sharp_ls_panel, since it contains blacklight control code which will be moved out later.

Bryan Wu (3):
OMAP: DSS2: Add dummy panel display driver
OMAP: DSS2: remove dummy panel driver duplicated panel drivers
OMAP: use dummy panel driver in board files

 arch/arm/mach-omap2/board-3430sdp.c                |    3 +-
 arch/arm/mach-omap2/board-am3517evm.c              |    6 +-
 arch/arm/mach-omap2/board-cm-t35.c                 |    6 +-
 arch/arm/mach-omap2/board-devkit8000.c             |    6 +-
 arch/arm/mach-omap2/board-igep0020.c               |    3 +-
 arch/arm/mach-omap2/board-omap3beagle.c            |    3 +-
 arch/arm/mach-omap2/board-omap3evm.c               |    3 +-
 arch/arm/mach-omap2/board-omap3stalker.c           |    6 +-
 arch/arm/plat-omap/include/plat/display.h          |   28 +-
 drivers/video/omap2/displays/Kconfig               |   22 +-
 drivers/video/omap2/displays/Makefile              |    4 +-
 drivers/video/omap2/displays/panel-dummy.c         |  195 +++++++
 drivers/video/omap2/displays/panel-dummy.h         |  119 +++++
 drivers/video/omap2/displays/panel-generic.c       |  174 -------
 .../video/omap2/displays/panel-sharp-lq043t1dg01.c |  165 ------
 .../video/omap2/displays/panel-tpo-td043mtea1.c    |  535 --------------------
 16 files changed, 364 insertions(+), 914 deletions(-)
 create mode 100644 drivers/video/omap2/displays/panel-dummy.c
 create mode 100644 drivers/video/omap2/displays/panel-dummy.h
 delete mode 100644 drivers/video/omap2/displays/panel-generic.c
 delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
 delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c
author
#1 lore raw

PATCH 1/3 OMAP: DSS2: Add dummy panel display driver

Dummy panel driver includes the driver and 4 similar panel configurations. It will match the panel name which is passed from platform data and setup the right configurations.

With dummy panel driver, we can remove those 4 duplicated panel display drivers. In the future, it is simple for us just add new panel configuration date in panel-dummy.h to support new display panel.

---
 drivers/video/omap2/displays/Kconfig       |    8 +
 drivers/video/omap2/displays/Makefile      |    1 +
 drivers/video/omap2/displays/panel-dummy.c |  195 ++++++++++++++++++++++++++++
 drivers/video/omap2/displays/panel-dummy.h |  119 +++++++++++++++++
 4 files changed, 323 insertions(+), 0 deletions(-)
 create mode 100644 drivers/video/omap2/displays/panel-dummy.c
 create mode 100644 drivers/video/omap2/displays/panel-dummy.h
drivers/video/omap2/displays/Kconfig +8 -0
index 12327bb..4b2ed33 100644
@@ -1,6 +1,14 @@
 menu "OMAP2/3 Display Device Drivers"
         depends on OMAP2_DSS
 
+config PANEL_DUMMY
+        tristate "Dummy Panel"
+        help
+	  Dummy panel driver.
+	  Supports DVI output for Beagle and OMAP3 SDP.
+	  Supports LCD Panel used in TI SDP3430 and EVM boards,
+	  OMAP3517 EVM boards and CM-T35.
+
 config PANEL_GENERIC
         tristate "Generic Panel"
         help
drivers/video/omap2/displays/Makefile +1 -0
index aa38609..5b50036 100644
@@ -1,3 +1,4 @@
+obj-$(CONFIG_PANEL_DUMMY) += panel-dummy.o
 obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
 obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
drivers/video/omap2/displays/panel-dummy.c new file +195 -0

195 lines not on this page · raw message

drivers/video/omap2/displays/panel-dummy.h new file +119 -0

119 lines not on this page · raw message

Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/3 OMAP: DSS2: Add dummy panel display driver

Quoted 9 lines · Bryan Wu

Dummy panel driver includes the driver and 4 similar panel configurations. It will match the panel name which is passed from platform data and setup the right configurations.

With dummy panel driver, we can remove those 4 duplicated panel display drivers. In the future, it is simple for us just add new panel configuration date in panel-dummy.h to support new display panel.

<snip>

drivers/video/omap2/displays/panel-dummy.h

Quoted 5 lines
drivers/video/omap2/displays/panel-dummy.h new file +0 -0
new file mode 100644
index 0000000..ac2b7a2

There is no benefit of having this header, just add all data directly in .c file.

<snip>

Quoted 4 lines

+ ? ? ? /* Sharp LQ043T1DG01 */
+ ? ? ? {
+ ? ? ? ? ? ? ? { ? ? ? .x_res ? ? ? ? ?= 480,
+ ? ? ? ? ? ? ? ? ? ? ? .y_res ? ? ? ? ?= 272,

missing newline after {

author
#3 lore raw

PATCH 1/3 OMAP: DSS2: Add dummy panel display driver

Quoted 22 lines · Grazvydas Ignotas
Quoted 9 lines · Bryan Wu

Dummy panel driver includes the driver and 4 similar panel configurations. It will match the panel name which is passed from platform data and setup the right configurations.

With dummy panel driver, we can remove those 4 duplicated panel display drivers. In the future, it is simple for us just add new panel configuration date in panel-dummy.h to support new display panel.

<snip>

drivers/video/omap2/displays/panel-dummy.h

Quoted 5 lines
drivers/video/omap2/displays/panel-dummy.h new file +0 -0
new file mode 100644
index 0000000..ac2b7a2

There is no benefit of having this header, just add all data directly in .c file.

Quoted 9 lines

<snip>

Quoted 4 lines

+ ? ? ? /* Sharp LQ043T1DG01 */
+ ? ? ? {
+ ? ? ? ? ? ? ? { ? ? ? .x_res ? ? ? ? ?= 480,
+ ? ? ? ? ? ? ? ? ? ? ? .y_res ? ? ? ? ?= 272,

missing newline after {

Thanks, I will take these 2 comments.

Signature · 5 lines
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
author
#4 lore raw

PATCH 2/3 OMAP: DSS2: remove dummy panel driver duplicated panel drivers

In reply to Bryan Wu

Still keep sharp_ls_panel driver, because it contains blacklight control driver.

---
 drivers/video/omap2/displays/Kconfig               |   18 -
 drivers/video/omap2/displays/Makefile              |    3 -
 drivers/video/omap2/displays/panel-generic.c       |  174 -------
 .../video/omap2/displays/panel-sharp-lq043t1dg01.c |  165 ------
 .../video/omap2/displays/panel-tpo-td043mtea1.c    |  535 --------------------
 5 files changed, 0 insertions(+), 895 deletions(-)
 delete mode 100644 drivers/video/omap2/displays/panel-generic.c
 delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
 delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c
drivers/video/omap2/displays/Kconfig +0 -18
index 4b2ed33..4a29863 100644
@@ -9,12 +9,6 @@ config PANEL_DUMMY
 	  Supports LCD Panel used in TI SDP3430 and EVM boards,
 	  OMAP3517 EVM boards and CM-T35.
 
-config PANEL_GENERIC
-        tristate "Generic Panel"
-        help
-	  Generic panel driver.
-	  Used for DVI output for Beagle and OMAP3 SDP.
-
 config PANEL_SHARP_LS037V7DW01
         tristate "Sharp LS037V7DW01 LCD Panel"
         depends on OMAP2_DSS
@@ -22,24 +16,12 @@ config PANEL_SHARP_LS037V7DW01
         help
           LCD Panel used in TI's SDP3430 and EVM boards
 
-config PANEL_SHARP_LQ043T1DG01
-        tristate "Sharp LQ043T1DG01 LCD Panel"
-        depends on OMAP2_DSS
-        help
-          LCD Panel used in TI's OMAP3517 EVM boards
-
 config PANEL_TAAL
         tristate "Taal DSI Panel"
         depends on OMAP2_DSS_DSI
         help
           Taal DSI command mode panel from TPO.
 
-config PANEL_TOPPOLY_TDO35S
-        tristate "Toppoly TDO35S LCD Panel support"
-        depends on OMAP2_DSS
-        help
-          LCD Panel used in CM-T35
-
 config PANEL_TPO_TD043MTEA1
         tristate "TPO TD043MTEA1 LCD Panel"
         depends on OMAP2_DSS && SPI
drivers/video/omap2/displays/Makefile +0 -3
index 5b50036..587bef8 100644
@@ -1,9 +1,6 @@
 obj-$(CONFIG_PANEL_DUMMY) += panel-dummy.o
-obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
 obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
-obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
 
 obj-$(CONFIG_PANEL_TAAL) += panel-taal.o
-obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o
 obj-$(CONFIG_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o
 obj-$(CONFIG_PANEL_ACX565AKM) += panel-acx565akm.o
drivers/video/omap2/displays/panel-generic.c deleted +0 -174

174 lines not on this page · raw message

drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c deleted +0 -165

165 lines not on this page · raw message

drivers/video/omap2/displays/panel-tpo-td043mtea1.c deleted +0 -535

535 lines not on this page · raw message

Signature · 1 line
1.7.1
#5 lore raw

PATCH 2/3 OMAP: DSS2: remove dummy panel driver duplicated panel drivers

Quoted 9 lines · Bryan Wu

Still keep sharp_ls_panel driver, because it contains blacklight control driver.

---

?drivers/video/omap2/displays/Kconfig ? ? ? ? ? ? ? | ? 18 -
?drivers/video/omap2/displays/Makefile ? ? ? ? ? ? ?| ? ?3 -
?drivers/video/omap2/displays/panel-generic.c ? ? ? | ?174 -------
?.../video/omap2/displays/panel-sharp-lq043t1dg01.c | ?165 ------
?.../video/omap2/displays/panel-tpo-td043mtea1.c ? ?| ?535 --------------------
Quoted 4 lines

?5 files changed, 0 insertions(+), 895 deletions(-)
?delete mode 100644 drivers/video/omap2/displays/panel-generic.c ?delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c ?delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c

Hey don't remove panel-tpo-td043mtea1.c, it's not a dupe! You probably confused it with panel-toppoly-tdo35s.c . This shows you did not build test all panel drivers, just select them all in config (enable SPI so they all appear).

author
#6 lore raw

PATCH 3/3 OMAP: use dummy panel driver in board files

In reply to Bryan Wu

Introduce some fields in struct panel, which will be used to match the right panel configurations in dummy driver.

Still keep sharp_ls_panel, since the sharp_ls_panel driver contains blacklight control driver code which will be moved out later. Then we can use dummy driver for sharp_ls_panel.

---
 arch/arm/mach-omap2/board-3430sdp.c       |    3 ++-
 arch/arm/mach-omap2/board-am3517evm.c     |    6 ++++--
 arch/arm/mach-omap2/board-cm-t35.c        |    6 ++++--
 arch/arm/mach-omap2/board-devkit8000.c    |    6 ++++--
 arch/arm/mach-omap2/board-igep0020.c      |    3 ++-
 arch/arm/mach-omap2/board-omap3beagle.c   |    3 ++-
 arch/arm/mach-omap2/board-omap3evm.c      |    3 ++-
 arch/arm/mach-omap2/board-omap3stalker.c  |    6 ++++--
 arch/arm/plat-omap/include/plat/display.h |   28 +++++++++++++++++++---------
 9 files changed, 43 insertions(+), 21 deletions(-)
arch/arm/mach-omap2/board-3430sdp.c +2 -1
index 4e3742c..0e4598d 100644
@@ -272,7 +272,8 @@ static struct omap_dss_device sdp3430_lcd_device = {
 
 static struct omap_dss_device sdp3430_dvi_device = {
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= sdp3430_panel_enable_dvi,
arch/arm/mach-omap2/board-am3517evm.c +4 -2
index 0739950..88c9b76 100644
@@ -306,7 +306,8 @@ static void am3517_evm_panel_disable_lcd(struct omap_dss_device *dssdev)
 static struct omap_dss_device am3517_evm_lcd_device = {
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.name			= "lcd",
-	.driver_name		= "sharp_lq_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "sharp_lq",
 	.phy.dpi.data_lines 	= 16,
 	.platform_enable	= am3517_evm_panel_enable_lcd,
 	.platform_disable	= am3517_evm_panel_disable_lcd,
@@ -349,7 +350,8 @@ static void am3517_evm_panel_disable_dvi(struct omap_dss_device *dssdev)
 static struct omap_dss_device am3517_evm_dvi_device = {
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= am3517_evm_panel_enable_dvi,
 	.platform_disable	= am3517_evm_panel_disable_dvi,
arch/arm/mach-omap2/board-cm-t35.c +4 -2
index 63f764e..a0c555d 100644
@@ -353,7 +353,8 @@ static void cm_t35_panel_disable_tv(struct omap_dss_device *dssdev)
 
 static struct omap_dss_device cm_t35_lcd_device = {
 	.name			= "lcd",
-	.driver_name		= "toppoly_tdo35s_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "toppoly_tdo35s",
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines	= 18,
 	.platform_enable	= cm_t35_panel_enable_lcd,
@@ -362,7 +363,8 @@ static struct omap_dss_device cm_t35_lcd_device = {
 
 static struct omap_dss_device cm_t35_dvi_device = {
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= cm_t35_panel_enable_dvi,
arch/arm/mach-omap2/board-devkit8000.c +4 -2
index 067f437..ce5be9c 100644
@@ -151,7 +151,8 @@ static struct regulator_consumer_supply devkit8000_vio_supply =
 
 static struct omap_dss_device devkit8000_lcd_device = {
 	.name                   = "lcd",
-	.driver_name            = "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type                   = OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines     = 24,
 	.reset_gpio             = -EINVAL, /* will be replaced */
@@ -160,7 +161,8 @@ static struct omap_dss_device devkit8000_lcd_device = {
 };
 static struct omap_dss_device devkit8000_dvi_device = {
 	.name                   = "dvi",
-	.driver_name            = "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type                   = OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines     = 24,
 	.reset_gpio             = -EINVAL, /* will be replaced */
arch/arm/mach-omap2/board-igep0020.c +2 -1
index 5e035a5..f9a3d03 100644
@@ -436,7 +436,8 @@ static void igep2_disable_dvi(struct omap_dss_device *dssdev)
 static struct omap_dss_device igep2_dvi_device = {
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= igep2_enable_dvi,
 	.platform_disable	= igep2_disable_dvi,
arch/arm/mach-omap2/board-omap3beagle.c +2 -1
index 14f4224..11592bf 100644
@@ -197,7 +197,8 @@ static void beagle_disable_dvi(struct omap_dss_device *dssdev)
 static struct omap_dss_device beagle_dvi_device = {
 	.type = OMAP_DISPLAY_TYPE_DPI,
 	.name = "dvi",
-	.driver_name = "generic_panel",
+	.driver_name = "dummy_panel",
+	.panel.name = "generic",
 	.phy.dpi.data_lines = 24,
 	.reset_gpio = 170,
 	.platform_enable = beagle_enable_dvi,
arch/arm/mach-omap2/board-omap3evm.c +2 -1
index b04365c..b7ff779 100644
@@ -303,7 +303,8 @@ static void omap3_evm_disable_dvi(struct omap_dss_device *dssdev)
 
 static struct omap_dss_device omap3_evm_dvi_device = {
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= omap3_evm_enable_dvi,
arch/arm/mach-omap2/board-omap3stalker.c +4 -2
index f252721..19a8fd8 100644
@@ -162,7 +162,8 @@ static void omap3_stalker_disable_lcd(struct omap_dss_device *dssdev)
 
 static struct omap_dss_device omap3_stalker_lcd_device = {
 	.name			= "lcd",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.phy.dpi.data_lines	= 24,
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.platform_enable	= omap3_stalker_enable_lcd,
@@ -210,7 +211,8 @@ static void omap3_stalker_disable_dvi(struct omap_dss_device *dssdev)
 
 static struct omap_dss_device omap3_stalker_dvi_device = {
 	.name			= "dvi",
-	.driver_name		= "generic_panel",
+	.driver_name		= "dummy_panel",
+	.panel.name		= "generic",
 	.type			= OMAP_DISPLAY_TYPE_DPI,
 	.phy.dpi.data_lines	= 24,
 	.platform_enable	= omap3_stalker_enable_dvi,
arch/arm/plat-omap/include/plat/display.h +19 -9
index c915a66..a49c458 100644
@@ -346,6 +346,24 @@ struct omap_overlay_manager {
 	int (*disable)(struct omap_overlay_manager *mgr);
 };
 
+struct omap_display_panel {
+	struct omap_video_timings timings;
+
+	int acbi;	/* ac-bias pin transitions per interrupt */
+	/* Unit: line clocks */
+	int acb;	/* ac-bias pin frequency */
+
+	enum omap_panel_config config;
+
+	int power_on_delay;
+	int power_off_delay;
+	/*
+	 * Used to match device to panel configuration
+	 * when use dummy panel driver
+	 */
+	const char *name;
+};
+
 struct omap_dss_device {
 	struct device dev;
 
@@ -395,15 +413,7 @@ struct omap_dss_device {
 		} venc;
 	} phy;
 
-	struct {
-		struct omap_video_timings timings;
-
-		int acbi;	/* ac-bias pin transitions per interrupt */
-		/* Unit: line clocks */
-		int acb;	/* ac-bias pin frequency */
-
-		enum omap_panel_config config;
-	} panel;
+	struct omap_display_panel panel;
 
 	struct {
 		u8 pixel_size;
Signature · 1 line
1.7.1
#7 lore raw

cover OMAP: DSS2: introduce dummy panel driver

In reply to Bryan Wu
Quoted 35 lines · Bryan Wu

There are 4 duplicated panel driver sin DSS2 display driver. They are similar and dummy panel driver can support all them with specific panel configuration. And new panel driver can be easily supported by adding panel configurations into dummy panel driver.

This patchset introduces dummy panel driver, remove 3 panel drivers and enable dummy panel driver in board files. And it is based on 2.6.37-rc1.

Building with omap2plus_defconfig is successful.

Keep sharp_ls_panel, since it contains blacklight control code which will be moved out later.

Bryan Wu (3):
OMAP: DSS2: Add dummy panel display driver
OMAP: DSS2: remove dummy panel driver duplicated panel drivers
OMAP: use dummy panel driver in board files

  arch/arm/mach-omap2/board-3430sdp.c                |    3 +-
  arch/arm/mach-omap2/board-am3517evm.c              |    6 +-
  arch/arm/mach-omap2/board-cm-t35.c                 |    6 +-
  arch/arm/mach-omap2/board-devkit8000.c             |    6 +-
  arch/arm/mach-omap2/board-igep0020.c               |    3 +-
  arch/arm/mach-omap2/board-omap3beagle.c            |    3 +-
  arch/arm/mach-omap2/board-omap3evm.c               |    3 +-
  arch/arm/mach-omap2/board-omap3stalker.c           |    6 +-
  arch/arm/plat-omap/include/plat/display.h          |   28 +-
  drivers/video/omap2/displays/Kconfig               |   22 +-
  drivers/video/omap2/displays/Makefile              |    4 +-
  drivers/video/omap2/displays/panel-dummy.c         |  195 +++++++
  drivers/video/omap2/displays/panel-dummy.h         |  119 +++++
  drivers/video/omap2/displays/panel-generic.c       |  174 -------
  .../video/omap2/displays/panel-sharp-lq043t1dg01.c |  165 ------
  .../video/omap2/displays/panel-tpo-td043mtea1.c    |  535 --------------------
  16 files changed, 364 insertions(+), 914 deletions(-)
Quoted 6 lines

create mode 100644 drivers/video/omap2/displays/panel-dummy.c create mode 100644 drivers/video/omap2/displays/panel-dummy.h delete mode 100644 drivers/video/omap2/displays/panel-generic.c delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c

Why can't panel-generic.c be reused instead of a new panel-dummy.c?

Sounds like what you're trying to do is to get a generic panel driver; so shouldn't it at least be called generic instead of dummy.

- Anand

author
#8 lore raw

cover OMAP: DSS2: introduce dummy panel driver

Quoted 50 lines · Anand Gadiyar
Quoted 40 lines · Bryan Wu

There are 4 duplicated panel driver sin DSS2 display driver. They are similar
and dummy panel driver can support all them with specific panel configuration.
And new panel driver can be easily supported by adding panel configurations
into dummy panel driver.

This patchset introduces dummy panel driver, remove 3 panel drivers and enable
dummy panel driver in board files. And it is based on 2.6.37-rc1.

Building with omap2plus_defconfig is successful.

Keep sharp_ls_panel, since it contains blacklight control code which will be
moved out later.

Bryan Wu (3):
? OMAP: DSS2: Add dummy panel display driver
? OMAP: DSS2: remove dummy panel driver duplicated panel drivers ? OMAP: use dummy panel driver in board files

?arch/arm/mach-omap2/board-3430sdp.c ? ? ? ? ? ? ? ?| ? ?3 +-
?arch/arm/mach-omap2/board-am3517evm.c ? ? ? ? ? ? ?| ? ?6 +-
?arch/arm/mach-omap2/board-cm-t35.c ? ? ? ? ? ? ? ? | ? ?6 +-
?arch/arm/mach-omap2/board-devkit8000.c ? ? ? ? ? ? | ? ?6 +-
?arch/arm/mach-omap2/board-igep0020.c ? ? ? ? ? ? ? | ? ?3 +-
?arch/arm/mach-omap2/board-omap3beagle.c ? ? ? ? ? ?| ? ?3 +-
?arch/arm/mach-omap2/board-omap3evm.c ? ? ? ? ? ? ? | ? ?3 +-
?arch/arm/mach-omap2/board-omap3stalker.c ? ? ? ? ? | ? ?6 +-
?arch/arm/plat-omap/include/plat/display.h ? ? ? ? ?| ? 28 +-
?drivers/video/omap2/displays/Kconfig ? ? ? ? ? ? ? | ? 22 +-
?drivers/video/omap2/displays/Makefile ? ? ? ? ? ? ?| ? ?4 +-
?drivers/video/omap2/displays/panel-dummy.c ? ? ? ? | ?195 +++++++
?drivers/video/omap2/displays/panel-dummy.h ? ? ? ? | ?119 +++++
?drivers/video/omap2/displays/panel-generic.c ? ? ? | ?174 -------
?.../video/omap2/displays/panel-sharp-lq043t1dg01.c | ?165 ------
?.../video/omap2/displays/panel-tpo-td043mtea1.c ? ?| ?535
Quoted 8 lines

--------------------
?16 files changed, 364 insertions(+), 914 deletions(-)
?create mode 100644 drivers/video/omap2/displays/panel-dummy.c ?create mode 100644 drivers/video/omap2/displays/panel-dummy.h ?delete mode 100644 drivers/video/omap2/displays/panel-generic.c ?delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c ?delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c

Quoted 5 lines

Why can't panel-generic.c be reused instead of a new panel-dummy.c?

Sounds like what you're trying to do is to get a generic panel driver; so shouldn't it at least be called generic instead of dummy.

I assume panel-generic is for some DVI output connection, so I picked up dummy. But yeah, I do prefer to panel-generic driver and maybe change the name "generic-panel" to "dvi".

-Bryan