OMAP: DSS2: introduce generic panel display driver
Subsystems (4)
cover OMAP: DSS2: introduce generic panel display driver
There are 4 duplicated panel drivers in DSS2 display driver. They are similar and generic panel driver can support all them with specific panel configuration. And new panel driver can be easily supported by adding panel configurations into generic panel driver.
This patchset introduces generic panel driver, remove 3 panel drivers and enable generic panel driver in board files. And it is based on 2.6.37-rc1.
Building with omap2plus_defconfig is successful.
Keep sharp_ls_panel, since it contains blacklight control code which will be moved out later.
Bryan Wu (3):
OMAP: DSS2: Add generic panel display driver
OMAP: DSS2: remove generic panel driver duplicated panel drivers
OMAP: use generic panel driver in board files
arch/arm/mach-omap2/board-3430sdp.c | 1 + arch/arm/mach-omap2/board-am3517evm.c | 4 +- arch/arm/mach-omap2/board-cm-t35.c | 4 +- arch/arm/mach-omap2/board-devkit8000.c | 2 + arch/arm/mach-omap2/board-igep0020.c | 1 + arch/arm/mach-omap2/board-omap3beagle.c | 1 + arch/arm/mach-omap2/board-omap3evm.c | 1 + arch/arm/mach-omap2/board-omap3stalker.c | 2 + arch/arm/plat-omap/include/plat/display.h | 28 +++- drivers/video/omap2/displays/Kconfig | 16 +-- drivers/video/omap2/displays/Makefile | 2 - drivers/video/omap2/displays/panel-generic.c | 153 ++++++++++++++++-- .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 165 -------------------- .../video/omap2/displays/panel-toppoly-tdo35s.c | 164 ------------------- 14 files changed, 175 insertions(+), 369 deletions(-) delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c delete mode 100644 drivers/video/omap2/displays/panel-toppoly-tdo35s.c
PATCH 1/3 OMAP: DSS2: Add generic panel display driver
Generic panel driver includes the driver and 4 similar panel configurations. It will match the panel name which is passed from platform data and setup the right configurations.
With generic panel driver, we can remove those 4 duplicated panel display drivers. In the future, it is simple for us just add new panel configuration date in panel-generic.c to support new display panel.
--- drivers/video/omap2/displays/Kconfig | 4 +- drivers/video/omap2/displays/panel-generic.c | 153 +++++++++++++++++++++++--- 2 files changed, 142 insertions(+), 15 deletions(-)
drivers/video/omap2/displays/Kconfig +3 -1
@@ -5,7 +5,9 @@ config PANEL_GENERIC tristate "Generic Panel" help Generic panel driver. - Used for DVI output for Beagle and OMAP3 SDP. + Supports DVI output for Beagle and OMAP3 SDP. + Supports LCD Panel used in TI SDP3430 and EVM boards, + OMAP3517 EVM boards and CM-T35. config PANEL_SHARP_LS037V7DW01 tristate "Sharp LS037V7DW01 LCD Panel"
drivers/video/omap2/displays/panel-generic.c +139 -14
198 lines not on this page · raw message
Signature · 1 line
1.7.1
PATCH 2/3 OMAP: DSS2: remove generic panel driver duplicated panel drivers
In reply to Bryan WuStill keep sharp_ls_panel driver, because it contains blacklight control driver.
--- drivers/video/omap2/displays/Kconfig | 12 -- drivers/video/omap2/displays/Makefile | 2 - .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 165 -------------------- .../video/omap2/displays/panel-toppoly-tdo35s.c | 164 ------------------- 4 files changed, 0 insertions(+), 343 deletions(-) delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c delete mode 100644 drivers/video/omap2/displays/panel-toppoly-tdo35s.c
drivers/video/omap2/displays/Kconfig +0 -12
@@ -16,24 +16,12 @@ config PANEL_SHARP_LS037V7DW01 help LCD Panel used in TI's SDP3430 and EVM boards -config PANEL_SHARP_LQ043T1DG01 - tristate "Sharp LQ043T1DG01 LCD Panel" - depends on OMAP2_DSS - help - LCD Panel used in TI's OMAP3517 EVM boards - config PANEL_TAAL tristate "Taal DSI Panel" depends on OMAP2_DSS_DSI help Taal DSI command mode panel from TPO. -config PANEL_TOPPOLY_TDO35S - tristate "Toppoly TDO35S LCD Panel support" - depends on OMAP2_DSS - help - LCD Panel used in CM-T35 - config PANEL_TPO_TD043MTEA1 tristate "TPO TD043MTEA1 LCD Panel" depends on OMAP2_DSS && SPI
drivers/video/omap2/displays/Makefile +0 -2
@@ -1,8 +1,6 @@ obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o -obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o obj-$(CONFIG_PANEL_TAAL) += panel-taal.o -obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o obj-$(CONFIG_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_PANEL_ACX565AKM) += panel-acx565akm.o
drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c deleted +0 -165
165 lines not on this page · raw message
drivers/video/omap2/displays/panel-toppoly-tdo35s.c deleted +0 -164
164 lines not on this page · raw message
Signature · 1 line
1.7.1
PATCH 3/3 OMAP: use generic panel driver in board files
In reply to Bryan WuIntroduce some fields in struct panel, which will be used to match the right panel configurations in generic panel driver.
Still keep sharp_ls_panel, since the sharp_ls_panel driver contains blacklight control driver code which will be moved out later. Then we can use generic driver for sharp_ls_panel.
--- arch/arm/mach-omap2/board-3430sdp.c | 1 + arch/arm/mach-omap2/board-am3517evm.c | 4 +++- arch/arm/mach-omap2/board-cm-t35.c | 4 +++- arch/arm/mach-omap2/board-devkit8000.c | 2 ++ arch/arm/mach-omap2/board-igep0020.c | 1 + arch/arm/mach-omap2/board-omap3beagle.c | 1 + arch/arm/mach-omap2/board-omap3evm.c | 1 + arch/arm/mach-omap2/board-omap3stalker.c | 2 ++ arch/arm/plat-omap/include/plat/display.h | 28 +++++++++++++++++++--------- 9 files changed, 33 insertions(+), 11 deletions(-)
arch/arm/mach-omap2/board-3430sdp.c +1 -0
@@ -273,6 +273,7 @@ static struct omap_dss_device sdp3430_lcd_device = {static struct omap_dss_device sdp3430_dvi_device = { .name ="dvi" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .platform_enable = sdp3430_panel_enable_dvi,
arch/arm/mach-omap2/board-am3517evm.c +3 -1
@@ -306,7 +306,8 @@ static void am3517_evm_panel_disable_lcd(struct omap_dss_device *dssdev)static struct omap_dss_device am3517_evm_lcd_device = { .type =OMAP_DISPLAY_TYPE_DPI , .name ="lcd" , - .driver_name ="sharp_lq_panel" , + .driver_name ="generic_panel" , + .panel.name ="sharp_lq" , .phy.dpi.data_lines =16 , .platform_enable = am3517_evm_panel_enable_lcd, .platform_disable = am3517_evm_panel_disable_lcd,
@@ -350,6 +351,7 @@ static struct omap_dss_device am3517_evm_dvi_device = { .type = OMAP_DISPLAY_TYPE_DPI, .name = "dvi", .driver_name = "generic_panel", + .panel.name = "dvi", .phy.dpi.data_lines = 24, .platform_enable = am3517_evm_panel_enable_dvi, .platform_disable = am3517_evm_panel_disable_dvi,
arch/arm/mach-omap2/board-cm-t35.c +3 -1
@@ -353,7 +353,8 @@ static void cm_t35_panel_disable_tv(struct omap_dss_device *dssdev)static struct omap_dss_device cm_t35_lcd_device = { .name ="lcd" , - .driver_name ="toppoly_tdo35s_panel" , + .driver_name ="generic_panel" , + .panel.name ="toppoly_tdo35s" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =18 , .platform_enable = cm_t35_panel_enable_lcd,
@@ -363,6 +364,7 @@ static struct omap_dss_device cm_t35_lcd_device = {static struct omap_dss_device cm_t35_dvi_device = { .name ="dvi" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .platform_enable = cm_t35_panel_enable_dvi,
arch/arm/mach-omap2/board-devkit8000.c +2 -0
@@ -152,6 +152,7 @@ static struct regulator_consumer_supply devkit8000_vio_supply =static struct omap_dss_device devkit8000_lcd_device = { .name ="lcd" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .reset_gpio = -EINVAL ,/* will be replaced */
@@ -161,6 +162,7 @@ static struct omap_dss_device devkit8000_lcd_device = {static struct omap_dss_device devkit8000_dvi_device = { .name ="dvi" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .reset_gpio = -EINVAL ,/* will be replaced */
arch/arm/mach-omap2/board-igep0020.c +1 -0
@@ -437,6 +437,7 @@ static struct omap_dss_device igep2_dvi_device = { .type = OMAP_DISPLAY_TYPE_DPI, .name = "dvi", .driver_name = "generic_panel", + .panel.name = "dvi", .phy.dpi.data_lines = 24, .platform_enable = igep2_enable_dvi, .platform_disable = igep2_disable_dvi,
arch/arm/mach-omap2/board-omap3beagle.c +1 -0
@@ -198,6 +198,7 @@ static struct omap_dss_device beagle_dvi_device = { .type = OMAP_DISPLAY_TYPE_DPI, .name = "dvi", .driver_name = "generic_panel", + .panel.name = "dvi", .phy.dpi.data_lines = 24, .reset_gpio = 170, .platform_enable = beagle_enable_dvi,
arch/arm/mach-omap2/board-omap3evm.c +1 -0
@@ -304,6 +304,7 @@ static void omap3_evm_disable_dvi(struct omap_dss_device *dssdev)static struct omap_dss_device omap3_evm_dvi_device = { .name ="dvi" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .platform_enable = omap3_evm_enable_dvi,
arch/arm/mach-omap2/board-omap3stalker.c +2 -0
@@ -163,6 +163,7 @@ static void omap3_stalker_disable_lcd(struct omap_dss_device *dssdev)static struct omap_dss_device omap3_stalker_lcd_device = { .name ="lcd" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .phy.dpi.data_lines =24 , .type =OMAP_DISPLAY_TYPE_DPI , .platform_enable = omap3_stalker_enable_lcd,
@@ -211,6 +212,7 @@ static void omap3_stalker_disable_dvi(struct omap_dss_device *dssdev)static struct omap_dss_device omap3_stalker_dvi_device = { .name ="dvi" , .driver_name ="generic_panel" , + .panel.name ="dvi" , .type =OMAP_DISPLAY_TYPE_DPI , .phy.dpi.data_lines =24 , .platform_enable = omap3_stalker_enable_dvi,
arch/arm/plat-omap/include/plat/display.h +19 -9
@@ -346,6 +346,24 @@ struct omap_overlay_manager {int (*disable)(struct omap_overlay_manager *mgr); }; +struct omap_display_panel { +struct omap_video_timings timings; + +int acbi;/* ac-bias pin transitions per interrupt */ +/* Unit: line clocks */ +int acb;/* ac-bias pin frequency */ + +enum omap_panel_config config; + +int power_on_delay; +int power_off_delay; +/* +* Used to match device to panel configuration +* when use generic panel driver +*/ +const char *name; +}; +struct omap_dss_device {struct device dev;
@@ -395,15 +413,7 @@ struct omap_dss_device { } venc; } phy; -struct { -struct omap_video_timings timings; - -int acbi;/* ac-bias pin transitions per interrupt */ -/* Unit: line clocks */ -int acb;/* ac-bias pin frequency */ - -enum omap_panel_config config; - } panel; +struct omap_display_panel panel;struct {u8 pixel_size;
Signature · 1 line
1.7.1
PATCH 3/3 OMAP: use generic panel driver in board files
Hi,
Quoted 8 lines · linux-omap-owner at vger.kernel.org
Introduce some fields in struct panel, which will be used to match the right panel configurations in generic panel driver.
Still keep
sharp_ls_panel, since thesharp_ls_paneldriver contains blacklight control driver code which will be moved out later. Then we can use generic driver forsharp_ls_panel.Signed-off-by Bryan Wu <[email protected]>
[snip]
Quoted 37 lines
arch/arm/plat-omap/include/plat/display.h +4
-0@@ -346,6 +346,24 @@ struct omap_overlay_manager {int (*disable)(struct omap_overlay_manager *mgr); }; +struct omap_display_panel { +struct omap_video_timings timings; + + int acbi; /* ac-bias pin transitions per interrupt */ + /* Unit: lineclocks */ + int acb; /* ac-bias pin frequency */
arch/arm/plat-omap/include/plat/display.h +12
-4+ +enum omap_panel_config config; + +int power_on_delay; +int power_off_delay; +/* +* Used to match device to panel configuration +* when use generic panel driver +*/ +const char *name; +}; +struct omap_dss_device {struct device dev;@@ -395,15 +413,7 @@ struct omap_dss_device { } venc; } phy; -struct { -struct omap_video_timings timings; - -int acbi;/* ac-bias pin transitions per interrupt */
arch/arm/plat-omap/include/plat/display.h struct omap_dss_device { · line 419
Quoted 9 lines
arch/arm/plat-omap/include/plat/display.h +1
-5-/* Unit: line clocks */ -int acb;/* ac-bias pin frequency */ - -enum omap_panel_config config; - } panel; +struct omap_display_panel panel;struct {u8 pixel_size;
I don't think that changing the omap_dss_device structure is the best way to go about this. Members like power_on_delay and power_off_delay may not be required by all types of panels. Same goes for the new "name" member since its only used by the dummy dpi panels.
I think it would be better to go with the approach taken in panel-taal.c where a struct "panel_config" exists to take care of extra requirements.
The omap_dss_device struct should contain only those members which would be needed by the interface driver files like dsi.c, dpi.c etc. The rest should be taken care of the panel drivers internally.
Archit
PATCH 3/3 OMAP: use generic panel driver in board files
Quoted 66 lines · Archit
Hi,
Quoted 8 lines · [email protected] wrote:
Introduce some fields in struct panel, which will be used to match the right panel configurations in generic panel driver.
Still keep
sharp_ls_panel, since thesharp_ls_paneldriver contains blacklight control driver code which will be moved out later. Then we can use generic driver forsharp_ls_panel.Signed-off-by Bryan Wu <[email protected]>[snip]
Quoted 37 lines
arch/arm/plat-omap/include/plat/display.h +4
-0@@ -346,6 +346,24 @@ struct omap_overlay_manager {int (*disable)(struct omap_overlay_manager *mgr); }; +struct omap_display_panel { +struct omap_video_timings timings; + + int acbi; /* ac-bias pin transitions per interrupt */ + /* Unit: lineclocks */ + int acb; /* ac-bias pin frequency */
arch/arm/plat-omap/include/plat/display.h +12
-4+ +enum omap_panel_config config; + +int power_on_delay; +int power_off_delay; +/* +* Used to match device to panel configuration +* when use generic panel driver +*/ +const char *name; +}; +struct omap_dss_device {struct device dev;@@ -395,15 +413,7 @@ struct omap_dss_device { } venc; } phy; -struct { -struct omap_video_timings timings; - -int acbi;/* ac-bias pin transitions per interrupt */
arch/arm/plat-omap/include/plat/display.h struct omap_dss_device { · line 419
Quoted 9 lines
arch/arm/plat-omap/include/plat/display.h +1
-5-/* Unit: line clocks */ -int acb;/* ac-bias pin frequency */ - -enum omap_panel_config config; - } panel; +struct omap_display_panel panel;struct {u8 pixel_size;I don't think that changing the
omap_dss_devicestructure is the best way to go about this. Members likepower_on_delayandpower_off_delaymay not be required by all types of panels. Same goes for the new "name" member since its only used by the dummy dpi panels.
Quoted 6 lines
I think it would be better to go with the approach taken in
panel-taal.cwhere a struct "panel_config" exists to take care of extra requirements.The
omap_dss_devicestruct should contain only those members which would be needed by the interface driver files likedsi.c,dpi.cetc. The rest should be taken care of the panel drivers internally.
Yes, the configuration for the panel is panel driver specific features, and should not be in the standard structs. No need to add anything to display.h.
In fact, there are things in display.h that should be removed, and this configurable panel driver could do that also. omap_dss_device contains reset_gpio, max_backlight_level, platform_enable/disable and set/get_backlight, which should actually be in panel spesific struct.
Tomi
PATCH 3/3 OMAP: use generic panel driver in board files
Quoted 74 lines · Tomi Valkeinen
Quoted 66 lines · Archit
Hi,
Quoted 8 lines · linux-omap-owner at vger.kernel.org
Introduce some fields in struct panel, which will be used to match the right panel configurations in generic panel driver.
Still keep
sharp_ls_panel, since thesharp_ls_paneldriver contains blacklight control driver code which will be moved out later. Then we can use generic driver forsharp_ls_panel.Signed-off-by Bryan Wu <[email protected]>[snip]
Quoted 44 lines
arch/arm/plat-omap/include/plat/display.h +4
-0@@ -346,6 +346,24 @@ struct omap_overlay_manager { ? ? int (*disable)(struct omap_overlay_manager *mgr); ?}; +struct omap_display_panel { + ? struct omap_video_timings timings; + + ? int acbi; ? ? ? /* ac-bias pin transitions per interrupt */ + ? /* Unit: lineclocks */ + int acb; ? ? ? ?/* ac-bias pin frequency */
arch/arm/plat-omap/include/plat/display.h +12
-0+ + ? enum omap_panel_config config; + + ? int power_on_delay; + ? int power_off_delay; + ? /* + ? ?* Used to match device to panel configuration + ? ?* when use generic panel driver + ? ?*/ + ? const char *name; +}; +?struct
omap_dss_device{
? ? struct device dev;arch/arm/plat-omap/include/plat/display.h +0
-4@@ -395,15 +413,7 @@ struct omap_dss_device { ? ? ? ? ? ? } venc; ? ? } phy; - ? struct { - ? ? ? ? ? struct omap_video_timings timings; - - ? ? ? ? ? int acbi; ? ? ? /* ac-bias pin transitions perinterrupt */
- ? ? ? ? ? /* Unit: line clocks */
- ? ? ? ? ? int acb; ? ? ? ?/* ac-bias pin frequency */ -
- ? ? ? ? ? enumomap_panel_configconfig;
- ? } panel;
+ ? structomap_display_panelpanel;Quoted 2 lines
? ? struct {
? ? ? ? ? ? u8pixel_size;I don't think that changing the
omap_dss_devicestructure is the best way to go about this. Members likepower_on_delayandpower_off_delaymay not be required by all types of panels. Same goes for the new "name" member since its only used by the dummy dpi panels.Quoted 6 lines
I think it would be better to go with the approach taken in
panel-taal.cwhere a struct "panel_config" exists to take care of extra requirements.The
omap_dss_devicestruct should contain only those members which would be needed by the interface driver files likedsi.c,dpi.cetc. The rest should be taken care of the panel drivers internally.
Quoted 9 lines
Yes, the configuration for the panel is panel driver specific features, and should not be in the standard structs. No need to add anything to
display.h.In fact, there are things in
display.hthat should be removed, and this configurable panel driver could do that also.omap_dss_devicecontainsreset_gpio,max_backlight_level, platform_enable/disable and set/get_backlight, which should actually be in panel spesific struct.
After a quick study of panel-taal.c driver and board-4430sdp.c, I believe we can pass the information from *data pointer of struct omap_dss_device. And keep the all panel specific configuration in driver.
I will keep the struct omap_dss_device untouched.
Thanks,
-Bryan
cover OMAP: DSS2: introduce generic panel display driver
In reply to Bryan WuHi,
Quoted 33 lines · Bryan Wu
There are 4 duplicated panel drivers in DSS2 display driver. They are similar and generic panel driver can support all them with specific panel configuration.
And new panel driver can be easily supported by adding panel configurations into generic panel driver.This patchset introduces generic panel driver, remove 3 panel drivers and enable generic panel driver in board files. And it is based on 2.6.37-rc1.
Building with
omap2plus_defconfigis successful.Keep
sharp_ls_panel, since it contains blacklight control code which will be moved out later.Bryan Wu (3):
OMAP: DSS2: Add generic panel display driver
OMAP: DSS2: remove generic panel driver duplicated panel drivers
OMAP: use generic panel driver in board filesarch/arm/mach-omap2/board-3430sdp.c | 1 + arch/arm/mach-omap2/board-am3517evm.c | 4 +- arch/arm/mach-omap2/board-cm-t35.c | 4 +- arch/arm/mach-omap2/board-devkit8000.c | 2 + arch/arm/mach-omap2/board-igep0020.c | 1 + arch/arm/mach-omap2/board-omap3beagle.c | 1 + arch/arm/mach-omap2/board-omap3evm.c | 1 + arch/arm/mach-omap2/board-omap3stalker.c | 2 + arch/arm/plat-omap/include/plat/display.h | 28 +++- drivers/video/omap2/displays/Kconfig | 16 +-- drivers/video/omap2/displays/Makefile | 2 - drivers/video/omap2/displays/panel-generic.c | 153 ++++++++++++++++-- .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 165
Quoted 5 lines
--------------------
.../video/omap2/displays/panel-toppoly-tdo35s.c|
164 ------------------- 14 files changed, 175 insertions(+), 369 deletions(-)
delete mode 100644drivers/video/omap2/displays/panel-sharp-lq043t1dg01.cdelete mode 100644drivers/video/omap2/displays/panel-toppoly-tdo35s.c
This series will break the build if we try to compile after applying only the first or the first two patches of the series since things used by the first patch are introduced in the last patch.
Archit
cover OMAP: DSS2: introduce generic panel display driver
Quoted 42 lines · Archit
Hi,
Quoted 33 lines · Bryan Wu
There are 4 duplicated panel drivers in DSS2 display driver. They are similar and generic panel driver can support all them with specific panel configuration.
And new panel driver can be easily supported by adding panel configurations into generic panel driver.This patchset introduces generic panel driver, remove 3 panel drivers and enable generic panel driver in board files. And it is based on 2.6.37-rc1.
Building with
omap2plus_defconfigis successful.Keep
sharp_ls_panel, since it contains blacklight control code which will be moved out later.Bryan Wu (3):
? OMAP: DSS2: Add generic panel display driver
? OMAP: DSS2: remove generic panel driver duplicated panel drivers ? OMAP: use generic panel driver in board files?arch/arm/mach-omap2/board-3430sdp.c ? ? ? ? ? ? ? ?| ? ?1 + ?arch/arm/mach-omap2/board-am3517evm.c ? ? ? ? ? ? ?| ? ?4 +- ?arch/arm/mach-omap2/board-cm-t35.c ? ? ? ? ? ? ? ? | ? ?4 +- ?arch/arm/mach-omap2/board-devkit8000.c ? ? ? ? ? ? | ? ?2 + ?arch/arm/mach-omap2/board-igep0020.c ? ? ? ? ? ? ? | ? ?1 + ?arch/arm/mach-omap2/board-omap3beagle.c ? ? ? ? ? ?| ? ?1 + ?arch/arm/mach-omap2/board-omap3evm.c ? ? ? ? ? ? ? | ? ?1 + ?arch/arm/mach-omap2/board-omap3stalker.c ? ? ? ? ? | ? ?2 + ?arch/arm/plat-omap/include/plat/display.h ? ? ? ? ?| ? 28 +++- ?drivers/video/omap2/displays/Kconfig ? ? ? ? ? ? ? | ? 16 +-- ?drivers/video/omap2/displays/Makefile ? ? ? ? ? ? ?| ? ?2 - ?drivers/video/omap2/displays/panel-generic.c ? ? ? | ?153 ++++++++++++++++-- ?.../video/omap2/displays/panel-sharp-lq043t1dg01.c | ?165Quoted 5 lines
?--------------------
.../video/omap2/displays/panel-toppoly-tdo35s.c? ?| ?164 ------------------- 14 files changed, 175 insertions(+), 369 deletions(-) delete mode 100644drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c?delete mode 100644drivers/video/omap2/displays/panel-toppoly-tdo35s.c
Quoted 5 lines
This series will break the build if we try to compile after applying only the first or the first two patches of the series since things used by the first patch are introduced in the last patch.
Archit
Got it. I will try to reorder the sequence
Signature · 5 lines
Bryan Wu <[email protected]> Kernel Developer ? ?+86.138-1617-6545 Mobile Ubuntu Kernel Team Canonical Ltd. ? ? ?www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com