Skip to contentSkip to conversation

regulator: Staticise mc13783_powermisc_rmw()

PATCH Applied Mark Brown 3 participants 3 messages Nov 3, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 regulator: Staticise mc13783_powermisc_rmw()

It is not used outside this driver so no need to make the symbol global.

---
 drivers/regulator/mc13783-regulator.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/mc13783-regulator.c +2 -2
index 5e6fa47..47ea999 100644
@@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
 	.get_voltage = mc13783_fixed_regulator_get_voltage,
 };
 
-int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
-									u32 val)
+static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
+				 u32 val)
 {
 	struct mc13783 *mc13783 = priv->mc13783;
 	int ret;
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Mark Brown

It is not used outside this driver so no need to make the symbol global.

It's OK for me, because no other functionalities than regulator's one are influenced by the Power Misc register.

Quoted 19 lines
---
 drivers/regulator/mc13783-regulator.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/mc13783-regulator.c +2 -2
index 5e6fa47..47ea999 100644
@@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
 	.get_voltage = mc13783_fixed_regulator_get_voltage,
 };
 
-int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
-									u32 val)
+static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
+				 u32 val)
 {
 	struct mc13783 *mc13783 = priv->mc13783;
 	int ret;
Signature · 4 lines
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)
#2 lore raw
In reply to Mark Brown
Quoted 6 lines · Mark Brown

It is not used outside this driver so no need to make the symbol global.

---
 drivers/regulator/mc13783-regulator.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk